Migrate InteractionManager - (Newly added usages) batch 1 by mrejdak · Pull Request #94171 · Expensify/App

mrejdak · 2026-06-22T12:25:39Z

Explanation of Change

Migration of remaining usages of InteractionManager.

This PR also migrates the ConfirmModal fromsrc/components/ContactPermissionModal/index.native.tsx to useConfirmModal and refactors the component into a hook src/hooks/ContactPermissionModal/index.native.ts.

Fixed Issues

$ #71913
$ #83071
PROPOSAL:

Tests

Verify that no errors appear in the JS console

ContactPermissionModal

Prerequisites: Have an account with a workspace created and use a simulator/device that hasn't been prompted for contact permissions yet

Navigate to Account -> Troubleshoot and press Clear cache and restart
Go back and press FAB -> Create expense
Input any value and press Next
Attempt to change the destination
A contact import modal will appear
Select "No thanks" / Select "Continue" / Click outside to close it
Verify that the input box focuses correctly

SearchRouter.tsx

Create a new account with a very long name
Create a workspace
Open search router (Cmd + K on web) and type "in:"
Select the suggested long name (so that the input exceeds the right end of the input box)
Verify that the input focus is correct

useSearchBulkActions.tsx

Navigate to Spend -> Reports
Create a report with an expense
Long press on the report and press Select
From the dropdown menu on top select Delete -> Confirm
Verify that the report is deleted correctly

useSelectionModeReportActions.tsx

Create a new report with two expenses
Submit the report
Long press one of the reports and press Select
From the dropdown menu on top select Hold and confirm it (input any reason)
Now select both reports and from the dropdown menu on top select Approve
Verify that the hold menu opens correctly

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

useSearchBulkActions.tsx

leftovers-3-delete-report.mov

iOS: Native

ContactPermissionModal

leftovers-1-contacts.mov

useSelectionModeReportActions.tsx

leftovers-4-onhold.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

SearchRouter.tsx

leftovers-2-search-input.mov

codecov · 2026-06-22T12:30:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...nents/Reactions/ReportActionItemEmojiReactions.tsx	`46.66% <ø> (ø)`
src/hooks/useSelectionModeReportActions.ts	`94.28% <ø> (+2.61%)`	⬆️
src/hooks/useContactPermissionModal/index.ts	`0.00% <0.00%> (ø)`
...rc/components/Search/SearchRouter/SearchRouter.tsx	`57.33% <60.00%> (+0.28%)`	⬆️
src/hooks/useSearchBulkActions.ts	`53.67% <66.66%> (+0.06%)`	⬆️
src/hooks/useExpenseActions.ts	`0.00% <0.00%> (ø)`
src/pages/iou/request/ParticipantSearchResults.tsx	`0.66% <0.00%> (+<0.01%)`	⬆️
...rc/hooks/useContactPermissionModal/index.native.ts	`0.00% <0.00%> (ø)`
... and 153 files with indirect coverage changes

melvin-bot · 2026-06-25T09:52:38Z

@Pujan92 @ikevin127 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40a4ba93e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mrejdak · 2026-06-25T09:58:00Z

I'll be OOO starting tomorrow, so @collectioneur will take care of this PR from now on

Pujan92 · 2026-06-25T12:53:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-25.at.21.06.16.mov

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-26.at.00.07.55.mov

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-30.at.13.46.20.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-26.at.00.02.25.mov

Screen.Recording.2026-06-25.at.23.59.36.mov

Pujan92 · 2026-06-25T18:49:23Z

-            const validTransactions = Object.fromEntries(Object.entries(allTransactions ?? {}).filter((entry): entry is [string, Transaction] => entry[1] !== undefined));
-            InteractionManager.runAfterInteractions(() => {
+        TransitionTracker.runAfterTransitions({
+            waitForUpcomingTransition: true,


Do we need this bcoz I see the delay in opening the delete modal?

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-26.at.00.12.55.mov

Yes, I've confirmed it isn't needed here because the delete modal already waits for the options modal to close. Thanks!

Screen.Recording.2026-06-29.at.11.02.46.mov

… the delay

Pujan92 · 2026-06-30T05:16:06Z

@collectioneur plz fix the conflicts

collectioneur · 2026-06-30T09:11:52Z

@Pujan92 resolved 🫡

Pujan92

LGTM!!

collectioneur · 2026-07-01T10:02:44Z

@roryabraham all fixed, thanks!

github-actions · 2026-07-01T18:12:21Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-01T18:17:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-01T18:19:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94171.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9ce391036b4-a257598-96bf42aaba8964e46066482b51670d057a13e724/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9ce3910-a257598-75e0ed5413ed89c64d4e495f2f6e6aa41dc6c29d/index.html

Web 🕸️
https://94171.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-01T20:12:43Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-01T20:16:00Z

🤖 Help site review: no changes required.

I reviewed the changes in this PR and no updates are needed to the help site files under docs/articles.

This PR is a purely internal engineering refactor with no user-facing behavior change:

Migrates remaining InteractionManager.runAfterInteractions usages to TransitionTracker.runAfterTransitions (ReportActionItemEmojiReactions, SearchRouter, useExpenseActions, useSearchBulkActions, useSelectionModeReportActions, ParticipantSearchResults).
Refactors ContactPermissionModal from a component into the useContactPermissionModal hook (using useConfirmModal).

None of these touch feature behavior, UI copy, tab/settings labels, pricing, or workflows that the help site documents — the contact-permission prompt, search router, and bulk/selection actions all keep their existing user-facing behavior. So there is nothing to document or update.

No draft docs PR was created since no changes are required.

unzig21 · 2026-07-02T05:24:44Z

Deploy Blocker #95114 was identified to be related to this PR.

…miss Restore the InteractionManager deferral around the Search bulk-delete dispatch that Expensify#94171 removed. Dispatching the delete synchronously as the confirm modal dismissed caused the deletion to be dropped on iOS, leaving the selected expenses undeleted (Expensify#95114). Co-authored-by: Marco Chávez <marcochavezf@users.noreply.github.com>

OSBotify · 2026-07-06T15:29:10Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

showConfirmModal case

2696981

melvin-bot Bot assigned mrejdak Jun 22, 2026

mrejdak added 7 commits June 24, 2026 15:20

search router, emoji from anonymous, bulk actions

658f59c

mock transition tracker in test

7dc2fac

selectionmodereportactions

6540b46

cleanup

80e9394

Merge branch 'main' into mrejdak/migrate-interactionmanager-leftovers-1

3efdd39

refactor ContactPermissionModal into a hook

a4322c9

restore eslint disable

40a4ba9

collectioneur approved these changes Jun 25, 2026

View reviewed changes

mrejdak marked this pull request as ready for review June 25, 2026 09:52

mrejdak requested review from a team as code owners June 25, 2026 09:52

melvin-bot Bot requested review from Pujan92, heyjennahay and ikevin127 and removed request for a team June 25, 2026 09:52

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useContactPermissionModal/index.native.ts

github-actions Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useContactPermissionModal/index.native.ts Outdated

github-actions Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useContactPermissionModal/index.native.ts Outdated

github-actions Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useContactPermissionModal/index.native.ts Outdated

mrejdak added 3 commits June 25, 2026 13:33

check if screen is mounted

0fe7bc4

address comments

36ed53d

remove unnecessary transition tracker

d00928d

Pujan92 reviewed Jun 25, 2026

View reviewed changes

remove waitForUpcomingTransition, it isn't needed and introduces only…

08fc402

… the delay

Merge branch 'main' into mrejdak/migrate-interactionmanager-leftovers-1

b914656

Pujan92 approved these changes Jun 30, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham June 30, 2026 09:13

Merge branch 'main' into mrejdak/migrate-interactionmanager-leftovers-1

9f1924c

roryabraham requested changes Jun 30, 2026

View reviewed changes

Comment thread src/hooks/useContactPermissionModal/index.native.ts Outdated

Comment thread src/hooks/useContactPermissionModal/index.ts Outdated

remove disable lint rules from useContactPermissionModal

b3d7447

fix ts

f48ccaa

roryabraham approved these changes Jul 1, 2026

View reviewed changes

roryabraham merged commit 9ce3910 into Expensify:main Jul 1, 2026
34 checks passed

OSBotify mentioned this pull request Jul 1, 2026

Deploy Checklist: New Expensify 2026-07-01 #95081

Closed

97 tasks

This was referenced Jul 2, 2026

[Due for payment 2026-07-13] iOS - Report - User cannot delete an expense or report using "More > Delete" #95111

Closed

[Due for payment 2026-07-13] Spend-Not able to delete expenses in bulk in Spend #95114

Closed

MelvinBot mentioned this pull request Jul 2, 2026

[CP Staging] Fix bulk delete in Search dropping deletions during confirm modal dismiss #95130

Merged

43 tasks

situchan mentioned this pull request Jul 2, 2026

Fix iOS freeze on locked-account pay in selection mode (#95026) #95063

Merged

54 tasks

This was referenced Jul 2, 2026

Revert "Migrate InteractionManager - (Newly added usages) batch 1" #95188

Closed

Revert "Migrate InteractionManager - (Newly added usages) batch 1" #95201

Closed

This was referenced Jul 6, 2026

[Partial Payment x 3][Tracking] Deprecation of InteractionManager #71913

Open

[Due for payment 2026-07-16] InteractionManager migration follow-up #83071

Closed

Uh oh!

Conversation

mrejdak commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mrejdak commented Jun 25, 2026

Uh oh!

Pujan92 commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

collectioneur Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Pujan92 commented Jun 30, 2026

Uh oh!

collectioneur commented Jun 30, 2026

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

collectioneur commented Jul 1, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

OSBotify commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

Uh oh!

unzig21 commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mrejdak commented Jun 22, 2026 •

edited

Loading

codecov Bot commented Jun 22, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Jun 25, 2026 •

edited

Loading