Decompose ReportActionsList: 10 by LukasMod · Pull Request #94149 · Expensify/App

LukasMod · 2026-06-22T09:26:18Z

Explanation of Change

PR 10 of the ReportActionsList decomposition series (tracker #88320, issue #89771). Behavior-preserving cleanup: drop every react-hooks/* eslint-disable from the extracted pipeline hooks and simplify the header.

What changed:

useMarkAsRead.ts - dropped 2 react-hooks/exhaustive-deps disables by moving the report-change and app-visibility bodies into useEffectEvent handlers, each called from a thin effect keyed to its original trigger deps.
useReportActionsScroll.ts - dropped 2 disables via useEffectEvent: the initial scroll-to-bottom is now a mount-once effect, and the IOU-error scroll keeps its original [lastAction] trigger + usePrevious dedup wrapped in a useEffectEvent (so the latest error state is read without becoming a trigger), plus a !lastIOUActionWithError guard so clearing/resolving an error no longer scrolls.
ReportActionsList.tsx - removed the canShowHeader / hasHeaderRendered one-render header gate, its cross-report reset effect, and the <View> spacer; the header now always renders. Removed now-unused View / useRef imports.
ReportActionsListHeader.tsx - simplified to a self-gating component: returns null when a Concierge draft is active, otherwise renders ConciergeThinkingMessage (now keyed by reportID). Dropped the dead ListBoundaryLoader branch, the onRetry prop, and the report Onyx subscription. Never the isLoadingNewerReportActions / hasError props that gate its render branches, so it has returned undefined on every render since fix: infinite loaders in report section #56819 (2025-02-12) and still does on origin/main. No footer consumer. Removing it changes nothing user-visible.

Out of scope / unchanged: hook signatures stay frozen (tests pin them); useUnreadMarker / useReportActionsPagination / useTransactionThread were audited but left untouched (no react-hooks/* disables, already compiler-clean).

Why: removes legacy effect patterns and the header gate so the pipeline hooks pass the React Compiler gate cleanly with zero eslint-disables. Dropping the header gate also removed a render-time ref read, taking ReportActionsList from 2 to 1 react-hooks/refs seatbelt errors.

Fixed Issues

$ #89771
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Test 1: Header + top-pinning (visual)

Open a normal chat → no spacer / skeleton / loader blip at the visual bottom on mount.
Open a transaction-thread report and a money-request report → content pinned to the visual top, no scroll jump on open.

Test 2: IOU error, fresh error scrolls to bottom

Goal: a newly failed action on the newest message must scroll the list to the bottom so the user sees it.

Steps:

Open the report and scroll up into history (so you are not already at the bottom).
DevTools → simulate failing network requests ON.
Send a new message → it fails on the newest action.
Confirm the list auto-scrolls to the bottom to surface the failed action.
Turn failing requests OFF and retry it → confirm the list does not yank to the bottom when the error clears.

Test 3: Concierge thinking (smoke test)

In a Concierge chat, send a message that makes the agent reply.
Confirm the thinking bubble appears

Test 4: Rapid report switching

Prereq: reports A and B both with unread content.

Switch A ↔ B several times quickly.
Confirm each shows only its own messages, the "NEW" marker is correct per report

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-06-26.at.12.28.27.mov

Android: mWeb Chrome

Screen.Recording.2026-06-26.at.12.31.01.mov

iOS: Native

Screen.Recording.2026-06-26.at.12.02.25.mov

iOS: mWeb Safari

Screen.Recording.2026-06-26.at.12.04.55.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-26.at.11.52.05.mov

Screen.Recording.2026-06-26.at.11.46.03.mov

LukasMod · 2026-06-22T09:29:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42e31234cd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-06-23T10:37:20Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.02% <ø> (ø)`
src/hooks/useMarkAsRead.ts	`94.20% <100.00%> (+0.17%)`	⬆️
src/hooks/useReportActionsScroll.ts	`97.95% <100.00%> (+0.08%)`	⬆️
src/pages/home/report/ConciergeThinkingMessage.tsx	`86.36% <100.00%> (-0.16%)`	⬇️
src/pages/inbox/report/ReportActionsList.tsx	`77.21% <100.00%> (-0.50%)`	⬇️
src/pages/inbox/report/ReportActionsListHeader.tsx	`100.00% <100.00%> (ø)`
src/styles/index.ts	`60.71% <ø> (ø)`
... and 18 files with indirect coverage changes

LukasMod · 2026-06-25T14:09:26Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e9d3d5a74

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-06-25T16:24:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ef776c33f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-06-26T06:16:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51e9c89671

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-06-26T06:22:47Z

@codex review

chatgpt-codex-connector · 2026-06-26T06:30:21Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6f324e3ca5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-06-26T10:34:00Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2026-06-30T08:04:17Z

Dead code left behind after deleting ListBoundaryLoader

CONST.LIST_COMPONENTS
CONST.SENTRY_LABEL.REPORT.LIST_BOUNDARY_LOADER_RETRY
Styles listBoundaryLoader, listBoundaryError, listBoundaryErrorText
Translations listBoundary.errorMessage, listBoundary.tryAgain

DylanDylann · 2026-06-30T08:05:03Z

@codex review

chatgpt-codex-connector · 2026-06-30T08:11:15Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 94492f7cfc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-06-30T08:12:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-30.at.15.30.24.mov

Android: mWeb Chrome

Screen.Recording.2026-06-30.at.15.09.23.mov

iOS: HybridApp

Screen.Recording.2026-06-30.at.15.27.55.mov

iOS: mWeb Safari

Screen.Recording.2026-06-30.at.15.08.40.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-30.at.15.06.28.mov

DylanDylann · 2026-06-30T08:12:33Z

@LukasMod One NIT: #94149 (comment). The rest looks good to me

LukasMod · 2026-06-30T08:22:55Z

@DylanDylann Thanks, I will clean it soon and pull main again, I hope test units will be resolved soon

melvin-bot · 2026-06-30T09:00:14Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

LukasMod · 2026-06-30T09:14:09Z

Dead code left behind after deleting ListBoundaryLoader

CONST.LIST_COMPONENTS

CONST.SENTRY_LABEL.REPORT.LIST_BOUNDARY_LOADER_RETRY

Styles listBoundaryLoader, listBoundaryError, listBoundaryErrorText

Translations listBoundary.errorMessage, listBoundary.tryAgain

Removed ✅

DylanDylann · 2026-06-30T09:21:44Z

The failed test looks like a flaky test

rlinoz

PR looks good!

Related question, did we at some point had a skeleton at the top of the loaded messages when opening a report? I feel like we broke it along the way but not 100% sure.

Screen.Recording.2026-06-30.at.09.13.37.mov

OSBotify · 2026-06-30T12:34:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-30T12:40:11Z

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-30T12:46:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94149.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6b171d10dd8-07ec740-016533322a4b4b0da5523d17b45ec8dec6a027dc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6b171d1-07ec740-153d306562ca2d5cd1773d0ab69573c2453266b9/index.html

Web 🕸️
https://94149.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

LukasMod · 2026-06-30T13:26:47Z

PR looks good!

Related question, did we at some point had a skeleton at the top of the loaded messages when opening a report? I feel like we broke it along the way but not 100% sure.

Screen.Recording.2026-06-30.at.09.13.37.mov

I see the same behavior in production, so this could be an older bug, or it might be working as intended. There was definitely no intention to change the skeleton behavior as part of the decomposition plan, so it should work the same as before with every PR we shipped as part of this plan

OSBotify · 2026-07-01T20:12:40Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-01T20:15:15Z

🤖 No help site changes required.

I reviewed this PR and no updates to Expensify's help site files under docs/articles are needed, so I did not create a draft PR.

Why: This is PR 10 of the ReportActionsList decomposition series — an explicitly behavior-preserving internal refactor. Nothing user-facing changes:

The react-hooks/* eslint-disable cleanups in useMarkAsRead.ts and useReportActionsScroll.ts move logic into useEffectEvent handlers but preserve the exact same runtime behavior (scroll-to-bottom, mark-as-read, IOU-error scroll).
The removed ListBoundaryLoader component and its listBoundary translation strings (errorMessage / tryAgain) were dead code — the component has returned undefined on every render since fix: infinite loaders in report section #56819 (2025-02-12) because it was never passed the props that gate its render branches. Removing it and its strings changes nothing users could see.
The ReportActionsListHeader / ConciergeThinkingMessage changes (self-gating header, reportID prop instead of report) are structural refactors with no change to the visible thinking bubble behavior.

There are no new features, settings, UI labels, buttons, or user-facing copy introduced — and no existing help articles reference any of the removed strings or components (verified against docs/articles).

@LukasMod, since no help site changes are required, no draft PR was created. If you believe a user-facing behavior here does warrant a docs update, let me know and I'll open one.

mitarachim · 2026-07-02T00:17:44Z

Deploy Blocker #95103 was identified to be related to this PR.

OSBotify · 2026-07-06T15:29:04Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned LukasMod Jun 22, 2026

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

Comment thread src/hooks/useReportActionsScroll.ts Outdated

LukasMod force-pushed the decompose/ral-10 branch from 42e3123 to a4b5f43 Compare June 23, 2026 10:32

LukasMod added 2 commits June 25, 2026 15:21

use useEffectEvent to fix react-hooks/exhaustive-deps

b5906ea

remove canShowHeader and hasHeaderRendered in ReportActionsList

56b3f3e

LukasMod force-pushed the decompose/ral-10 branch from a4b5f43 to 56b3f3e Compare June 25, 2026 13:25

fix canceled callback case prevLastIOUActionWithErrorID

6e9d3d5

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/hooks/useReportActionsScroll.ts Outdated

LukasMod added 2 commits June 25, 2026 17:12

removes dead code

f2d816e

use useEffectEvent in useReportActionsScroll

4ef776c

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/pages/inbox/report/ReportActionsListHeader.tsx Outdated

fix inverted gating

51e9c89

chatgpt-codex-connector Bot reviewed Jun 26, 2026

View reviewed changes

Comment thread src/pages/home/report/ConciergeThinkingMessage.tsx

update unit tests

6f324e3

remove old comment

4a833cc

LukasMod marked this pull request as ready for review June 26, 2026 10:33

LukasMod requested review from a team as code owners June 26, 2026 10:33

melvin-bot Bot requested a review from DylanDylann June 26, 2026 10:33

melvin-bot Bot requested review from trjExpensify and removed request for a team June 26, 2026 10:34

LukasMod added 2 commits June 29, 2026 15:49

Merge branch 'main' of github.com:Expensify/App into decompose/ral-10

5de8477

Merge branch 'main' of github.com:Expensify/App into decompose/ral-10

90fba6d

LukasMod force-pushed the decompose/ral-10 branch from 27e998a to 90fba6d Compare June 29, 2026 14:37

Merge branch 'main' of github.com:Expensify/App into decompose/ral-10

94492f7

remove unused cons/styles/translations after ListBoundaryLoader

59e62db

LukasMod requested a review from a team as a code owner June 30, 2026 09:00

DylanDylann approved these changes Jun 30, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz June 30, 2026 09:20

rlinoz approved these changes Jun 30, 2026

View reviewed changes

rlinoz merged commit 6b171d1 into Expensify:main Jun 30, 2026
43 of 44 checks passed

OSBotify mentioned this pull request Jul 1, 2026

Deploy Checklist: New Expensify 2026-07-01 #95081

Closed

97 tasks

This was referenced Jul 2, 2026

[Due for payment 2026-07-21] LHN - Marking an unread message as unread does not mark the conversation as unread #95103

Closed

[CP Staging] Fix marking an unread message as unread does not mark the conversation as unread #95166

Merged

Uh oh!

Conversation

LukasMod commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1: Header + top-pinning (visual)

Test 2: IOU error, fresh error scrolls to bottom

Test 3: Concierge thinking (smoke test)

Test 4: Rapid report switching

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

LukasMod commented Jun 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jun 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LukasMod commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Jun 26, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 26, 2026

Uh oh!

melvin-bot Bot commented Jun 26, 2026

Uh oh!

DylanDylann commented Jun 30, 2026

Uh oh!

DylanDylann commented Jun 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 30, 2026

Uh oh!

DylanDylann commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jun 30, 2026

Uh oh!

LukasMod commented Jun 30, 2026

Uh oh!

melvin-bot Bot commented Jun 30, 2026

Uh oh!

LukasMod commented Jun 30, 2026

Uh oh!

DylanDylann commented Jun 30, 2026

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 30, 2026

LukasMod commented Jun 22, 2026 •

edited

Loading

codecov Bot commented Jun 23, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Jun 30, 2026 •

edited

Loading