[No QA] Avoid building archived-reports Set in findLastAccessedReport path by TMisiukiewicz · Pull Request #94146 · Expensify/App

TMisiukiewicz · 2026-06-22T08:21:28Z

Explanation of Change

findLastAccessedReport previously received a pre-built ArchivedReportsIDSet (a Set covering all archived report IDs), which forced every caller to first build that set by iterating the full reportNameValuePairs collection — expensive at scale (we have a state with ~100k entries).

This PR changes the 4th parameter to accept the raw OnyxCollection instead. The archived check is now a direct per-report key lookup (isArchivedReport(reportNameValuePairsCollection?.[key])), which is O(1) and requires no up-front Set construction. All callers are updated to pass the collection they already subscribe to via useOnyx(ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS). A module-scoped Onyx.connect fallback is kept for the rare cases where no collection is passed. useArchivedReportsIDSet / buildArchivedReportsIDSet are left in place for other existing consumers.

Performance impact (100k reports account): -14s on app startup and opening report

Fixed Issues

$ #94166
PROPOSAL:

Tests

No tests needed, pure refactor

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-06-22T08:25:12Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useAutoCreateTrackWorkspace.ts	`85.29% <100.00%> (ø)`
.../AppNavigator/Navigators/ReportsSplitNavigator.tsx	`92.59% <100.00%> (ø)`
src/libs/ReportUtils.ts	`85.20% <100.00%> (-0.02%)`	⬇️
src/libs/navigateAfterOnboarding.ts	`87.50% <100.00%> (ø)`
...gPersonalDetails/BaseOnboardingPersonalDetails.tsx	`87.75% <100.00%> (ø)`
.../OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx	`97.36% <100.00%> (ø)`
src/pages/inbox/ReportRouteParamHandler.tsx	`70.58% <100.00%> (ø)`
...estedFeatures/BaseOnboardingInterestedFeatures.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…et-in-find-last-accessed-report # Conflicts: # src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

melvin-bot · 2026-06-22T12:28:15Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-22T12:39:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-22.15.01.35.mov

Android: mWeb Chrome

2026-06-22.14.58.02.mov

iOS: HybridApp

2026-06-22.15.01.35.mov

iOS: mWeb Safari

2026-06-22.14.58.02.mov

MacOS: Chrome / Safari

2026-06-22.14.55.34.mov

OSBotify · 2026-06-22T13:24:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-22T13:33:28Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-22T13:39:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94146.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0aa56deea56-9980e46-d697f71b0a8447f170bab080e11b866f0b2983c6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0aa56de-9980e46-3695adeec9e32685fe53ad159c5f24d5e7d5b2cc/index.html

Web 🕸️
https://94146.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-22T23:28:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-22T23:30:31Z

🤖 I reviewed the changes in this PR against the help site files under docs/articles.

No help site changes are required.

This is a pure internal performance refactor with no user-facing impact:

findLastAccessedReport now accepts the raw reportNameValuePairs OnyxCollection instead of a pre-built ArchivedReportsIDSet, replacing up-front Set construction with an O(1) per-report key lookup.
All callers are updated to pass the collection they already subscribe to, and a module-scoped Onyx.connect fallback is retained.
The remaining changes are test updates.

There are no new features, settings, tab/button labels, copy, or UI/behavior changes — nothing the help site documents. The PR is also marked [No QA] and described by the author as a pure refactor.

Since no documentation updates are needed, I did not create a draft docs PR — so there is no linked help site PR to review.

@TMisiukiewicz, if you believe a behavior change here should be reflected in the help site, let me know and I'll draft the corresponding docs PR.

OSBotify · 2026-06-23T22:01:10Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:39:40Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Avoid building archived-reports Set in findLastAccessedReport path

62ce15c

melvin-bot Bot assigned TMisiukiewicz Jun 22, 2026

Fix naming-convention lint error in navigateAfterOnboarding test

11261d2

mountiny mentioned this pull request Jun 22, 2026

[Due for payment 2026-06-30] [No QA] Avoid building archived-reports Set in findLastAccessedReport path #94166

Closed

Merge remote-tracking branch 'origin/main' into perf/avoid-archived-s…

5d0a9bb

…et-in-find-last-accessed-report # Conflicts: # src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx

TMisiukiewicz marked this pull request as ready for review June 22, 2026 12:28

TMisiukiewicz requested review from a team as code owners June 22, 2026 12:28

melvin-bot Bot requested review from ZhenjaHorbach and heyjennahay and removed request for a team June 22, 2026 12:28

melvin-bot Bot removed the request for review from a team June 22, 2026 12:28

ZhenjaHorbach approved these changes Jun 22, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny June 22, 2026 13:06

mountiny approved these changes Jun 22, 2026

View reviewed changes

mountiny merged commit 0aa56de into Expensify:main Jun 22, 2026
36 checks passed

This was referenced Jun 22, 2026

[Due for payment 2026-07-21] Add coding-standards rule to prevent eager component-level args for conditionally/lazily-used callees #94219

Closed

[No QA] Add PERF-17 coding-standards rule: Avoid intermediate lookup layers #94220

Merged

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[No QA] Avoid building archived-reports Set in findLastAccessedReport path#94146

[No QA] Avoid building archived-reports Set in findLastAccessedReport path#94146
mountiny merged 3 commits into
Expensify:mainfrom
callstack-internal:perf/avoid-archived-set-in-find-last-accessed-report

TMisiukiewicz commented Jun 22, 2026 •

edited by mountiny

Loading

Uh oh!

codecov Bot commented Jun 22, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

ZhenjaHorbach commented Jun 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TMisiukiewicz commented Jun 22, 2026 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 22, 2026

Uh oh!

ZhenjaHorbach commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TMisiukiewicz commented Jun 22, 2026 •

edited by mountiny

Loading

codecov Bot commented Jun 22, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jun 22, 2026 •

edited

Loading