Fix #admin room visibility in LHN for Track Workspace onboarding#94098
Closed
emkhalid wants to merge 2 commits into
Closed
Fix #admin room visibility in LHN for Track Workspace onboarding#94098emkhalid wants to merge 2 commits into
emkhalid wants to merge 2 commits into
Conversation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR fixes the Track Workspace onboarding flow so the workspace
#adminroom stays visible in the default LHN.The fix is intentionally scoped to the two gating conditions identified in the approved proposal:
SidebarUtilsReportUtilsThis preserves the Concierge routing introduced by PR #82804 while restoring the expected LHN visibility for the
#adminroom.Fixed Issues
$ #92431
PROPOSAL: #92431 (comment)
Tests
+in the email.Track expenses for my business.#adminroom appears in the default LHN without needing search.#adminroom.#adminroom also appears in the default LHN without needing search.Offline tests
#adminroom is visible.#adminroom remains accessible from the LHN.QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-admin.mp4
Android: mWeb Chrome
android-web-admin.mp4
iOS: Native
iOS: mWeb Safari
ios-web-admin.mp4
MacOS: Chrome / Safari
macos-admin.mp4