Rename "Export current view" option and standardize export filenames - #94083
Merged
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index f034b867164..16bb024f7f2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9666,7 +9666,7 @@ Hier ist ein *Testbeleg*, um dir zu zeigen, wie es funktioniert:`,
expenseLevelExport: 'Alle Daten – Ausgabenebene',
exportInProgress: 'Export wird ausgeführt',
conciergeWillSend: 'Concierge wird dir die Datei in Kürze senden.',
- currentView: 'Aktuelle Ansicht exportieren',
+ currentView: 'Aktuelle Ansicht',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2f27bd487c1..36d2362c824 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -9698,7 +9698,7 @@ Voici un *reçu test* pour vous montrer comment ça fonctionne :`,
expenseLevelExport: 'Toutes les données - niveau dépense',
exportInProgress: 'Export en cours',
conciergeWillSend: 'Concierge vous enverra le fichier sous peu.',
- currentView: 'Exporter la vue actuelle',
+ currentView: 'Vue actuelle',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 70091ab871d..5deadc5c585 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -9654,7 +9654,7 @@ Ecco una *ricevuta di prova* per mostrarti come funziona:`,
expenseLevelExport: 'Tutti i dati - livello spesa',
exportInProgress: 'Esportazione in corso',
conciergeWillSend: 'Concierge ti invierà il file a breve.',
- currentView: 'Esporta vista corrente',
+ currentView: 'Vista corrente',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 63a0996d063..352d036affb 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9531,7 +9531,7 @@ ${reportName}`,
expenseLevelExport: 'すべてのデータ - 経費レベル',
exportInProgress: 'エクスポート処理中',
conciergeWillSend: 'Conciergeがまもなくファイルを送信します。',
- currentView: '現在のビューをエクスポート',
+ currentView: '現在のビュー',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 96a213436b3..0d92bf3c6c4 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9620,7 +9620,7 @@ Hier is een *proefbon* om je te laten zien hoe het werkt:`,
expenseLevelExport: 'Alle gegevens - uitgaveniveau',
exportInProgress: 'Export bezig',
conciergeWillSend: 'Concierge stuurt je het bestand zo meteen.',
- currentView: 'Huidige weergave exporteren',
+ currentView: 'Huidige weergave',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9519f36c061..62e10647cb8 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9605,7 +9605,7 @@ Oto *paragon testowy*, żeby pokazać Ci, jak to działa:`,
expenseLevelExport: 'Wszystkie dane – poziom wydatku',
exportInProgress: 'Trwa eksport',
conciergeWillSend: 'Concierge wkrótce wyśle Ci plik.',
- currentView: 'Eksportuj bieżący widok',
+ currentView: 'Bieżący widok',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c1092488265..84971b93c0b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9609,7 +9609,7 @@ Aqui está um *comprovante de teste* para mostrar como funciona:`,
expenseLevelExport: 'Todos os dados - nível de despesa',
exportInProgress: 'Exportação em andamento',
conciergeWillSend: 'O Concierge enviará o arquivo para você em breve.',
- currentView: 'Exportar visão atual',
+ currentView: 'Visualização atual',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ff7f6a47ba8..f40e8a148b0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9349,7 +9349,7 @@ ${reportName}`,
expenseLevelExport: '所有数据 - 报销级别',
exportInProgress: '导出进行中',
conciergeWillSend: 'Concierge 将很快把文件发送给你。',
- currentView: '导出当前视图',
+ currentView: '当前视图',
},
exportDownload: {
preparingTitle: 'Preparing download...',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: def3a096d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rlinoz
marked this pull request as ready for review
June 24, 2026 13:48
melvin-bot
Bot
requested review from
joekaufmanexpensify and
parasharrajat
and removed request for
a team and
joekaufmanexpensify
June 24, 2026 13:48
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
| requestType = 'get', | ||
| onDownloadFailed?: () => void, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| shouldUnlink = false, |
Member
There was a problem hiding this comment.
why do we need this if it is not used?
Member
There was a problem hiding this comment.
I see that it is part of the signature. Can you add a comment here for this disabled rule
Member
|
Maybe try with any custom template. |
Contributor
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
Pass exportName and policyID in their correct argument positions and assert exportName in the queueExportSearchWithTemplate call. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@parasharrajat I can't repro this #94083 (comment) in staging neither on ios or web, can you check again please? Maybe it was something in staging. Screen.Recording.2026-06-26.at.15.56.56.mov |
Member
|
Yes, that issue might be working in staging as well, I tested PROD. It was not working on this PR. let me test it on staging branch locally and see. |
Member
|
so I can reproduce those errors on staging as well. if you can check the logs on my account then it would be good insight. I will complete the checklist in the morning. |
Member
|
Please resolve conflicts. |
Member
There was a problem hiding this comment.
I don't think it is needed. Let's revert.
Member
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots
🔲 iOS / native
27.06.2026_17.29.00_REC.mp4
🔲 iOS / Safari
27.06.2026_17.37.11_REC.mp4
🔲 MacOS / Chrome
26.06.2026_00.16.28_REC.mp4
26.06.2026_00.19.10_REC.mp4
🔲 Android / native
27.06.2026_17.43.13_REC.mp4
🎀 👀 🎀 C+ reviewed
Member
|
Waiting on this #94083 (comment) |
Contributor
Author
|
Fixed @parasharrajat |
parasharrajat
approved these changes
Jun 29, 2026
Valforte
approved these changes
Jun 29, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
60 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.25-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.4.25-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Two changes from the linked issue:
expensify_<exportName>_<uniqueID>.csvname, where<exportName>is the UI label (e.g. "Current view", "Basic export"). The date/time suffix is dropped (the OS already records download time); a unique id prevents collisions.Companion PR: https://github.com/Expensify/Web-Expensify/pull/53872
Fixed Issues
$ #94056
PROPOSAL:
Tests
expensify_easic_export_<id>.csvwith no date/time in the name.expensify_current_view_<id>.csv.expensify_<name>_<id>.csvpattern.expensify_all_data_-_expense_level_export_<id>.csv.appendTimestampdefault is unchanged).Offline tests
QA Steps
Same as the Tests section above, run on the staging environment.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari