Skip to content

fix: autolink on edit #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 4 commits into from
Jun 24, 2022
Merged

fix: autolink on edit #9405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf616ad
fix: autolink on edit
allroundexperts Jun 11, 2022
c3497b9
fix: handled comments
allroundexperts Jun 19, 2022
5a28237
Update Report.js
allroundexperts Jun 24, 2022
e857eb1
fix: removed lint error
allroundexperts Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,10 @@ Onyx.connect({
*/
function editReportComment(reportID, originalReportAction, textForNewComment) {
const parser = new ExpensiMark();
const htmlForNewComment = parser.replace(textForNewComment);

// Do not autolink if someone explicitly tries to remove a link from message.
// https://github.com/Expensify/App/issues/9090
const htmlForNewComment = parser.replace(textForNewComment, {filterRules: _.filter(_.pluck(parser.rules, 'name'), name => name !== 'autolink')});

@luacmartins luacmartins Jun 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allroundexperts Let's add a comment explaining why we are removing autolink as it's not obvious for someone not familiar with this issue.

@luacmartins luacmartins Jun 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allroundexperts bumping this!

@allroundexperts allroundexperts Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luacmartins Updated.

@luacmartins luacmartins Jun 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment looks good, but linting is failing now

@allroundexperts allroundexperts Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luacmartins Fixed.


// Delete the comment if it's empty
if (_.isEmpty(htmlForNewComment)) {
Expand Down