Migrate test drive modal to centered modal layout#94015
Conversation
…tered-modal-layout
…tered-modal-layout
…tered-modal-layout
|
@mountiny could you run a web ad hoc here please ? EDIT: nvm, found the solution I was looking for |
|
@trjExpensify is Test Drive Modal still a used ? I cannot find a flow that would navigate to it in the code |
|
Actually I think its not used anymore |
|
Does clicking on a Test drive onboarding task launch it or something? |
Haven't onboarding checklist got replaced by
Also found Remove TestDrive from sign-up flow, so I guess it's safe to remove it ? |
|
@jmusial The tasks are still A/B tested so some accounts might possibly get the tasks, maybe, perhaps |
I mean in the codebase there is no programmatic navigation to So I have a feeling it's a dead code ? |
|
I agree |
|
It has been resolved via #94322 |

Explanation of Change
This PR it migrates modals from
TestDriveModalto not use Modal component.Depends on #93437
Fixed Issues
$ #90475
PROPOSAL:
Tests
Note:
version of modal showing can be manipulated by typing in console:
or
For web:
/onboarding/test-driveFor native
in
src/hooks/useOnboardingFlow.ts#69For both
2. Verify that modal shows
3. Verify that user can dismiss or watch the video from here
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-19.at.11.30.54.mov
Android: mWeb Chrome
Screen.Recording.2026-06-19.at.11.31.25.mov
iOS: Native
Screen.Recording.2026-06-19.at.11.38.37.mov
iOS: mWeb Safari
Screen.Recording.2026-06-19.at.12.11.18.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-19.at.11.04.22.mov