[No QA] [HOLD - WIP] Helpsite add new partnerprogram by stephanieelliott · Pull Request #93885 · Expensify/App

stephanieelliott · 2026-06-17T22:24:52Z

See: https://github.com/Expensify/Expensify/issues/613636

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Add expensify-partner-program hub to Newdot directory.

…rd Revenue-Share.md

…ing-Guide.md

Added a comprehensive guide on Expensify's Partner Support program, detailing training, partner managers, and support options.

…roved!-Billing.md

melvin-bot · 2026-07-08T05:10:11Z

melvin-bot · 2026-07-08T05:10:13Z

@mollfpr @brianlee-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-07-08T05:13:34Z

HelpDot Documentation Review

Overall Assessment

This PR (marked [HOLD - WIP]) adds a new Expensify Partner Program hub with three articles covering Expensify Card revenue share, ExpensifyApproved! billing, and partner support. It also registers the hub in _routes.yml and adds the hub index.html. The routing/hub scaffolding is correct and consistent with existing hubs. Content quality varies widely: Card-Revenue-Share.md is close to standard, while Understand-ExpensifyApproved\!-Billing.md and especially Your-Expensify-Partner-Manager.md have significant structural and metadata issues, some draft-blocking.

Scores Summary

Readability: 6/10 - The Revenue Share and Billing articles are clear and scannable, but the Billing FAQ contains obviously broken/truncated text ("all woryou'll automatically receive partner pricing for all w"), and the Partner Manager article relies on bold pseudo-headings and colon labels instead of prose.
AI Readiness: 4/10 - Two of three articles are missing the mandatory internalScope field. Your-Expensify-Partner-Manager.md violates the single-#-heading rule with many # H1 sections and has no # title matching its frontmatter title. keywords list "Expensify Classic" on new-expensify articles, misdirecting retrieval.
Style Compliance: 4/10 - Widespread Title Case headings (should be Sentence case), non-task-based headings ("Partner Manager", "Client Account Executive", "Concierge Chat Support"), inconsistent "Revenue Share" vs "revenue share" and "workspace" vs "Workspace", navigation via backticked Support instead of bold, a -- (broken rule) instead of ---, a dangling "Learn how to earn Expensify Card revenue share" with no link, and a relative link missing its leading slash.

Key Findings

Draft-blocking issues (must fix before merge):
- Understand-ExpensifyApproved\!-Billing.md FAQ answer to "Do I automatically receive ExpensifyApproved! pricing?" is truncated/corrupted text.
- Your-Expensify-Partner-Manager.md uses multiple # (H1) headings instead of exactly one # title plus optional # FAQ (Authoring Guidelines Section 4); it also has no # heading matching its title.
- Broken/incomplete links: "Learn how to earn Expensify Card revenue share." has no target; articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses is missing its leading /.
Metadata gaps: internalScope is missing from both the Billing and Partner Manager articles (mandatory per Section 3). "Expensify Classic" keywords appear on new-expensify articles.
Heading compliance: Many headings are Title Case rather than Sentence case, and several are noun-only/label-only rather than task-based (Section 2). Colon-suffixed bold labels ("Purpose:", "Benefits:", "Key Responsibilities:") are used as pseudo-headings.
Consistency: "Revenue Share"/"revenue share" and "workspace"/"Workspace" casing varies within and across files; a near-duplicate heading pair "How ExpensifyApproved! pricing works" / "How ExpensifyApproved billing works" (missing \!) appears in the Billing article.
Positives: Card-Revenue-Share.md is well structured with complete frontmatter (including internalScope), task-based headings, a compliant FAQ, correct relative links, and proper navigation phrasing "In the navigation tabs (on the left on web, on the bottom on mobile)". Routing/hub setup is correct and the handshake.svg icon exists.

Recommendations

Fix the truncated FAQ text in the Billing article and repair all broken/incomplete links before this leaves WIP.
Rework Your-Expensify-Partner-Manager.md to a single # title with task-based ## sections; convert bold pseudo-headings to prose or proper ## headings; add internalScope.
Add internalScope to the Billing article; remove "Expensify Classic" from keywords on all new-expensify articles.
Normalize headings to Sentence case and standardize "revenue share" and "Workspace" usage throughout.
Reference the Support navigation target in bold rather than backticks; replace -- with ---; prefer relative links over full new.expensify.com/university.expensify.com URLs where an internal article exists.

Files Reviewed

docs/_data/_routes.yml - Correct hub registration; consistent with existing entries.
docs/new-expensify/hubs/expensify-partner-program/index.html - Standard hub scaffold; fine.
docs/articles/new-expensify/expensify-partner-program/Card-Revenue-Share.md - Strongest article; minor casing and a -- rule fix needed.
docs/articles/new-expensify/expensify-partner-program/Understand-ExpensifyApproved\!-Billing.md - Missing internalScope, broken FAQ text, dangling/malformed links, duplicate heading.
docs/articles/new-expensify/expensify-partner-program/Your-Expensify-Partner-Manager.md - Multiple # headings, no matching # title, Title Case + non-task-based headings, missing internalScope.

Note: This is a top-level summary review. Detailed line-by-line feedback can be provided as inline comments.

github-actions · 2026-07-08T05:13:46Z

+
+Revenue share payments are deposited into your default connected US business bank account each month. No additional action is required as long as you remain eligible.
+
+--


Formatting violation: This horizontal rule is -- but should be ---. As written it renders as stray text (or an empty heading) instead of a divider. Change it to ---.

github-actions · 2026-07-08T05:13:47Z

+
+---
+
+## How to receive Expensify Card Revenue Share


Terminology/casing inconsistency: "Revenue Share" is Title Case here but sentence case ("revenue share") everywhere else in this article (e.g. the ## Who can earn Expensify Card revenue share and ## How to qualify... headings). Use ## How to receive Expensify Card revenue share for consistent, deterministic terminology.

github-actions · 2026-07-08T05:13:54Z

+
+## Do I automatically receive ExpensifyApproved! pricing?
+
+Yes, once you enroll in the ExpensifyApproved! accountants program, all woryou'll automatically receive partner pricing for all w


Readability violation: This answer is broken/truncated — "all woryou'll automatically receive partner pricing for all w" is garbled and cut off. Rewrite as a complete sentence, e.g. "Yes. Once you enroll in the ExpensifyApproved! accountants program, you'll automatically receive partner pricing for all eligible client Workspaces."

github-actions · 2026-07-08T05:13:57Z

+
+---
+
+## How ExpensifyApproved billing works 


Heading violation: Two issues — (1) "ExpensifyApproved" is missing its trademark ! (should be ExpensifyApproved!) to match the exact feature name used elsewhere, and (2) this heading is nearly identical to ## How ExpensifyApproved! pricing works above and is vague/redundant. Make it specific and task-based, e.g. ## How ExpensifyApproved! consolidated billing works. Also remove the trailing whitespace.

github-actions · 2026-07-08T05:13:59Z

+ - Pay-per-use billing with no annual subscription.
+ - Eligible partners can earn revenue share based on their clients' Expensify Card spending.
+
+Learn how to earn Expensify Card revenue share.


Cross-link violation: This reads like anchor text ("Learn how to earn Expensify Card revenue share.") but is plain text with no link. Per the Cross-Linking Standards, turn it into a descriptive relative link, e.g. [Learn how to earn Expensify Card revenue share](/articles/new-expensify/expensify-partner-program/Card-Revenue-Share).

github-actions · 2026-07-08T05:14:02Z

+2. Choose **Subscription**.
+3. Select **Billing history**.
+
+Select the billing receipt you want to view or download. [Learn how to download receipts](articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses). 


Broken relative link: The link target articles/new-expensify/... is missing a leading slash, so it resolves relative to the current page instead of the site root. Per Link Formatting rules, use a root-relative path: [Learn how to download receipts](/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses).

github-actions · 2026-07-08T05:14:05Z

+
+## What if my clients don't use the Expensify Card?
+
+Clients that don't use the Expensify Card are billed at the standard ExpensifyApproved! rate of $18 per seat per month.


Terminology inconsistency: This says "$18 per seat per month" but the body of the article uses "$18 per active member per month" (see the pricing section). Use "Member" consistently (Expensify terminology) — e.g. "$18 per active member per month".

github-actions · 2026-07-08T05:14:06Z

+title: Understand ExpensifyApproved! Billing
+description: Learn how Expensify bills partners and their clients, including exclusive pricing, and client ID management.
+keywords: [Expensify Classic, ExpensifyApproved, partner billing, client ID, Expensify Card]
+---


Metadata violation: The required internalScope field is missing from the YAML frontmatter. Per the metadata requirements, add it: internalScope: Audience is [role(s)]. Covers [workflow]. Does not cover [exclusions].

github-actions · 2026-07-08T05:14:12Z

+title: Expensify Partner Support
+description: Learn about Expensify's Partner Support program, including training, dedicated partner managers, and real-time chat support.
+keywords: [Expensify Classic, ExpensifyApproved, partner support, training, partner manager, onboarding, concierge]
+---


Metadata violation: The required internalScope field is missing from the YAML frontmatter. Add it per the metadata spec: internalScope: Audience is ExpensifyApproved! partners. Covers the partner support resources available. Does not cover [exclusions].

github-actions · 2026-07-08T05:14:14Z

+keywords: [Expensify Classic, ExpensifyApproved, partner support, training, partner manager, onboarding, concierge]
+---
+
+As an **ExpensifyApproved! Partner**, your firm gains access to exclusive support services designed to enhance your experience and help your clients succeed. This guide outlines the key support resources available to you.


Structure violation: This article has no # H1 title, and the body begins directly with a paragraph. Every article must have exactly one # heading matching the title (# Expensify Partner Support) at the top. Add it above this intro paragraph.

github-actions · 2026-07-08T05:14:18Z

+
+As an **ExpensifyApproved! Partner**, your firm gains access to exclusive support services designed to enhance your experience and help your clients succeed. This guide outlines the key support resources available to you.
+
+# ExpensifyApproved! University


Heading violation (multiple # + not task-based): Only one # heading (the title) is allowed per article, plus # FAQ. This file uses several # headings (# ExpensifyApproved! University, # Partner Manager, # Client Account Executive, # Client Account Manager, # Concierge Chat Support). Demote them all to ##, and make them task-based (start with What/How), e.g. ## What ExpensifyApproved! University offers.

github-actions · 2026-07-08T05:14:19Z

+
+Your **Partner Manager** is your dedicated contact for strategic support.
+
+## Key Responsibilities:


Heading violation: ## Key Responsibilities: is a generic, noun-only heading in Title Case with a trailing colon. Headings must be task-based and sentence case, e.g. ## What your Partner Manager does.

github-actions · 2026-07-08T05:14:21Z

+- Provide recommendations to optimize your clients' accounts.
+- Assist with strategic planning and feature adoption.
+
+## How to Connect with Your Partner Manager


Casing violation: Headings must use sentence case, not Title Case. Change to ## How to connect with your Partner Manager.

github-actions · 2026-07-08T05:14:24Z

+## How to Connect with Your Partner Manager
+To be assigned a **Partner Manager**, you must complete the **ExpensifyApproved! University** training. Once completed, check your **Expensify account**:
+- Look for the **ExpensifyApproved!** logo in the bottom left-hand corner.
+- Navigate to `Support` to message your **Partner Manager**.


Navigation/UI referencing violation: "Navigate to Support" uses the prohibited vague phrase "Navigate to" and formats the UI label in code backticks. Reference the exact UI element in bold, e.g. "Select Support." (Same issue appears at the other "navigate to Support" / "go to Support" instructions in this article.)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a84da0a630

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-08T05:15:02Z

+**Clients using the Expensify Card**
+
+ - Up to a 50% discount, reducing the cost to $9 per active member per month for eligible clients.
+ - [Contact your Partner Manager](/articles/new-expensify/getting-started/Connect-with-Your-ExpensifyApproved-Partner-Team) for international pricing.


Point Partner Manager links at the new article

When partners click this link (and the same FAQ link later in the article), it points to /articles/new-expensify/getting-started/Connect-with-Your-ExpensifyApproved-Partner-Team, but that article does not exist; a repo-wide search only finds these new references, while the support article added here lives under /articles/new-expensify/expensify-partner-program/Your-Expensify-Partner-Manager. This ships a 404 from the new partner-program hub.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-08T05:15:02Z

+2. Choose **Subscription**.
+3. Select **Billing history**.
+
+Select the billing receipt you want to view or download. [Learn how to download receipts](articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses). 


Add the leading slash to the receipt link

When users click this Learn how to download receipts link from the article page, the browser resolves articles/new-expensify/... relative to the current directory, producing /articles/new-expensify/expensify-partner-program/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses, which does not exist. The target article does exist at /articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses, so this needs the leading slash like the other internal links.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-08T05:15:02Z

+
+## Do I automatically receive ExpensifyApproved! pricing?
+
+Yes, once you enroll in the ExpensifyApproved! accountants program, all woryou'll automatically receive partner pricing for all w


Complete the truncated FAQ answer

When readers reach this FAQ, the answer is visibly garbled and cut off (woryou'll ... for all w), so it does not answer whether ExpensifyApproved! pricing is applied automatically and makes the published help article look broken. Replace it with the complete intended sentence before publishing the new hub.

Useful? React with 👍 / 👎.

…and-ExpensifyApproved-Billing.md

OSBotify · 2026-07-10T05:29:53Z

A preview of your ExpensifyHelp changes have been deployed to https://6725fc85.helpdot.pages.dev ⚡️

Updated articles:

stephanieelliott added 9 commits June 17, 2026 12:16

Update _routes.yml

f7a1600

Add expensify-partner-program hub to Newdot directory.

Create Partner-Billing-Guide.md

0f3d755

Create Expensify Card Revenue-Share.md

5ddd2b3

Delete docs/new-expensify/hubs/expensify-partner-program/Expensify Ca…

7c6d74d

…rd Revenue-Share.md

Create index.html

6f0f379

Delete docs/new-expensify/hubs/expensify-partner-program/Partner-Bill…

4b8cd1e

…ing-Guide.md

Create Partner-Billing-Guide.md

834b3c3

Create guide for Expensify Partner Support program

4aeb554

Added a comprehensive guide on Expensify's Partner Support program, detailing training, partner managers, and support options.

Create Card-Revenue-Share.md

e6dfdef

stephanieelliott self-assigned this Jun 17, 2026

github-actions Bot changed the title ~~[HOLD - WIP] Helpsite add new partnerprogram~~ [No QA] [HOLD - WIP] Helpsite add new partnerprogram Jun 17, 2026

This comment has been minimized.

Sign in to view

stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 19, 2026

Update Card-Revenue-Share.md

db5660d

This comment has been minimized.

Sign in to view

Update Card-Revenue-Share.md

dbbbd7d

This comment has been minimized.

Sign in to view

Update and rename Partner-Billing-Guide.md to Understand-ExpensifyApp…

a84da0a

…roved!-Billing.md

This comment has been minimized.

Sign in to view

stephanieelliott marked this pull request as ready for review July 8, 2026 05:09

stephanieelliott requested a review from a team as a code owner July 8, 2026 05:09

melvin-bot Bot requested review from brianlee-expensify and mollfpr July 8, 2026 05:10

melvin-bot Bot removed the request for review from a team July 8, 2026 05:10

Update Card-Revenue-Share.md

7f8b1b4

stephanieelliott removed request for brianlee-expensify and mollfpr July 8, 2026 05:10

This comment has been minimized.

Sign in to view

github-actions Bot reviewed Jul 8, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 8, 2026

View reviewed changes

Update and rename Understand-ExpensifyApproved!-Billing.md to Underst…

a28566c

…and-ExpensifyApproved-Billing.md


		Revenue share payments are deposited into your default connected US business bank account each month. No additional action is required as long as you remain eligible.

		--


		## Do I automatically receive ExpensifyApproved! pricing?

		Yes, once you enroll in the ExpensifyApproved! accountants program, all woryou'll automatically receive partner pricing for all w


		## What if my clients don't use the Expensify Card?

		Clients that don't use the Expensify Card are billed at the standard ExpensifyApproved! rate of $18 per seat per month.


		As an ExpensifyApproved! Partner, your firm gains access to exclusive support services designed to enhance your experience and help your clients succeed. This guide outlines the key support resources available to you.

		# ExpensifyApproved! University


		Your Partner Manager is your dedicated contact for strategic support.

		## Key Responsibilities:

Uh oh!

Conversation

stephanieelliott commented Jun 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

melvin-bot Bot commented Jul 8, 2026

Concierge reviewer checklist:

Uh oh!

melvin-bot Bot commented Jul 8, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Jul 8, 2026

HelpDot Documentation Review

Overall Assessment

Scores Summary

Key Findings

Recommendations

Files Reviewed

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Jul 8, 2026

Choose a reason for hiding this comment