Fix Y axis labels being cut off when intermediate values are longer than min and max by mhawryluk · Pull Request #93817 · Expensify/App

mhawryluk · 2026-06-17T13:35:55Z

Explanation of Change

In line and bar charts the Y-axis label width was being calculated using only the min and max nice-bounds, but intermediate tick values can be wider than either extreme (e.g. a chart spanning $-1–$0 may have $-0.2 as a label). This caused those labels to be clipped. Added getNiceYAxisTicks, which predicts all tick values that victory-native will render. getYAxisLabelWidth now measures every tick and returns the maximum width, so the reserved space always fits the widest label. For the prediction we use the d3-scale library, which victory-native uses under the hood.

Fixed Issues

$ #90646
PROPOSAL: N/A

Tests

Go to Spend, open a line or a bar chart.
Verify the labels of the Y axis are not cut off nor occupy too much unnecessary space.
Check with different data, including: 1 positive value only, 1 negative value only, multiple values where the min and max ticks are not the longest (example: 0 and -2).

Offline tests

N/A

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-06-23.at.16.10.38.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Nagranie.z.ekranu.2026-06-22.o.16.44.21.mov

…han min and max

codecov · 2026-06-17T13:42:00Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Charts/VictoryTheme.ts	`100.00% <100.00%> (ø)`
src/components/Charts/BarChart/BarChartContent.tsx	`1.17% <0.00%> (+0.02%)`	⬆️
...c/components/Charts/LineChart/LineChartContent.tsx	`3.70% <0.00%> (+0.08%)`	⬆️
src/components/Charts/utils/index.ts	`75.90% <41.17%> (-4.33%)`	⬇️
... and 277 files with indirect coverage changes

mhawryluk · 2026-06-17T13:42:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72ed253da5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…uce duplication

borys3kk

Overall changes look good, one minor comment 🚀

melvin-bot · 2026-06-23T14:25:34Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7250ec9f3c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

Good for product 👍

ZhenjaHorbach · 2026-06-24T06:54:10Z

@mhawryluk
Can you fix pipeline issues, please?

mhawryluk · 2026-06-24T07:58:05Z

@mhawryluk Can you fix pipeline issues, please?

yes, looking into it. the knip check is going to fail, since we're using a transitive dependency (on purpose, though I'm not adamant), but it's going to be fine on main since knip check compares main and the branch. not sure what's happening with the unit tests though

mhawryluk · 2026-06-24T08:24:25Z

@ZhenjaHorbach after merging main the tests passed and the Knip check fails expectedly (let me know if you agree)

ZhenjaHorbach · 2026-06-24T14:17:00Z

@ZhenjaHorbach after merging main the tests passed and the Knip check fails expectedly (let me know if you agree)

I suppose it came from this PR

knip fails because d3-scale is imported in src/components/Charts/utils/index.ts but not declared in package.json (it's only transitive via victory-native)
Could you add it directly to avoid relying on a phantom dependency?

npm install d3-scale@4.0.2

It should help

mhawryluk · 2026-06-24T14:32:23Z

it did come from this PR, but it was expected, intentional and we can leave it failing. we use d3-scale library in the measurements because it's what victory-native uses and we want to match as well as possible, so a transitive dependency ensures we use the same version. though admittedly I think it's not likely for the algorithm to change, so it shouldn't be a big deal, if the versions drift apart. so I will install it

github-actions · 2026-06-24T14:49:05Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

ZhenjaHorbach · 2026-06-26T11:17:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-26.13.20.32.mov

Android: mWeb Chrome

2026-06-26.13.20.32.mov

iOS: HybridApp

2026-06-26.13.15.34.mov

iOS: mWeb Safari

2026-06-26.13.12.57.mov

MacOS: Chrome / Safari

2026-06-26.13.10.28.mov

OSBotify · 2026-06-26T13:53:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-26T13:59:50Z

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-26T14:05:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93817.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-096bee39ac1-27a47d6-b587fbf32fd2c1e5accd93cce4b8ea02847f718c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-096bee3-27a47d6-5ceb06dcbc5cc7695b2d44f3858b463d28fff29c/index.html

Web 🕸️
https://93817.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-26T20:00:12Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.4.21-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-06-29T12:36:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix Y axis labels being cut off when intermediate values are longer t…

72ed253

…han min and max

melvin-bot Bot assigned mhawryluk Jun 17, 2026

chatgpt-codex-connector Bot reviewed Jun 17, 2026

View reviewed changes

Comment thread src/components/Charts/BarChart/BarChartContent.tsx Outdated

mhawryluk added 9 commits June 17, 2026 16:14

Fix yAxisLabelWidth for all-positive values

ab59b24

Include domain padding in calculations

75c5f50

Fix getNiceYAxisTicks for singular non-nice data

044fc2b

Remove old functions

49c331c

Use d3-scale in getNiceYAxisTicks

36cc6e5

Fix spell check

e07af47

Remove useYAxisLabelWidth, update getYAxisLabelWidth signature to red…

d1883da

…uce duplication

Make sure d3 mock matches the library exactly

2b818bf

Change .js to .ts for d3-scale mock

6325718

borys3kk approved these changes Jun 23, 2026

View reviewed changes

Comment thread src/components/Charts/BarChart/BarChartContent.tsx Outdated

mhawryluk added 2 commits June 23, 2026 15:09

Refactor yAxisLabelWidth to accept null fontMgr

836331f

Merge branch 'main' into fix/y-axis-labels-intermediate

7250ec9

mhawryluk marked this pull request as ready for review June 23, 2026 14:25

mhawryluk requested review from a team as code owners June 23, 2026 14:25

melvin-bot Bot requested a review from ZhenjaHorbach June 23, 2026 14:25

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team June 23, 2026 14:25

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread src/components/Charts/BarChart/BarChartContent.tsx Outdated

Fix plot area height passed as y scale

f0f3101

joekaufmanexpensify previously approved these changes Jun 23, 2026

View reviewed changes

Merge branch 'main' into fix/y-axis-labels-intermediate

4710ee0

Add d3-scale to package.json dependencies

b0899e4

mhawryluk dismissed joekaufmanexpensify’s stale review via b0899e4 June 24, 2026 14:48

Move d3-scale mock to __mocks__ directory

49d96a7

ZhenjaHorbach approved these changes Jun 26, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath June 26, 2026 11:21

puneetlath approved these changes Jun 26, 2026

View reviewed changes

puneetlath merged commit 096bee3 into Expensify:main Jun 26, 2026
42 checks passed

OSBotify mentioned this pull request Jun 26, 2026

Deploy Checklist: New Expensify 2026-06-26 #94730

Closed

55 tasks

melvin-bot Bot mentioned this pull request Jun 29, 2026

[Due for payment 2026-07-06] Improve line chart styling with marker borders, gradient fill, and brand green color #90646

Closed

Uh oh!

Conversation

mhawryluk commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 17, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mhawryluk commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

borys3kk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 24, 2026

Uh oh!

mhawryluk commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 24, 2026

Uh oh!

ZhenjaHorbach commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhawryluk commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

ZhenjaHorbach commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

github-actions Bot commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mhawryluk commented Jun 17, 2026 •

edited

Loading

codecov Bot commented Jun 17, 2026 •

edited by github-actions Bot

Loading

mhawryluk commented Jun 24, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 24, 2026 •

edited

Loading

mhawryluk commented Jun 24, 2026 •

edited

Loading

ZhenjaHorbach commented Jun 26, 2026 •

edited

Loading