docs: [No QA] Clarify C+ may ask assigned contributor or Melvin to implement#93735
Draft
MelvinBot wants to merge 1 commit into
Draft
docs: [No QA] Clarify C+ may ask assigned contributor or Melvin to implement#93735MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
…mplement Co-authored-by: Jules <Julesssss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Follow-up to the merged #93066, addressing a review comment from
mallenexpensify.The Contributor+ (C+) row in
contributingGuides/HOW_TO_WORK_WITH_MELVINBOT.mdpreviously implied the C+ always asks Melvin to implement after a proposal is accepted. That is only true when Melvin's proposal is accepted. If the accepted proposal is from a contributor, the assigned contributor creates the PR instead. This clarifies that the C+ asks "the assigned contributor to create a PR or Melvin to implement".Fixed Issues
$ #93064
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
N/A — documentation only.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
N/A — documentation only ([No QA]).
PR Author Checklist
### Fixed Issuessection aboveScreenshots/Videos
N/A — documentation only.