Skip to content

[Hold Web-E/53760] Handle copy policy settings failure in modal with retry option#93710

Draft
fedirjh wants to merge 7 commits into
Expensify:mainfrom
fedirjh:fedirjh/handle-copy-policy-settings-failure-modal
Draft

[Hold Web-E/53760] Handle copy policy settings failure in modal with retry option#93710
fedirjh wants to merge 7 commits into
Expensify:mainfrom
fedirjh:fedirjh/handle-copy-policy-settings-failure-modal

Conversation

@fedirjh

@fedirjh fedirjh commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

When the backend BulkCopyPolicySettings job fails, this PR displays the failure state in the CopyPolicySettingsProgressModal with:

  • An error title ("Copy failed")
  • The error message from the backend (or a default message)
  • A "Try again" button that navigates back to the copy settings page
  • A "Dismiss" button to close the modal

Also consolidates duplicate tryAgain translation keys into common.tryAgain across the codebase.

Fixed Issues

$ #92563

Tests

  1. Start copying workspace settings to multiple workspaces
  2. Wait for (or simulate) a backend job failure
  3. Verify the modal shows "Copy failed" with an error message
  4. Click "Try again" - verify it navigates back to copy settings page
  5. Click "Dismiss" - verify the modal closes
  • Verify that no errors appear in the JS console

Offline tests

N/A - This feature relies on backend job completion which requires network connectivity.

QA Steps

  1. Navigate to a workspace > Settings > Copy settings
  2. Select destination workspaces and settings to copy
  3. Click Copy to start the job
  4. If the job fails (may need backend simulation), verify:
    • Modal shows "Copy failed" title
    • Error message is displayed
    • "Try again" button navigates back to copy settings
    • "Dismiss" button closes the modal
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

fedirjh added 5 commits June 16, 2026 14:04
@fedirjh
Add error field to CopyPolicySettingsNVP type
3a9efba 
Add optional error field to receive error messages from the backend
when the bulk copy job fails.
@fedirjh
Add translations for copy settings failure state
e1fddaa 
Add copyFailedTitle and tryAgain translations for the failure modal.
@fedirjh
Handle failed state in CopyPolicySettingsProgressModal
2dd26e8 
When the backend reports state='failed', show a failure modal with:
- Error message from the backend (or default message)
- Try again button to navigate back to copy settings flow
- Dismiss button to close the modal
@fedirjh
refactor: consolidate tryAgain translations to common
393dd52 
Move the 'Try again' translation to common.tryAgain and remove duplicate
keys from onfidoStep, workspace.companyCards.error,
workspace.copyPolicySettings.progress, and listBoundary sections
across all language files.
@fedirjh
refactor: update components to use common.tryAgain
b503100 
Update WorkspaceCompanyCardsTable, ListBoundaryLoader, VerifyIdentity,
OnfidoPrivacy, and CopyPolicySettingsProgressModal to use the
consolidated common.tryAgain translation key.
@melvin-bot

melvin-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@fedirjh fedirjh changed the title Handle copy policy settings failure in modal with retry option [Hold Web-E/53760] Handle copy policy settings failure in modal with retry option Jun 16, 2026
fedirjh added 2 commits June 16, 2026 15:36
@fedirjh
Add tests for copy policy settings failure state
723e329 
Tests cover the new failure state handling in
CopyPolicySettingsProgressModal including UI elements,
error messages, navigation behavior, and edge cases.
@fedirjh
Merge branch 'Expensify:main' into fedirjh/handle-copy-policy-setting…
d98f0c7 
…s-failure-modal
@codecov

codecov Bot commented Jun 16, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...onents/Tables/WorkspaceCompanyCardsTable/index.tsx 0.00% <ø> (ø)
src/pages/inbox/report/ListBoundaryLoader.tsx 56.66% <ø> (ø)
...PolicySettings/CopyPolicySettingsProgressModal.tsx 100.00% <100.00%> (ø)
.../pages/EnablePayments/Pay/Onfido/OnfidoPrivacy.tsx 0.00% <0.00%> (ø)
...ePayments/Wallet/VerifyIdentity/VerifyIdentity.tsx 0.00% <0.00%> (ø)
... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fedirjh fedirjh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fedirjh