Fix - Workspace chat - Both error messages appear when submitting expense fails by FitseTLT · Pull Request #93698 · Expensify/App

FitseTLT · 2026-06-16T13:20:43Z

Explanation of Change

Fixed Issues

$ #92279
PROPOSAL: #92279 (comment)

Tests

Create a workspace
Navigate to Account > TroubleShoot > Toggle Simulate failing network requests
Go to Inbox > open the workspace chat > Tap "+" button > Create expense > Complete the expense creation flow
Open the report details view
Verify duplicate error messages are not shown.

Test 2

Navigate to Account > TroubleShoot > Toggle Simulate failing network requests
FAB > create expense
Enter amount
In confirm page press on To field and input a new user name you haven't chatted with and create expense
Verify that on the chat page you are only shown one error message (no duplicate error).
Open the expense details view
Verify that you are not shown a duplicate error message.

Verify that no errors appear in the JS console

Offline tests

same as tests

QA Steps

same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-06-16T13:20:51Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-06-16T13:25:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...nents/ReportActionItem/MoneyRequestReceiptView.tsx	`69.51% <100.00%> (ø)`
src/pages/inbox/ReportScreen.tsx	`95.65% <100.00%> (-0.10%)`	⬇️
src/pages/inbox/report/ReportActionItemCreated.tsx	`97.56% <100.00%> (ø)`
.../MoneyRequestReportView/MoneyRequestReportView.tsx	`0.00% <0.00%> (ø)`
... and 26 files with indirect coverage changes

dmkt9 · 2026-06-17T09:33:58Z

            pendingAction={report?.pendingFields?.addWorkspaceRoom ?? report?.pendingFields?.createChat}
            errors={report?.errorFields?.addWorkspaceRoom ?? report?.errorFields?.createChat}
-            errorRowStyles={[styles.ml10, styles.mr2]}
+            errorRowStyles={[styles.ml10, styles.mr2, styles.mb2]}


I think we shouldn't add this style.

It looks bad for workspace room error that's why I added but I know we didn't introduce it should I revert?

Yes. It's out of scope for this PR, so I think we should leave it as is.

@dmkt9 BTW this is how it appears now

compared to before

Thanks for the clarification. However, the change also affects spacing here, which may be unexpected. I suggest we only add spacing for report?.errorFieldsrrorFields?.addWorkspaceRoom error. Wdyt?

I knew that but that is also a better UI. We give 8px spacing for error row in ReportScreen. Applied for all cases.

dmkt9 · 2026-06-17T09:53:59Z

Navigate to Account > TroubleShoot > Toggle Simulate failing network requests

@FitseTLT you have a duplicate "Toggle Simulate failing network requests" step, which results in turning Simulate failing network requests off.

dmkt9 · 2026-06-17T10:05:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.hybrid.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: HybridApp

ios.hybrid.mp4

iOS: mWeb Safari

ios.safari.mp4

MacOS: Chrome / Safari

mac.safari.mp4

FitseTLT · 2026-06-17T11:39:55Z

Navigate to Account > TroubleShoot > Toggle Simulate failing network requests

@FitseTLT you have a duplicate "Toggle Simulate failing network requests" step, which results in turning Simulate failing network requests off.

It was kind of intentional because they are two different steps btw.

dmkt9 · 2026-06-17T13:35:43Z

Navigate to Account > TroubleShoot > Toggle Simulate failing network requests

@FitseTLT you have a duplicate "Toggle Simulate failing network requests" step, which results in turning Simulate failing network requests off.

It was kind of intentional because they are two different steps btw.

@FitseTLT I know that. However, I'm concerned that QA might be confused by it. Alternatively, you could split it into two separate tests for better clarity.

dmkt9

LGTM

FitseTLT · 2026-06-17T13:38:40Z

BTW it is already split separate numbered list in side edit view but when saved it combines it 😄 Very odd. NOw I had to add a title between them.

Valforte · 2026-06-17T18:41:52Z

Tests failed

FitseTLT · 2026-06-17T22:34:18Z

asking @dmkt9 a question

dmkt9 · 2026-06-18T01:52:23Z

Updated my checklist to use the latest template to fix the "PR Reviewwer Checklist" failure

github-actions · 2026-06-18T13:40:22Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-18T13:45:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-18T13:46:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93698.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2db5755cb27-57a8e82-21a714aa9be6941a9a8919a860d2a71fc5cacdff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2db5755-57a8e82-7c2e95c29b6978b3ea4fd4fbff344f6e1bf62777/index.html

Web 🕸️
https://93698.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-18T17:18:13Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-06-18T17:21:15Z

🤖 Help site review: no changes required

I reviewed the changes in this PR against the help site files under App/docs/articles.

This PR is an internal bug fix that prevents duplicate error messages from appearing when an expense submission fails (e.g. while offline / simulating failing network requests). The changes are limited to error-deduplication logic in four React components:

src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
src/components/ReportActionItem/MoneyRequestReceiptView.tsx
src/pages/inbox/ReportScreen.tsx
src/pages/inbox/report/ReportActionItemCreated.tsx

There is no change to any user-facing feature, workflow, setting, tab, or button label that the help site documents — it only affects how an already-existing error state is rendered (one message instead of two). The help site does not document transient error-message rendering behavior, so no article needs updating and no draft docs PR was created.

@FitseTLT, if you believe a help site article is nonetheless affected, let me know which one and I'll open a draft PR.

OSBotify · 2026-06-19T15:24:05Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

FitseTLT added 2 commits June 15, 2026 19:53

Avoided displaying duplicate errors

bc7bf89

Merge branch 'main' into fix-showing-duplicate-errors

d5b46ad

FitseTLT requested review from a team as code owners June 16, 2026 13:20

melvin-bot Bot assigned FitseTLT Jun 16, 2026

melvin-bot Bot requested review from dmkt9 and trjExpensify and removed request for a team and trjExpensify June 16, 2026 13:20

melvin-bot Bot removed the request for review from a team June 16, 2026 13:20

dmkt9 reviewed Jun 17, 2026

View reviewed changes

revert spacing

11743ac

dmkt9 approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot requested a review from Valforte June 17, 2026 13:38

Merge branch 'main' into fix-showing-duplicate-errors

f5b7519

give spacing

2dc01cd

Valforte approved these changes Jun 18, 2026

View reviewed changes

Valforte merged commit 2db5755 into Expensify:main Jun 18, 2026
34 checks passed

OSBotify mentioned this pull request Jun 18, 2026

Deploy Checklist: New Expensify 2026-06-18 #93956

Closed

45 tasks

melvin-bot Bot mentioned this pull request Jun 19, 2026

[Due for payment 2026-06-26] [$250] Workspace chat - Both error messages appear when submitting expense fails #92279

Open

7 tasks

Uh oh!

Conversation

FitseTLT commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 16, 2026

Uh oh!

codecov Bot commented Jun 16, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dmkt9 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 commented Jun 17, 2026

Uh oh!

dmkt9 commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Jun 17, 2026

Uh oh!

dmkt9 commented Jun 17, 2026

Uh oh!

dmkt9 left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Jun 17, 2026

Uh oh!

Valforte commented Jun 17, 2026

Uh oh!

FitseTLT commented Jun 17, 2026

Uh oh!

dmkt9 commented Jun 18, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FitseTLT commented Jun 16, 2026 •

edited

Loading

codecov Bot commented Jun 16, 2026 •

edited by github-actions Bot

Loading

FitseTLT Jun 17, 2026 •

edited

Loading

dmkt9 commented Jun 17, 2026 •

edited

Loading