Add Certinia PSA export settings by ShridharGoel · Pull Request #93634 · Expensify/App

ShridharGoel · 2026-06-15T21:44:27Z

Explanation of Change

Adds the Certinia PSA export settings experience.

When a Certinia connection has PSA enabled, the Export page now shows the PSA rows: Preferred exporter, Expense report status, Export reimbursable expenses as Expense Reports, and Export non-reimbursable expenses as Expense Reports. The PSA version does not show Payable invoice date or Default vendor because PSA exports Expense Reports instead of Payable Invoices.

This also implements the Expense report status selector with Approved and Submitted options using the existing offline feedback pattern.

Fixed Issues

$ #89440
PROPOSAL:

Tests

Mock or use a Certinia connection with config.hasPSA === true.
Go to Workspace settings > Accounting > Export.
Verify the page shows Preferred exporter, Expense report status, Export reimbursable expenses as Expense Reports, and Export non-reimbursable expenses as Expense Reports.
Verify Payable invoice date and Default vendor do not appear for PSA.
Tap Expense report status.
Verify the page shows Approved and Submitted options.
Select a different option and verify the row updates with pending feedback.
Mock or use an FFA Certinia connection with config.hasPSA false or missing.
Verify the original FFA export rows still appear, including Payable invoice date and Default vendor.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.3.40.07.AM.mov

melvin-bot · 2026-06-15T21:44:32Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-06-15T21:52:11Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.84% <ø> (ø)`
src/libs/actions/connections/FinancialForce.ts	`0.00% <0.00%> (ø)`
...ages/workspace/accounting/PolicyAccountingPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/accounting/utils.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/accounting/certinia/utils.ts	`0.00% <0.00%> (ø)`
.../accounting/certinia/export/CertiniaExportPage.tsx	`0.00% <0.00%> (ø)`
...certinia/export/CertiniaReportExportStatusPage.tsx	`0.00% <0.00%> (ø)`
...ccounting/certinia/CertiniaCompanySelectorPage.tsx	`0.00% <0.00%> (ø)`
... and 17 files with indirect coverage changes

melvin-bot · 2026-06-15T22:23:26Z

@ChavdaSachin @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b1c4863b1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

Core design doc issue

# Conflicts: # src/libs/API/types.ts # src/libs/actions/connections/FinancialForce.ts # src/pages/workspace/accounting/certinia/export/CertiniaExportPage.tsx # src/pages/workspace/accounting/certinia/utils.ts

thelullabyy · 2026-06-17T00:47:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-06-17.at.19.14.14.mov

thelullabyy

LGTM

github-actions · 2026-06-18T01:26:04Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-18T01:30:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-18T01:31:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93634.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0fb15be6fad-adb47a2-d924591e1731f4fa117b1dd560c74e9931d6f047/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0fb15be-adb47a2-abd60b23167724a888dfee9c82f1325360733404/index.html

Web 🕸️
https://93634.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-18T17:18:10Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2026-06-19T15:24:02Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ShridharGoel added 4 commits June 12, 2026 14:59

Add Certinia PSA company selector

c799259

Fix Certinia company title fallback

ee78e0e

Merge branch 'main' of https://github.com/Expensify/App into cert2

f63c4aa

Add Certinia PSA export settings

2f5d049

melvin-bot Bot assigned ShridharGoel Jun 15, 2026

Fix Certinia PSA report status route

5a055c2

ShridharGoel added 4 commits June 16, 2026 03:26

Fix Certinia report export status payload

8672bba

Use Certinia PSA report status values

05b5b21

Align Certinia report status translations

8fc3917

Use export status field for Certinia PSA

2b1c486

ShridharGoel marked this pull request as ready for review June 15, 2026 22:23

ShridharGoel requested review from a team as code owners June 15, 2026 22:23

melvin-bot Bot requested review from ChavdaSachin and thelullabyy and removed request for a team June 15, 2026 22:23

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team June 15, 2026 22:23

Allow PSA export status values

673f749

github-actions Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/utils.ts Outdated

github-actions Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/libs/actions/connections/FinancialForce.ts Outdated

github-actions Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/export/CertiniaReportExportStatusPage.tsx

chatgpt-codex-connector Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/certinia/export/CertiniaReportExportStatusPage.tsx

Comment thread src/pages/workspace/accounting/certinia/CertiniaCompanySelectorPage.tsx

Address Certinia PSA review comments

5590e27

joekaufmanexpensify previously approved these changes Jun 16, 2026

View reviewed changes

Merge branch 'main' of https://github.com/Expensify/App into cert3

b74d0c8

# Conflicts: # src/libs/API/types.ts # src/libs/actions/connections/FinancialForce.ts # src/pages/workspace/accounting/certinia/export/CertiniaExportPage.tsx # src/pages/workspace/accounting/certinia/utils.ts

ShridharGoel dismissed joekaufmanexpensify’s stale review via b74d0c8 June 16, 2026 21:19

trjExpensify removed the request for review from ChavdaSachin June 17, 2026 21:57

thelullabyy approved these changes Jun 18, 2026

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon June 18, 2026 00:16

yuwenmemon approved these changes Jun 18, 2026

View reviewed changes

yuwenmemon merged commit 0fb15be into Expensify:main Jun 18, 2026
33 of 36 checks passed

OSBotify mentioned this pull request Jun 18, 2026

Deploy Checklist: New Expensify 2026-06-18 #93956

Closed

45 tasks

melvin-bot Bot mentioned this pull request Jun 19, 2026

[Due for payment 2026-06-26] [Certinia] R2 PSA: Export page (PSA branch) and CertiniaReportExportStatusPage #89440

Open

Uh oh!

Conversation

ShridharGoel commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 15, 2026

Uh oh!

codecov Bot commented Jun 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

thelullabyy commented Jun 17, 2026 • edited by yuwenmemon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

thelullabyy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Jun 15, 2026 •

edited

Loading

codecov Bot commented Jun 15, 2026 •

edited by github-actions Bot

Loading

thelullabyy commented Jun 17, 2026 •

edited by yuwenmemon

Loading