Skip to content

Stop repeated ReconnectApp calls when the device clock is behind the server#93426

Merged
blimpich merged 13 commits into
Expensify:mainfrom
callstack-internal:audit-reconnect-patterns
Jun 18, 2026
Merged

Stop repeated ReconnectApp calls when the device clock is behind the server#93426
blimpich merged 13 commits into
Expensify:mainfrom
callstack-internal:audit-reconnect-patterns

Conversation

@adhorodyski

@adhorodyski adhorodyski commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@mountiny

Explanation of Change

A "full reconnect" is when the app refetches all of its data from the server. The server can ask for one by setting a cutoff time in the Onyx NVP value NVP_RECONNECT_APP_IF_FULL_RECONNECT_BEFORE. The app keeps its own last reconnect time in LAST_FULL_RECONNECT_TIME. subscribeToFullReconnect compares the two: if the last reconnect is older than the cutoff, it triggers a reconnect.

The bug

After a reconnect the app records the time so the check stops firing. It recorded the current time. Every OpenApp and full ReconnectApp response also re-delivers the cutoff (in response.onyxData), and that is applied before the successData that records the time.

So on a device whose clock is behind the server, the recorded time lands before the cutoff. The app still reads as stale, fires another full reconnect, and repeats. Each reconnect waits for its response, so the loop runs at one round trip per cycle. In production this was about 816,000 ReconnectApp calls over 14 days, with traces of 31 calls in 9 seconds.

The fix

Record a time that is never earlier than the cutoff it answers: the later of the current time and the cutoff. That holds whatever the device clock reads. We record it in two places:

  1. Up front in the new triggerFullReconnect(), before the request is sent, so the cutoff re-delivered by the response cannot start another reconnect.
  2. In the response's successData, as before.

subscribeToFullReconnect now goes through triggerFullReconnect() instead of calling reconnectApp() directly. The comparison and the recorded-time logic live in FullReconnectUtils.ts as shouldTriggerFullReconnect and getLastFullReconnectTimeToRecord.

Fixed Issues

#92541
PROPOSAL:

Tests

  1. Open the app in a browser with DevTools → Network open, filtered by ReconnectApp.
  2. Toggle the network offline (DevTools → Network → Offline) and back online to trigger a reconnect.
  3. Verify exactly one ReconnectApp request fires per offline → online transition, with no repeated ReconnectApp requests looping afterwards.
  4. Set the OS clock a few minutes behind the real time (the storm regime) and repeat steps 2–3: still exactly one ReconnectApp per reconnect, and the app keeps responding to clicks.
  5. Run the regression suites: npx jest tests/unit/FullReconnectUtilsTest.ts tests/unit/SubscribeToFullReconnectTest.ts tests/actions/AppTest.ts — the integration suite simulates a full response cycle on a client clock behind the server (onyxData applied before successData) and asserts exactly one ReconnectApp fires; it fails on pre-fix code.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline, perform a few actions (open reports, navigate around).
  2. Come back online.
  3. Verify the app reconnects with a single ReconnectApp request and queued actions process normally — no repeated full-payload reconnect downloads.

QA Steps

Same as Tests (steps 1–4). This change only affects when the ReconnectApp API command fires; there are no UI changes.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

adhorodyski and others added 2 commits June 12, 2026 14:31
… AppTest

The subscription now reaches reconnectApp through the internal
triggerFullReconnect call, so the AppTest spy on the reconnectApp export
no longer observes the full-reconnect trigger. Spying on
triggerFullReconnect (called via the live export binding) restores a
real assertion in both subscription tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Read the LAST_FULL_RECONNECT_TIME value back from Onyx in assertions
instead of a mirrored local, and fold the re-arm drain into
applyServerResponse so the headline test reads top-to-bottom.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@adhorodyski

Copy link
Copy Markdown
Contributor Author

@codex review

Drop the duplicated connectWithoutView boilerplate above
reconnectAppIfFullReconnectBefore and tighten the FullReconnectUtils,
triggerFullReconnect, and test docstrings — keep the clock-skew
rationale, shed the restatement.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eea1cb77ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/App.ts Outdated
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/libs/FullReconnectUtils.ts 100.00% <100.00%> (ø)
src/libs/actions/App.ts 52.65% <100.00%> (+1.20%) ⬆️
src/libs/subscribeToFullReconnect.ts 100.00% <100.00%> (ø)
... and 8 files with indirect coverage changes

@adhorodyski

Copy link
Copy Markdown
Contributor Author

TLDR to the current AI reviews, this is 1/2 of fixing failure mode 1, I will open a followup.

@adhorodyski

Copy link
Copy Markdown
Contributor Author

@codex review

@adhorodyski adhorodyski marked this pull request as ready for review June 16, 2026 13:48
@adhorodyski adhorodyski requested review from a team as code owners June 16, 2026 13:48
@melvin-bot melvin-bot Bot requested review from heyjennahay and mkhutornyi and removed request for a team June 16, 2026 13:48
@melvin-bot

melvin-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team June 16, 2026 13:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a72edfd54

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/App.ts Outdated
@MelvinBot

Copy link
Copy Markdown
Contributor

Review

The fix is sound: writing the receipt as max(client-now, NVP) at both the optimistic pre-seed and the successData site closes the self-re-arm loop in every clock regime, and the new unit + integration tests (FullReconnectUtilsTest, SubscribeToFullReconnectTest, the skew-regime case in AppTest) cover the bug directly — the integration test asserts exactly one ReconnectApp across a full response cycle and fails on pre-fix code. No blocking concerns. All checks are green.

What I verified
  • Logic parity / no-op-by-construction. shouldTriggerFullReconnect is the exact negation of the old lastFullReconnectTime >= reconnectAppIfFullReconnectBefore guard. Since getFullReconnectSeedTime returns max(now, NVP) >= NVP, the re-entrant LAST_FULL_RECONNECT_TIME callback after the optimistic seed in triggerFullReconnect evaluates to false — no infinite loop. Empty-string edge cases (now >= ''now; x < '' → always false) are correct and covered by the table tests.
  • Ordering. The optimistic Onyx.merge precedes the synchronous reconnectApp() call, and the actual RECONNECT_APP write only fires inside the getPolicyParamsForOpenOrReconnect().then(...) continuation, so the seed lands first — matching the seedIndex < firstRequestIndex assertion in the integration test.
  • Failure-path tradeoff (acceptable). The optimistic seed is a standalone Onyx.merge, not optimisticData/failureData on the request, so a failed ReconnectApp still leaves the demand marked answered. This matches the old behavior (nothing re-triggered on failure either, since no Onyx key changed) and the next NVP bump re-arms cleanly — no regression.

Minor / non-blocking:

  1. Partial mock omits triggerFullReconnect. src/libs/actions/__mocks__/App.ts re-exports reconnectApp but not the new triggerFullReconnect. subscribeToFullReconnect now calls triggerFullReconnect, so any test that auto-mocks @libs/actions/App and drives the NVP subscription would hit undefined. No current test exercises that path (CI is green), and this mock is partial by design, so it's only a latent landmine — worth adding the export proactively given subscribeToFullReconnect is the mock's consumer.

  2. OpenApp baseline seed residual — already flagged by Codex and acknowledged by adhorodyski as a bounded, self-correcting (≤1 extra call, not a loop) known residual folded into the SequentialQueue follow-up. Agreed it's out of scope for this stop-the-bleeding PR.

Nice work — the clock-skew framing and the seed-before-request invariant are clearly reasoned and well-tested.

@mkhutornyi mkhutornyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bot review

Otherwise looks good.

@melvin-bot

melvin-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #92541 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot melvin-bot Bot requested a review from blimpich June 16, 2026 17:40
Comment thread src/libs/FullReconnectUtils.ts Outdated
Comment thread src/libs/FullReconnectUtils.ts Outdated
Comment thread src/libs/actions/App.ts
Comment thread src/libs/FullReconnectUtils.ts Outdated
Comment thread src/libs/FullReconnectUtils.ts Outdated
Comment thread src/libs/FullReconnectUtils.ts Outdated
Comment thread src/libs/subscribeToFullReconnect.ts Outdated
@blimpich

Copy link
Copy Markdown
Contributor

@adhorodyski is this 1 of a few PRs to address the linked issue? It seems like you've described 4 sub-problems this issue is about, and I think this PR solves the first one correct?

If so, can we change the PR body description from

Fixed Issues
$ https://github.com/Expensify/App/issues/92541

to

Related Issues
https://github.com/Expensify/App/issues/92541

That way the issue doesn't auto-close once this is deployed?

@adhorodyski

Copy link
Copy Markdown
Contributor Author

This targets 50% of the first issue, sure let's update this

adhorodyski and others added 2 commits June 17, 2026 15:14
Name the two real values plainly and explain the concept once where it
lives, so the code reads clearly without the old metaphors.

- "receipt"/"seed" prose removed; getFullReconnectSeedTime renamed to
  getLastFullReconnectTimeToRecord (it writes that value before the
  reconnect finishes, so "completion" would be inaccurate).
- reconnectAppIfFullReconnectBefore renamed to serverReconnectCutoff.
- Concept now explained once in FullReconnectUtils; other files point to
  it instead of repeating. Comments kept only where they carry a why:
  the clock-skew clamp, the write-before-fire ordering, and the
  connectWithoutView safety note tgolen asked for.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The old comment ("A timestamp of when the last full reconnect should have
been done") read as if this were the client's own last reconnect time,
which is a separate key (LAST_FULL_RECONNECT_TIME). Describe it as what it
is: a cutoff the server sets, which the client only reads.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@adhorodyski adhorodyski changed the title Fix ReconnectApp self-re-arming loop via clock-skew-safe receipt seeding Stop repeated ReconnectApp calls when the device clock is behind the server Jun 17, 2026
adhorodyski and others added 5 commits June 17, 2026 15:39
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The fix lives in the shared getOnyxDataForOpenOrReconnect, but every existing
test drove only the subscribe -> triggerFullReconnect (ReconnectApp) path. The
OpenApp entry into the same code had no direct coverage.

Add two tests isolating the OpenApp leg on a client clock behind the server:
- white-box: OpenApp successData records max(now, cutoff), not the behind-clock now
- behavioral: an OpenApp response re-delivering a known cutoff starts no reconnect loop

Both fail on pre-fix behavior (recorded now < cutoff) and pass on the fix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The parameter shadowed the module-level serverReconnectCutoff Onyx
variable. Both are needed, so rename the parameter to cutoff.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@adhorodyski

Copy link
Copy Markdown
Contributor Author

I read it all again and this is everything for the failure mode 1, so I updated the description as well to read 'fixed issues' 👍🏼

@tgolen tgolen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improved comments are great. Thank you!

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeed, thanks! The comments are very useful now

@mountiny

mountiny commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Expensify Expensify deleted a comment from mkhutornyi Jun 18, 2026
@mkhutornyi

Copy link
Copy Markdown
Contributor

Looks like PR Reviewer Checklist is failed because of #92926 merged 18 hrs ago.

@mountiny

Copy link
Copy Markdown
Contributor

yes

@blimpich blimpich merged commit bad195a into Expensify:main Jun 18, 2026
34 of 36 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.15-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no docs changes required.

This PR is an internal sync/networking fix — it changes when the ReconnectApp command fires to stop a reconnect loop on devices whose clock is behind the server. As the PR notes, it only affects API call timing and has no UI changes, no new settings, no new features, and no user-facing copy.

The help site under App/docs/articles documents product behavior, settings, and user workflows. None of those surfaces are affected by this change (the subscribeToFullReconnect / triggerFullReconnect reconnect machinery is not documented for end users, by design). So there's nothing to add or update, and I have not created a draft docs PR.

@adhorodyski, if you believe a user-facing behavior here should be documented, reply with the specifics and I'll draft a help site PR. Otherwise no action is needed.

@IuliiaHerets

Copy link
Copy Markdown

Hi @adhorodyski. Is it an internal PR?
I am not sure if QA team can follow the steps above.

cc @tgolen @blimpich @mountiny @heyjennahay

@mountiny

Copy link
Copy Markdown
Contributor

@IuliiaHerets I think the QA steps can be followed by QA, what is not clear about them?

@IuliiaHerets

Copy link
Copy Markdown

@mountiny Step 5 is not clear
image

@mountiny

Copy link
Copy Markdown
Contributor

@IuliiaHerets Those are tests before the PR was merged, but QA steps section is relevant for you and different

@IuliiaHerets

Copy link
Copy Markdown

@mountiny, you're right, thanks for pointing that out

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants