🍒 Cherry pick PR #93261 to staging 🍒 - #93311
Conversation
(cherry picked from commit 9a900d8) (cherry-picked to staging by Julesssss)
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.5-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a cherry-pick of #93261, which reverts #92161 ("migrate money request part 2") to resolve several staging deploy blockers. The changes are entirely internal/structural with no user-facing impact:
I reviewed the full diff and found no changes to feature names, tab names, settings labels, button copy, or user-facing workflows. Since @mjasikowski, no help site PR was created since no documentation changes are required. Please confirm you agree with this assessment. If you believe docs updates are needed, reply with the specifics and I'll create the draft PR. |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.5-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀
|
🍒 Cherry pick #93261 to staging 🍒
This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:
Then manually resolve conflicts, and commit the change with
git cherry-pick --continue. Lastly, please run:This last part is important. It will help us keep track of who triggered this CP, and will ensure that version bumps are tracked correctly. Once all that's done, push your changes with
git push origin cherry-pick-staging-93261-27363230863-1, and then open this PR for review.Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.
Important
This PR should ideally be merged by a member of the mobile-deployers team. If it is merged by someone who is not a deployer, the staging deploy triggered by the merge will fail and will need to be manually re-triggered (not just retried) via the deploy workflow.
Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari