-
Notifications
You must be signed in to change notification settings - Fork 3.9k
added first approver and first approved columns #93169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4a0e174
0fc96ed
647ad02
eea14df
66750bf
4d6bec6
b668b44
e9c62bd
c2551b1
8e7f58f
83de396
aafd782
6235691
f6c6629
f605ea3
b1789f1
973f9f7
5c494a6
654eeba
606bbdd
6dbebe9
b1fedf2
2bbb390
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1907,16 +1907,20 @@ const createStyleUtils = (theme: ThemeColors, styles: ThemeStyles) => ({ | |
| columnWidth = {...getWidthStyle(variables.w130), ...styles.alignItemsCenter}; | ||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.SUBMITTED: | ||
| columnWidth = {...getWidthStyle(isSubmittedColumnWide ? variables.w92 : variables.w72)}; | ||
| columnWidth = {...getWidthStyle(isSubmittedColumnWide ? variables.w102 : variables.w62)}; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mukhrr Why do you change this styles?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We decided to fix all truncated dates here #93169 (comment) |
||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.APPROVED: | ||
| columnWidth = {...getWidthStyle(isApprovedColumnWide ? variables.w92 : variables.w72)}; | ||
| columnWidth = {...getWidthStyle(isApprovedColumnWide ? variables.w102 : variables.w62)}; | ||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.FIRST_APPROVED: | ||
| // Fixed width: wide enough for both the long "First approved" header and a past-year date, so no year-based widening is needed. | ||
| columnWidth = {...getWidthStyle(variables.w102)}; | ||
|
Comment on lines
+1915
to
+1917
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @mukhrr Sorry for the back and forth, but I think we should maintain consistency with the other fields to avoid regression and reapply isFirstApprovedColumnWide to align with the other columns. If you have any ideas to optimize this, feel free to share them then we could handle it in a follow-up
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DylanDylann what regressions do you refer for example? We get truncated "First App.." table column header if we do the same with others
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the reminder. Everything looks fine, so we can move forward |
||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.POSTED: | ||
| columnWidth = {...getWidthStyle(isPostedColumnWide ? variables.w92 : variables.w72)}; | ||
| columnWidth = {...getWidthStyle(isPostedColumnWide ? variables.w102 : variables.w62)}; | ||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.EXPORTED: | ||
| columnWidth = {...getWidthStyle(isExportedColumnWide ? variables.w92 : variables.w72)}; | ||
| columnWidth = {...getWidthStyle(isExportedColumnWide ? variables.w102 : variables.w62)}; | ||
| break; | ||
| case CONST.SEARCH.TABLE_COLUMNS.DATE: | ||
| columnWidth = {...getWidthStyle(isDateColumnWide ? variables.w102 : variables.w62)}; | ||
|
|
@@ -1996,6 +2000,7 @@ const createStyleUtils = (theme: ThemeColors, styles: ThemeStyles) => ({ | |
| case CONST.SEARCH.TABLE_COLUMNS.MERCHANT: | ||
| case CONST.SEARCH.TABLE_COLUMNS.FROM: | ||
| case CONST.SEARCH.TABLE_COLUMNS.TO: | ||
| case CONST.SEARCH.TABLE_COLUMNS.FIRST_APPROVER: | ||
| case CONST.SEARCH.TABLE_COLUMNS.ASSIGNEE: | ||
| case CONST.SEARCH.TABLE_COLUMNS.TITLE: | ||
| case CONST.SEARCH.TABLE_COLUMNS.DESCRIPTION: | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.