Use custom compass on the maps#93026
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
There was a problem hiding this comment.
cc @Expensify/design to make sure you are cool with this updated image I made!
There was a problem hiding this comment.
Also everything is ready on this PR, so I will just wait for your approval on the design to switch it for review
There was a problem hiding this comment.
Ohh that icon looks lovely!
|
Cool, free free to mark it ready for review in the meantime to review the code changes. |
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
on it now |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-06-09.at.23.01.04.movAndroid: mWeb ChromeiOS: mWeb SafariMacOS: Chrome / Safari |
|
This is feeling great to me! |
|
@GCyganek can you please check the failing test? |
merged main and now there is no failing test |
|
@neil-marcellini could you review? |
|
I am curious to know more about what problem we are solving by doing this, and why we do not show a compass on web, but I'll assume there's a good reason and move ahead with the review. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good, thank you.
|
C+ already approved, trying to pass this check. Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.17-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required I reviewed the changes in this PR against the help site articles under Summary of the change: This PR replaces Mapbox's default compass with a custom compass on the map (mobile only — no compass on web), makes tapping it reset the map heading to north, and adds a Why no docs update is needed:
No draft help site PR was created since no article content is affected. @GCyganek, please confirm this assessment reflects the current behavior. If you believe a help site article should be updated (e.g., to mention the compass interaction), reply with |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀
|

Explanation of Change
Per @shawnborton request:
shouldDisplayCompassprop to control if we want to display compass on a map to hide it on the expense preview after it's submitted.Fixed Issues
$ #85802
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-06-09.at.11.33.50.mov
iOS: Native
Screen.Recording.2026-06-09.at.11.54.18.mov