Revert #89360 (bulk merge navigation) to unblock deploy#92934
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
Fixed the failing check. Root cause: The Fix: Restored the standard PR template structure (added the The checklist now parses correctly and reports the normal "0 of 49 items completed" state. |
|
All checks are now passing ✅ — including The earlier |
|
All checks are now passing ✅ — no failing checks remain. The earlier |
Explanation of Change
This reverts PR #89360 ("Fix bulk expense merge opening self DM instead of transaction thread"), which is a
DeployBlockerCashon the current staging deploy.That PR changed the post-merge navigation target to the target transaction's thread report instead of the destination chat report. Offline, that thread report has no
CREATEDreport action loaded, so the offline-only skeleton condition inReportActionsList.tsx(isOffline && !some(action === CREATED)) staystrueforever, leaving the RHP stuck on an infinite loading skeleton after merging a Self DM expense with a workspace expense while offline.Reverting restores the pre-PR navigation behavior (navigating to the destination chat report, which already has its
CREATEDaction in Onyx), unblocking the deploy. The original fix can be re-landed with the offline edge case handled.This is a clean revert of merge commit
e07b8f42a1c4d2db5960827786baea87ba4d4390(git revert -m 1); 15 files changed, matching the original PR's footprint.Fixed Issues
$ #92846
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari