Fix: Highlight split expenses after splitting an existing expense by aswin-s · Pull Request #92506 · Expensify/App

aswin-s · 2026-06-03T13:17:13Z

Explanation of Change

When splitting an existing expense, the newly created split transactions were not temporarily highlighted in the expense report list.

There were two gaps:

Write side — updateSplitTransactionsFromSplitExpensesFlow called Navigation.dismissModalWithReport without first registering the new split transaction IDs via addPendingNewTransactionIDs. The normal create path does this via navigateAfterExpenseCreate, but the split-update path skipped it entirely.
Read side — MoneyRequestReportActionsList called useNewTransactions with only 2 arguments, so the pendingNewTransactionIDs metadata fallback (which highlights transactions already present on mount) was never exercised.

Fix:

In SplitTransactionUpdate.ts, before the navigation call, loop over the split expenses and call addPendingNewTransactionIDs for each transaction ID. Skipped for reverse-split and last-transaction-in-report cases. This now also covers splitting from the Search page, where navigateBackToLastSuperWideRHPScreen is used instead of dismissModalWithReport.
In MoneyRequestReportActionsList.tsx, subscribe to REPORT_METADATA via pendingNewTransactionIDsSelector and pass all 5 arguments to useNewTransactions, mirroring what MoneyRequestReportPreview already does.

Fixed Issues

$ #91679
PROPOSAL: #91679 (comment)

Tests

Open an expense report with at least one expense.
Click More > Split > Save on an expense.
Verify the split expenses are temporarily highlighted (brief yellow/blue flash) in the expense report list after the split completes.
Verify the original expense is no longer visible in the list.
Verify no JS console errors appear.

Verify that no errors appear in the JS console

Offline tests

N/A — split expense saving requires network. The highlight logic is optimistic (fires before the API response), so offline state does not affect it.

QA Steps

Go to staging.new.expensify.com.
Open an expense report with at least one expense.
Click More > Split > Save on an expense.
Verify the new split expense rows are temporarily highlighted after splitting.
Verify no JS console errors appear.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

Web.mp4

Register each new split transaction ID via addPendingNewTransactionIDs before navigating away, so MoneyRequestReportActionsList can identify and highlight them on first load via the pendingNewTransactionIDs path. Covers all three navigation branches: - dismissModalWithReport (normal workspace split) - isSelfDMSplit (selfDM → workspace split) - isSearchPageTopmostFullScreenRoute (split from search page) Skipped for isReverseSplitOperation (no new transactions) and isLastTransactionInReport (report is being emptied, fallback nav). On the read side, subscribe MoneyRequestReportActionsList to REPORT_METADATA via pendingNewTransactionIDsSelector and pass all 5 arguments to useNewTransactions, enabling the metadata fallback path that highlights transactions already present on mount.

codecov · 2026-06-03T14:06:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/SplitTransactionUpdate.ts	`85.25% <100.00%> (+7.07%)`	⬆️
... and 178 files with indirect coverage changes

melvin-bot · 2026-06-07T19:06:47Z

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a02590595b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gijoe0295 · 2026-06-16T09:13:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-16.at.16.29.25.mov

Android: mWeb Chrome

Screen.Recording.2026-06-16.at.16.31.14.mov

iOS: HybridApp

Screen.Recording.2026-06-16.at.16.22.28.mov

iOS: mWeb Safari

Screen.Recording.2026-06-16.at.16.23.14.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.16.13.37.mov

gijoe0295 · 2026-06-16T09:15:27Z

Navigate to a workspace chat / expense report.

Create an expense.

Open the expense, click More > Split > Save.

Can you consolidate these steps?

Open an expense report with single expense

Click More > Split > Save

Also please resolve conflicts @aswin-s

gijoe0295 · 2026-06-16T09:22:14Z


    const targetReportID = params.expenseReport?.reportID ?? String(CONST.DEFAULT_NUMBER_ID);

+    if (params.expenseReport?.reportID && !isReverseSplitOperation && !isLastTransactionInReport && !isSearchPageTopmostFullScreenRoute) {


Why do we need isSearchPageTopmostFullScreenRoute here? With it, expenses are not highlighted when splitting in Search page.

gijoe0295 · 2026-06-17T03:25:20Z

@codex review

chatgpt-codex-connector · 2026-06-17T03:32:43Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 0349ac2e11

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gijoe0295

LGTM

… split update flow

github-actions · 2026-06-18T08:44:57Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-18T08:50:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92506.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-86d13c5dca5-57a8e82-21a714aa9be6941a9a8919a860d2a71fc5cacdff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-86d13c5-57a8e82-7c2e95c29b6978b3ea4fd4fbff344f6e1bf62777/index.html

Web 🕸️
https://92506.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-18T08:51:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-06-18T17:17:31Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.15-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-06-18T17:21:01Z

🤖 Help site review: no docs changes required.

This PR is a transient UI behavior fix — it registers the new split transaction IDs (addPendingNewTransactionIDs) and wires MoneyRequestReportActionsList to useNewTransactions so the newly created split rows briefly highlight in the expense report list after splitting. It only touches src/libs/actions/IOU/SplitTransactionUpdate.ts and a test file; there are no changes to feature names, tab names, settings, button labels, or any documented workflow.

The relevant help article, Split Expenses, documents how to split, edit, and revert expenses (the More > Split > Save flow). The brief highlight flash is a visual polish detail that the article does not describe and does not need to — the documented steps and outcomes are unchanged.

No draft PR was created since no help site updates are needed.

@aswin-s, if you believe a help site update is warranted (for example, to document this highlight behavior), let me know and I'll create the draft PR.

nlemma · 2026-06-18T18:45:45Z

Deploy Blocker #93967 was identified to be related to this PR.

OSBotify · 2026-06-19T15:23:23Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned aswin-s Jun 3, 2026

aswin-s force-pushed the fix/issue-91679 branch from ef2c2ad to 67a6d95 Compare June 3, 2026 13:54

aswin-s force-pushed the fix/issue-91679 branch from 817496c to 67a6d95 Compare June 3, 2026 14:08

aswin-s added 2 commits June 7, 2026 23:57

Merge remote-tracking branch 'origin/main' into fix/issue-91679

88ba299

Remove unrelated formatting changes

a025905

aswin-s marked this pull request as ready for review June 7, 2026 19:06

aswin-s requested review from a team as code owners June 7, 2026 19:06

melvin-bot Bot requested review from gijoe0295 and heyjennahay and removed request for a team June 7, 2026 19:06

chatgpt-codex-connector Bot reviewed Jun 7, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/SplitTransactionUpdate.ts Outdated

aswin-s added 2 commits June 8, 2026 01:44

Only register newly-created split transaction IDs as pending-new

2e3a508

Merge remote-tracking branch 'origin/main' into fix/issue-91679

c5e7361

gijoe0295 suggested changes Jun 16, 2026

View reviewed changes

aswin-s added 2 commits June 16, 2026 16:04

Resolve merge conflict in MoneyRequestReportActionsList

02c98a4

Fix: enable split expense highlight from Search page

0349ac2

gijoe0295 approved these changes Jun 17, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny June 17, 2026 04:27

mountiny requested changes Jun 17, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/SplitTransactionUpdate.ts

aswin-s added 2 commits June 17, 2026 20:22

Add comment and unit tests for pending transaction ID registration in…

193f711

… split update flow

Merge remote-tracking branch 'origin/main' into fix/issue-91679

544c7cc

Fix unsafe type assertions and null types in split update unit tests

f656cd6

aswin-s requested a review from mountiny June 17, 2026 15:09

mountiny approved these changes Jun 17, 2026

View reviewed changes

mountiny merged commit 86d13c5 into Expensify:main Jun 18, 2026
33 checks passed

OSBotify mentioned this pull request Jun 18, 2026

Deploy Checklist: New Expensify 2026-06-18 #93956

Closed

45 tasks

applause-bot Bot mentioned this pull request Jun 18, 2026

Expense - Splits are highlighted after splitting on Spend and opening report on Inbox #93967

Open

7 tasks

nlemma mentioned this pull request Jun 18, 2026

[Due for payment 2026-06-26] [$250] Expense - Expenses are not temporarily highlighted after splitting #91679

Open

7 tasks

aswin-s mentioned this pull request Jun 22, 2026

Fix: Splits incorrectly highlighted in Inbox after splitting from Spend page #94139

Draft

43 tasks


		const targetReportID = params.expenseReport?.reportID ?? String(CONST.DEFAULT_NUMBER_ID);

		if (params.expenseReport?.reportID && !isReverseSplitOperation && !isLastTransactionInReport && !isSearchPageTopmostFullScreenRoute) {

Conversation

aswin-s commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gijoe0295 commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

gijoe0295 commented Jun 16, 2026

Uh oh!

gijoe0295 Jun 16, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Jun 17, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jun 17, 2026

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 18, 2026

Uh oh!

MelvinBot commented Jun 18, 2026

Uh oh!

nlemma commented Jun 18, 2026

Uh oh!

OSBotify commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aswin-s commented Jun 3, 2026 •

edited

Loading

codecov Bot commented Jun 3, 2026 •

edited by github-actions Bot

Loading

gijoe0295 commented Jun 16, 2026 •

edited

Loading