Migrate InteractionManager - batch 9, part 1#92378
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Pujan92 @ikevin127 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e1a0981b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-19.at.16.42.09.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-06-19.at.16.15.20.movScreen.Recording.2026-06-19.at.16.17.42.movScreen.Recording.2026-06-19.at.16.20.42.mov |
Explanation of Change
Migrate remaining
InteractionManager.runAfterInteractionsusages toTransitionTracker.runAfterTransitionsor remove them where unnecessary. SimplifiesOptionRow'sonSelectRowcallback, removes the focus-blur hack inNewTaskPage(replaced byshouldSkipFocusAfterTransitionprop on Header, same approach as #92057 which applied the identical fix to the submit expense confirmation page).Fixed Issues
$ #71913
$ #83070
Tests
Per diem submit expense
New task page focus
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Test 1
Screen.Recording.2026-06-16.at.11.33.33.mov
Test 2
Screen.Recording.2026-06-16.at.11.35.12.mov