Skip to content

[No QA] Docs updates for E/A#88577 document exporting grouped expenses#92318

Merged
strepanier03 merged 3 commits into
mainfrom
docs-group-exports-88577
Jun 9, 2026
Merged

[No QA] Docs updates for E/A#88577 document exporting grouped expenses#92318
strepanier03 merged 3 commits into
mainfrom
docs-group-exports-88577

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR documents the new group exports behavior introduced in #88577.

When expenses on the Spend page are grouped using Display > Group by, you can now select the groups and choose Basic export to produce an export that preserves the group structure — each group becomes its own section with a header row, and its expenses are listed below their group header. This behavior was not previously documented in the export article.

Changes to docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md:

  • Added an Export grouped expenses section with the step-by-step flow (verified against the live UI: the Display > Group by control, the N selected button, and Basic export).
  • Added an FAQ entry: "Can I keep my groups when I export?"
  • Updated the article keywords for retrieval.

I followed docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md, and used exact UI labels verified in the live app.

Fixed Issues

$

Related: #88577

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validate your changes worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.


@getusha, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Add a section and FAQ to the export article explaining that grouped
search results can be exported with Basic export while preserving the
group structure, reflecting the new group exports behavior.

Co-authored-by: Getabalew T <getusha@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 2, 2026 06:48
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 2, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#88577 document exporting grouped expenses [No QA] Docs updates for E/A#88577 document exporting grouped expenses Jun 2, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott marked this pull request as ready for review June 9, 2026 03:51
@stephanieelliott stephanieelliott self-requested a review as a code owner June 9, 2026 03:51
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @strepanier03

@melvin-bot melvin-bot Bot requested review from strepanier03 and removed request for a team June 9, 2026 03:51
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@strepanier03 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new "Export grouped expenses" section and a corresponding FAQ entry to the Search-and-Download-Expenses article, along with expanded keywords. The new content is well-structured, actionable, and follows most governance conventions. A few items need attention.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. The follow-up note about individual expense selection is a helpful clarification. The bulleted list explaining the exported file format is easy to scan.
  • AI Readiness: 7/10 - New keywords are relevant and improve search coverage. The heading "Export grouped expenses" is task-based and starts with a verb. However, the new section uses a # heading, which continues a pre-existing pattern in this article that conflicts with the governance rule requiring exactly one # heading (the title) plus optional # FAQ. The internalScope field is also absent from the YAML, though this is a pre-existing gap, not introduced by this PR.
  • Style Compliance: 8/10 - Navigation instructions in step 1 correctly follow the unified format. Button and UI element names are bolded consistently. One concern: step 5 refers to "the selection button at the top" which generalizes the UI element rather than using exact UI text, per HELPSITE_NAMING_CONVENTIONS.md ("Do not generalize UI elements"). The parenthetical example helps, but the primary reference should be more precise.

Key Findings

  • The new # Export grouped expenses heading follows the same #-level pattern already used throughout this article (# Export Options, # Export as CSV, # Export as PDF). Governance requires only one # heading per article (the title). This is a pre-existing structural issue, but adding another # heading extends it further. Consider using ## for this section if a broader restructure is not in scope.
  • Step 5 ("Click the selection button at the top") uses a generalized reference. Per naming conventions, UI elements should be referenced by their exact label. Consider rephrasing to something like: "Click 1 selected (or the equivalent count shown at the top)."
  • The screenshot placeholder follows the correct HTML comment format from Section 8 of the authoring guidelines.
  • The new FAQ entry ("Can I keep my groups when I export?") uses a question format and provides a concise, direct answer -- both in compliance with governance.
  • The added keywords (export grouped expenses, group by, grouped export, Basic export) are well-chosen and improve discoverability.

Recommendations

  1. Consider using ## instead of # for "Export grouped expenses" to move toward compliance with the single-#-heading rule. This article would benefit from a broader heading restructure, but that may be out of scope for this PR.
  2. Tighten step 5 to reference the exact UI text rather than generalizing with "the selection button."
  3. Verify "Basic export" capitalization matches the UI exactly. The keywords list includes "Basic export" (lowercase "e"), while the existing article references "Basic Export" with a capital "E" on line 27. Only one casing can be correct -- confirm which matches the product UI and use it consistently.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md - New section, FAQ entry, and keyword additions reviewed. Generally strong; minor heading level and UI reference precision issues noted.

Review based on governance files: docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md.

@OSBotify

This comment has been minimized.

@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://1b040ff9.helpdot.pages.dev ⚡️

Updated articles:

@strepanier03 strepanier03 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes as well as the build, everything looks good.

@strepanier03 strepanier03 merged commit 0ef3b9d into main Jun 9, 2026
15 checks passed
@strepanier03 strepanier03 deleted the docs-group-exports-88577 branch June 9, 2026 22:12
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/strepanier03 in version: 9.4.4-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants