Skip to content

[No QA] Docs updates for E/A#91000 Update help site for unified personal details form#91597

Merged
stephanieelliott merged 4 commits into
mainfrom
melvin-docs-update-private-personal-details-91000
Jun 16, 2026
Merged

[No QA] Docs updates for E/A#91000 Update help site for unified personal details form#91597
stephanieelliott merged 4 commits into
mainfrom
melvin-docs-update-private-personal-details-91000

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

  • Updates Account-Settings.md to document the unified Private Personal Details form, magic code verification step, address autocomplete, and phone number field
  • Updates Update-Your-Expensify-Card-Mailing-Address.md to reflect the unified form and magic code verification when updating legal name or phone number

Related PR: #91000

…and magic code verification

Co-authored-by: Jasper Huang <jasperhuangg@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 25, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#91000 Update help site for unified personal details form [No QA] Docs updates for E/A#91000 Update help site for unified personal details form May 25, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott marked this pull request as ready for review May 27, 2026 05:20
@stephanieelliott stephanieelliott self-requested a review as a code owner May 27, 2026 05:20
Comment thread docs/articles/new-expensify/settings/Account-Settings.md Outdated
Comment thread docs/articles/new-expensify/settings/Account-Settings.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes targeted improvements to two documentation files, adding magic code verification steps and updating personal information workflows to reflect current UI behavior (Private Personal Details form, phone number field, address autocomplete). The changes improve accuracy and completeness. A few governance compliance items should be addressed.

Scores Summary

  • Readability: 8/10 - Steps are clear, sequential, and action-oriented. The split of display name vs. legal name into separate sub-procedures in Account-Settings.md improves scannability. Minor concern: the phrase "unified Private Personal Details form" in step 4 of the personal information section may confuse users who do not know what "unified" means in this context.
  • AI Readiness: 7/10 - The new heading "How to update personal information" and "How to update your display name or legal name" are task-based and start with "How to," which is good. However, Account-Settings.md still lacks an internalScope field in its YAML frontmatter, which is required per HELP_AUTHORING_GUIDELINES.md Section 3. The added keywords ("phone number", "magic code") improve search relevance.
  • Style Compliance: 8/10 - UI element references are bolded correctly. Navigation phrasing follows conventions. Two items to flag: (1) "Private Personal Details form" appears as a UI label reference but is not bolded -- if this is the actual form name shown in the UI, it should be bolded per naming conventions; if it is not an exact UI label, consider rephrasing to avoid confusion with an actual UI element name. (2) In Account-Settings.md, the changed line says "date of birth" in lowercase in the description bullet, but step 3 references it as bold Date of Birth -- ensure the casing matches the actual UI label throughout.

Key Findings

  • The addition of magic code verification steps across both files is a valuable accuracy improvement that reflects actual user experience.
  • Splitting the "Display or Legal Name" section into two distinct procedures ("How to update your display name or legal name") with separate step sequences improves clarity.
  • The address autocomplete explanation is a helpful contextual addition.
  • Missing internalScope in Account-Settings.md frontmatter is a governance gap that predates this PR but could be addressed here since the metadata is already being modified.
  • The term "Private Personal Details form" is used in both files but never bolded. If this is an exact UI element name, it should be bolded per HELPSITE_NAMING_CONVENTIONS.md. If it is descriptive text rather than a UI label, consider rewording to avoid ambiguity (e.g., "update the fields" without referencing a form name).

Recommendations

  1. Add internalScope to Account-Settings.md YAML frontmatter since the metadata block is already being edited in this PR.
  2. Decide whether "Private Personal Details form" is an exact UI label. If yes, bold it consistently. If no, rephrase to avoid implying it is a UI element name.
  3. Remove the word "unified" from "the unified Private Personal Details form" in Account-Settings.md step 4 -- it adds no user-facing value and reads as internal terminology.
  4. Consider whether "Enter the magic code sent to your email or phone to verify the change" should clarify which contact method receives the code, or if the current phrasing accurately reflects the UI behavior.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.md - Added magic code verification steps and "Private Personal Details form" references to name and phone update procedures. Changes are clear and accurate.
  • docs/articles/new-expensify/settings/Account-Settings.md - Updated personal information section with new fields (phone number), magic code steps, address autocomplete details, and restructured display/legal name guidance. Keywords updated. Missing internalScope in frontmatter.

Note: This review covers only the proposed changes in the PR diff, not pre-existing content.

@stephanieelliott stephanieelliott self-assigned this May 27, 2026
Comment thread docs/articles/new-expensify/settings/Account-Settings.md
Comment thread docs/articles/new-expensify/settings/Account-Settings.md
Comment thread docs/articles/new-expensify/settings/Account-Settings.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR improves two documentation files by adding magic code verification steps, updating field references to match current UI, and converting headings to task-based format. The changes are well-aligned with governance standards and reflect real product behavior updates. A few minor issues remain.

Scores Summary

  • Readability: 8/10 - Steps are clear and sequential. The split of display name vs. legal name into separate sub-procedures improves scannability. Minor clarity issues noted below.
  • AI Readiness: 8/10 - Headings were converted to task-based format ("How to update personal information", "How to update your display name or legal name"), which improves retrieval. Keywords were expanded with relevant search terms ("phone number", "magic code").
  • Style Compliance: 7/10 - Most UI references are correctly bolded and cased. However, "Private Personal Details form" appears multiple times without bold formatting, and its accuracy as exact UI text should be verified. Some inconsistency in how the form is referenced.

Key Findings

Positive aspects:

  • Heading ## Personal Information correctly converted to ## How to update personal information per task-based heading rules.
  • Heading ## Display or Legal Name correctly converted to ## How to update your display name or legal name.
  • New magic code verification steps accurately document the current user flow.
  • Keywords expanded with realistic search terms ("phone number", "magic code").
  • Address suggestion and country pre-fill behavior are useful additions.
  • Navigation instructions correctly use the standard phrasing: "in the navigation tabs (on the left on web, on the bottom on mobile)".

Issues to address:

  1. "Private Personal Details form" appears three times across both files without bold formatting. Per HELPSITE_NAMING_CONVENTIONS.md, UI element names must be bolded. If this is the exact UI label, it should be Private Personal Details (bolded). If it is not an exact UI label, it should be rephrased to reference what the user actually sees.
  2. Step 4 in Account-Settings.md ("Update the fields on the unified Private Personal Details form") uses the word "unified" which does not appear to be a UI label. This reads as internal/editorial language rather than user-facing guidance. Consider simplifying to "Update the fields and click Save" or similar.
  3. "magic code" terminology - This term is used across multiple steps. Verify this matches the exact UI terminology users see. If the UI says something different (e.g., "verification code"), the text should match the UI per naming conventions.
  4. Minor inconsistency in Account-Settings.md - Step 3 says 'Click Legal Name, Date of Birth, Phone Number, or Address' but step 4 references updating fields "on the unified Private Personal Details form." This flow could confuse users since clicking any single option apparently opens a unified form — consider making this relationship clearer.

Recommendations

  1. Bold "Private Personal Details" wherever it refers to a UI element label, across both files.
  2. Remove "unified" from step 4 of the personal information section — it adds no user-facing value and reads as internal language.
  3. Verify "magic code" matches the exact in-product terminology; update if the UI uses a different phrase.
  4. Consider clarifying that clicking any Private Details field opens a shared form, if that is the intended UX, so users are not surprised.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Update-Your-Expensify-Card-Mailing-Address.md - Added magic code verification steps and "Private Personal Details form" context. Generally solid; needs bold formatting on UI label references.
  • docs/articles/new-expensify/settings/Account-Settings.md - Heading compliance improved, keywords expanded, steps rewritten with magic code flow. Most impactful changes in the PR; has the most items to address.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott requested a review from a team May 28, 2026 03:13
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lydiabarclay

@melvin-bot melvin-bot Bot requested review from lydiabarclay and removed request for a team May 28, 2026 03:13
@melvin-bot

melvin-bot Bot commented May 28, 2026

Copy link
Copy Markdown

@lydiabarclay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

2. Select **Profile**.
3. Under **Private**, select **Phone number**.
4. Enter your updated phone number and click **Save**.
4. Enter your updated phone number on the and click **Save**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"on the" what?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@OSBotify

OSBotify commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Comment thread docs/articles/new-expensify/settings/Account-Settings.md
2. Select **Profile**.
3. Under **Private**, select **Phone number**.
4. Enter your updated phone number and click **Save**.
4. Enter your updated phone number on the and click **Save**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@stephanieelliott stephanieelliott merged commit 55d5add into main Jun 16, 2026
15 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docs-update-private-personal-details-91000 branch June 16, 2026 23:41
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.10-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.12-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.14-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants