Skip to content

[No QA] [NO QA] Capitalize Travel Invoicing hotel stay help article filename#91478

Merged
bfitzexpensify merged 1 commit into
mainfrom
blimpich-fixTravelInvoicingHotelArticleFilename
May 25, 2026
Merged

[No QA] [NO QA] Capitalize Travel Invoicing hotel stay help article filename#91478
bfitzexpensify merged 1 commit into
mainfrom
blimpich-fixTravelInvoicingHotelArticleFilename

Conversation

@blimpich

@blimpich blimpich commented May 22, 2026

Copy link
Copy Markdown
Contributor

Details

Renames the Travel Invoicing hotel-stay help article to use Title-Case-Hyphenated naming so its page header renders in Title Case (the layout derives <h1> from the filename). Adds a redirects.csv entry so the previously-published lowercase URL keeps working.

Right now it looks like this
Screenshot 2026-05-22 at 4 01 48 PM

which is wrong

Fixed Issues

$

PROPOSAL: N/A

Tests

N/A — docs-only change. Verifying steps left for human reviewer.

  • Verify that no errors appear in the JS console

Offline tests

N/A — docs-only change.

QA Steps

N/A — docs-only change; no QA needed.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — docs-only change.

Android: mWeb Chrome

N/A — docs-only change.

iOS: Native

N/A — docs-only change.

iOS: mWeb Safari

N/A — docs-only change.

MacOS: Chrome / Safari

N/A — docs-only change.

– written by Claude on Ben's behalf

@blimpich blimpich requested review from a team and stephanieelliott as code owners May 22, 2026 22:58
@melvin-bot

melvin-bot Bot commented May 22, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot melvin-bot Bot requested review from jliexpensify and mollfpr and removed request for a team May 22, 2026 22:58
@melvin-bot

melvin-bot Bot commented May 22, 2026

Copy link
Copy Markdown

@mollfpr @jliexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR performs a filename capitalization change — renaming complete-a-hotel-stay-using-travel-invoicing.md to Complete-a-Hotel-Stay-Using-Travel-Invoicing.md (Title Case) — and adds a corresponding redirect in docs/redirects.csv. The article content is unchanged. The rename aligns the filename with the Title Case convention used by other HelpDot articles, and the redirect correctly preserves the old URL.

Because the diff contains no content changes, scoring is based solely on the proposed changes (the rename and redirect). However, pre-existing issues in the article are noted below as advisory observations for a future content PR.

Scores Summary

  • Readability: 9/10 - The rename itself has no impact on readability. The redirect is clean and correctly formatted. No issues introduced.
  • AI Readiness: 9/10 - Filename normalization to Title Case improves consistency with the rest of the help site, which supports discoverability. No metadata or heading changes are part of this diff.
  • Style Compliance: 10/10 - The rename follows the established Title Case filename pattern visible in other redirects.csv entries (e.g., Import-Personal-Card-Transactions-From-a-Spreadsheet, Add-an-Expense-Policy-to-a-Workspace). The redirect entry is well-formed.

Key Findings

  • The file rename and redirect are correct and consistent with existing conventions in docs/redirects.csv.
  • No content was added, removed, or modified — this is purely a housekeeping change.
  • The redirect CSV entry correctly maps the old lowercase URL to the new Title Case URL, preventing broken links.

Advisory: Pre-Existing Content Issues (Not Part of This Diff)

The following issues exist in the unchanged article content. They are not introduced by this PR and should not block merge, but are worth addressing in a follow-up:

  1. Heading depth violation (### headings): The article uses ### If your hotel accepts Travel Invoicing and ### If your hotel does not accept Travel Invoicing. Per HELP_AUTHORING_GUIDELINES.md Section 9: "Only ## used for all content sections (no ### or deeper)." These should be refactored to ## headings.
  2. Non-task-based headings: The ### headings above are conditional statements, not task-based. Per governance, all headings (except # FAQ) must start with an action verb or question word (How, What, Where, Who, Why, When). For example: ## What to do if your hotel accepts Travel Invoicing.
  3. Heading "What to expect after you book a hotel with Travel Invoicing": This uses "What to expect" which is borderline — it starts with a question word ("What") but is not phrased as an actionable task. Consider rephrasing to something more direct.
  4. Heading "What happens after your hotel stay": Similarly uses a question word but could be more task-oriented, e.g., "What to do after your hotel stay with Travel Invoicing".

Recommendations

  • Merge as-is: The rename and redirect are correct and follow established patterns. No issues with the proposed changes.
  • Follow-up PR recommended: Address the pre-existing ### heading violations and non-task-based heading issues in a separate content update PR.

Files Reviewed

  • docs/articles/travel/travel-invoicing/Complete-a-Hotel-Stay-Using-Travel-Invoicing.md — Renamed from lowercase to Title Case. No content changes. Rename is correct.
  • docs/redirects.csv — One new redirect line added mapping old URL to new URL. Correctly formatted and consistent with existing entries.

@blimpich blimpich requested review from bfitzexpensify and removed request for jliexpensify and mollfpr May 22, 2026 23:01
@github-actions github-actions Bot changed the title [NO QA] Capitalize Travel Invoicing hotel stay help article filename [No QA] [NO QA] Capitalize Travel Invoicing hotel stay help article filename May 22, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b604d345.helpdot.pages.dev ⚡️

Updated articles:

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single housekeeping change: renaming the file complete-a-hotel-stay-using-travel-invoicing.md to Complete-a-Hotel-Stay-Using-Travel-Invoicing.md (capitalizing the filename to match HelpDot filename conventions) and adding a corresponding redirect entry in redirects.csv to preserve the old URL.

No article content was added, removed, or modified. The diff consists entirely of the file rename and the new redirect line.

Scores Summary

  • Readability: 10/10 - No content changes were made. The rename does not affect readability.
  • AI Readiness: 10/10 - No content changes were made. The existing article (unchanged) already contains proper YAML metadata including internalScope, task-based headings, and appropriate heading hierarchy.
  • Style Compliance: 10/10 - No content changes were made. The redirect entry correctly maps the old lowercase URL to the new capitalized URL, preserving link integrity.

Key Findings

  • The filename capitalization change aligns the file with the Title-Case convention used by other HelpDot articles (e.g., Import-Personal-Card-Transactions-From-a-Spreadsheet.md).
  • The redirect in redirects.csv is properly formatted and will prevent broken links from any existing references to the old lowercase URL.
  • No content was altered, so there are no governance compliance concerns with the proposed changes.

Recommendations

  • None. This is a clean, low-risk housekeeping change.
  • One observation on the existing (unchanged) file content: it uses ### subheadings (lines 39 and 55), which per HELP_AUTHORING_GUIDELINES.md Section 4 and Section 9 should use only # and ##. This is pre-existing and outside the scope of this PR, but worth noting for a future cleanup pass.

Files Reviewed

  • docs/articles/travel/travel-invoicing/Complete-a-Hotel-Stay-Using-Travel-Invoicing.md - Renamed from lowercase; no content changes.
  • docs/redirects.csv - One redirect line added mapping old URL to new URL.

@bfitzexpensify bfitzexpensify merged commit dd5518b into main May 25, 2026
23 checks passed
@bfitzexpensify bfitzexpensify deleted the blimpich-fixTravelInvoicingHotelArticleFilename branch May 25, 2026 06:04
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.3.81-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants