[Bulk workspace edits] Add Copy Policy Settings progress modal by fedirjh · Pull Request #91368 · Expensify/App

fedirjh · 2026-05-21T22:21:16Z

Explanation of Change

Implements the Copy Policy Settings progress modal — task 6 of the Bulk Workspace Edits project. Stacked on top of #91241 (page 3 of 3) which is itself stacked on #90220 (page 2). Please land the upstream PRs first.

Fixed Issues

$ #88673
$ #92390
PROPOSAL: N/A

Tests

Setup

Log in to NewDot as an admin of at least two Control workspaces (so the Copy settings flow is available from the workspace list three-dot menu).

Test 1 — Loading state

From the Workspaces list, kick off a Copy settings flow and tap Copy settings on the Confirm step.
Verify the Copy in progress modal appears with Let me know when it’s done.

Test 2 — Notification requested state

From the loading state, tap Let me know when it’s done.
Verify the modal transitions to the Concierge notification state.

Test 3 — Complete state (no notify requested)

Reach the loading state (Test 1).
Await for the copy to complete of Simulate backend completion: Onyx.merge('nvp_bulkPolicyCopySettings', {state: 'complete'}).
Verify the modal updates to All Set! with a single Done button.
Tap Done and confirm the modal is closed.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Adds translation keys for the copy-in-progress modal states: copyInProgressTitle, copyInProgressDescription, letMeKnowPrompt, conciergeNotificationTitle, conciergeNotificationDescription, goToConcierge, dismiss, allSetTitle, allSetDescription, done.

…letion states Uses ConfirmModal to display copy progress with three states: - Loading: offers to notify user via Concierge when done - Notification requested: shows confirmation and link to Concierge - Complete: success state with dismiss action

Covers visibility, loading state transitions, notification request flow, complete state, and state reset on step changes.

melvin-bot · 2026-05-21T22:21:21Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

…sModal to use a new structure

…progress-modal # Conflicts: # src/languages/de.ts # src/languages/en.ts # src/languages/es.ts # src/languages/fr.ts # src/languages/it.ts # src/languages/ja.ts # src/languages/nl.ts # src/languages/pl.ts # src/languages/pt-BR.ts # src/languages/zh-hans.ts

…progress-modal

… in multiple languages

…t for clarity and maintainability

… consistency in CopyPolicySettingsParams

codecov · 2026-05-21T23:11:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.79% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/components/ConfirmContent.tsx	`89.09% <100.00%> (+0.41%)`	⬆️
src/components/ConfirmModal.tsx	`100.00% <ø> (ø)`
src/libs/actions/Policy/CopyPolicySettings.ts	`82.40% <100.00%> (+0.16%)`	⬆️
src/pages/workspace/WorkspacesListPage.tsx	`67.33% <100.00%> (+0.13%)`	⬆️
...PolicySettings/CopyPolicySettingsProgressModal.tsx	`100.00% <100.00%> (ø)`
...ySettings/CopyPolicySettingsSelectFeaturesPage.tsx	`71.11% <100.00%> (+71.11%)`	⬆️
...pyPolicySettings/CopyPolicySettingsConfirmPage.tsx	`0.00% <0.00%> (ø)`
... and 40 files with indirect coverage changes

…odal in CopyPolicySettingsProgressModal

melvin-bot · 2026-05-21T23:17:03Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee0f3c83d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

joekaufmanexpensify

Core design doc issue

The merge-base changed after approval.

fedirjh · 2026-06-04T14:00:07Z

Can we run an ad hoc build to test?

@dannymcclain Yes

github-actions · 2026-06-04T14:24:09Z

🚧 @dannymcclain has triggered a test Expensify/App build. You can view the workflow run here.

dannymcclain · 2026-06-04T14:56:51Z

I think we should match the Select all control from Duplicate:

Duplicate	This PR (Copy)

I also didn't see the loader in the modal—and when I tried to go the Concierge route, when I clicked dismiss it popped up the confirmation screen as if I didn't choose the Concierge option. And then there's also a brief flicker at the end where the button changes to Yes and the modal has no other content.

CleanShot.2026-06-04.at.09.52.04.mp4

Adds a new optional `isTitleLoading` prop to ConfirmModal and ConfirmContent that displays an ActivityIndicator next to the title. This is useful for modals showing progress states where a loading indicator in the header area is more appropriate than the confirm button loading state.

…ismiss behavior - Use new isTitleLoading prop to show loading indicator during copy in progress - Fix "All Set" screen incorrectly showing when dismissing from Concierge notification step by only showing it when on the loading step AND backend reports complete

… page Update CopyPolicySettingsSelectFeaturesPage to use custom Checkbox and PressableWithFeedback for "Select all" control, matching the pattern used in WorkspaceDuplicateSelectFeaturesForm for visual consistency.

fedirjh · 2026-06-04T15:44:57Z

I think we should match the Select all control from Duplicate:

@dannymcclain Updated to match that

I also didn't see the loader in the modal—and when I tried to go the Concierge route, when I clicked dismiss it popped up the confirmation screen as if I didn't choose the Concierge option. And then there's also a brief flicker at the end where the button changes to Yes and the modal has no other content.

Fixed that as well

CleanShot.2026-06-04.at.16.38.47.mp4

CleanShot.2026-06-04.at.16.45.54.mp4

shubham1206agra · 2026-06-05T16:06:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-06-05.at.8.00.50.PM.mov

Screen.Recording.2026-06-05.at.9.03.21.PM.mov

Screen.Recording.2026-06-05.at.9.07.30.PM.mov

OSBotify · 2026-06-05T17:09:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-05T17:10:27Z

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-05T17:15:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91368.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d8f64dd837e-a8a87d5-bf082f1ce36a80b7067988c428ec3674c956d410/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d8f64dd-a8a87d5-7b5e5eeb041a8834a8d4d2b1bf9e1e826ec1cc36/index.html

Web 🕸️
https://91368.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-05T18:15:19Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

jponikarchuk · 2026-06-06T06:33:37Z

Deploy Blocker #92850 was identified to be related to this PR.

jponikarchuk · 2026-06-07T06:54:04Z

Deploy Blocker #92873 was identified to be related to this PR.

jponikarchuk · 2026-06-07T06:54:15Z

Deploy Blocker #92873 was identified to be related to the PR #91368 that attempted to fix this issue.

OSBotify · 2026-06-09T04:09:33Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fedirjh added 4 commits May 21, 2026 10:16

feat: integrate CopyPolicySettingsProgressModal into WorkspacesListPage

aa77eba

test: add unit tests for CopyPolicySettingsProgressModal

9b832e2

Covers visibility, loading state transitions, notification request flow, complete state, and state reset on step changes.

melvin-bot Bot assigned fedirjh May 21, 2026

fedirjh added 7 commits May 21, 2026 23:27

feat(i18n): restructure copy policy settings progress translations

8acfd5b

refactor(i18n): update translation keys for CopyPolicySettingsProgres…

e8fe38d

…sModal to use a new structure

Merge branch 'copy-policy-settings-page-3' into copy-policy-settings-…

37cbb89

…progress-modal

feat(i18n): add new translation keys for 'goToConcierge' and 'allSet'…

efb5bdd

… in multiple languages

refactor(tests): simplify mocks in CopyPolicySettingsProgressModalTes…

c3a38d1

…t for clarity and maintainability

refactor(copy-policy-settings): rename sourcePolicyID to policyID for…

0630918

… consistency in CopyPolicySettingsParams

chore(copy-policy-settings): add comment to clarify usage of ConfirmM…

ee0f3c8

…odal in CopyPolicySettingsProgressModal

fedirjh requested review from francoisl and ishpaul777 May 21, 2026 23:16

fedirjh marked this pull request as ready for review May 21, 2026 23:16

fedirjh requested review from a team as code owners May 21, 2026 23:16

melvin-bot Bot requested review from bernhardoj and joekaufmanexpensify and removed request for a team May 21, 2026 23:17

melvin-bot Bot removed the request for review from a team May 21, 2026 23:17

chatgpt-codex-connector Bot reviewed May 21, 2026

View reviewed changes

Comment thread src/pages/workspace/copyPolicySettings/CopyPolicySettingsProgressModal.tsx Outdated

joekaufmanexpensify previously approved these changes May 22, 2026

View reviewed changes

francoisl requested a review from yuwenmemon May 24, 2026 22:46

ishpaul777 removed the request for review from bernhardoj May 28, 2026 14:47

Merge branch 'Expensify:main' into copy-policy-settings-progress-modal

38c3f71

This comment has been minimized.

Sign in to view

fedirjh added 3 commits June 4, 2026 16:41

fedirjh requested review from dannymcclain and ishpaul777 June 4, 2026 15:49

shubham1206agra approved these changes Jun 5, 2026

View reviewed changes

yuwenmemon approved these changes Jun 5, 2026

View reviewed changes

yuwenmemon merged commit d8f64dd into Expensify:main Jun 5, 2026
34 checks passed

fedirjh deleted the copy-policy-settings-progress-modal branch June 5, 2026 17:04

OSBotify mentioned this pull request Jun 5, 2026

Deploy Checklist: New Expensify 2026-06-05 #92792

Closed

applause-bot Bot mentioned this pull request Jun 6, 2026

[Due for payment 2026-06-17] Workspace -Browser back button with "All Set" modal open leads to previous page on background #92850

Open

7 tasks

This was referenced Jun 6, 2026

[Due for payment 2026-06-16] [Bulk workspace edits] Progress modal (in-progress, notify-requested, complete states) [6] #88673

Open

[Due for payment 2026-06-16] [$250] Android - Copy Settings - Offline indicator overlaps "Copy Settings" button. #92390

Closed

applause-bot Bot mentioned this pull request Jun 7, 2026

[Due for payment 2026-06-17] Workspace - "Copy in progress..." & "All set!" modal cannot be dismissed by clicking outside #92873

Open

7 tasks

adhorodyski mentioned this pull request Jun 10, 2026

[Performance] App hangs when OpenApp / ReconnectApp / GetMissingOnyxMessages fire in rapid stampedes #92541

Open

4 tasks

Conversation

fedirjh commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Setup

Test 1 — Loading state

Test 2 — Notification requested state

Test 3 — Complete state (no notify requested)

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

codecov Bot commented May 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

fedirjh commented Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

This comment has been minimized.

dannymcclain commented Jun 4, 2026

Uh oh!

fedirjh commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jun 5, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

jponikarchuk commented Jun 6, 2026

Uh oh!

jponikarchuk commented Jun 7, 2026

Uh oh!

jponikarchuk commented Jun 7, 2026

Uh oh!

OSBotify commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

fedirjh commented May 21, 2026 •

edited

Loading

codecov Bot commented May 21, 2026 •

edited by github-actions Bot

Loading

fedirjh commented Jun 4, 2026 •

edited

Loading