BT Migrate `WORKSPACE_TAGS` by mananjadhav · Pull Request #91265 · Expensify/App

mananjadhav · 2026-05-21T05:51:08Z

Explanation of Change

Fixed Issues

$ #83833
PROPOSAL:

Tests

Prerequisites

Use a workspace where you are an admin and Tags are enabled.
Have at least one tag list with tags (multi-level tags help cover list-view flows).

Edit tag list name (tags-edit/:orderWeight)

Go to Workspaces → open a workspace → Tags.
Open Tags settings or a multi-level tag list → Edit / rename tag list.
Observe the URL ends with tags-edit/<orderWeight> (e.g. workspaces/<policyID>/tags/tags-edit/0).
Tap Back.
Confirm you return to tags settings or the tag list view (URL no longer contains tags-edit/).
Open the same screen again, then refresh the page.
Confirm the edit screen loads and the URL still ends with tags-edit/<orderWeight>.
Tap Back and confirm behavior matches step 5.

Tag settings (tag/:orderWeight/:tagName)

From Workspaces → Tags, open a tag (single-level) or open a tag inside a multi-level list.
Observe the URL ends with tag/<orderWeight>/<tagName> (e.g. workspaces/<policyID>/tags/tag/0/Meals).
Tap Back.
Confirm you return to the tags list or tag list view (URL no longer contains /tag/<orderWeight>/).
Open tag settings again, then refresh the page.
Confirm tag settings loads with the same URL suffix.
Tap Back and confirm behavior matches step 4.

Edit tag name (tag-edit)

From workspace tag settings (.../tag/<orderWeight>/<tagName>), tap Edit name (or equivalent).
Observe the URL ends with tag-edit (e.g. .../tag/0/Meals/tag-edit).
Tap Back.
Confirm you return to tag settings (URL ends with tag/<orderWeight>/<tagName>, not tag-edit).
Open edit name again, then refresh the page.
Confirm the edit screen loads and the URL still ends with tag-edit.
Tap Back and confirm behavior matches step 4.

Tag GL code (tag-gl-code)

From workspace tag settings, open GL code (control policy required; upgrade flow is OK on non-control).
Observe the URL ends with tag-gl-code (e.g. .../tag/0/Meals/tag-gl-code).
Tap Back.
Confirm you return to tag settings.
Open GL code again, then refresh the page.
Confirm the screen loads and the URL still ends with tag-gl-code.
Tap Back and confirm behavior matches step 4.

Tag approver (workspace-tag-approver)

From workspace tag settings, open Approver (workflows/rules enabled).
Observe the URL ends with workspace-tag-approver (e.g. .../tag/0/Meals/workspace-tag-approver).
Tap Back.
Confirm you return to tag settings.
Open approver again, then refresh the page.
Confirm the screen loads and the URL still ends with workspace-tag-approver.
Tap Back and confirm behavior matches step 4.

Create tag (tags/new)

From Workspaces → Tags, tap Create tag (or equivalent).
Observe the URL ends with tags/new (e.g. workspaces/<policyID>/tags/tags/new).
Tap Back (or save and confirm return).
Confirm you return to the tags list.
Open create tag again, then refresh the page.
Confirm the create screen loads and the URL still ends with tags/new.
Tap Back and confirm behavior matches step 4.

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

Same as Test Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-workspace-tags.mov

web-workspace-tags-new.mov

codecov · 2026-05-21T06:00:51Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/OldRoutes.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/DynamicEditTagsPage.tsx	`0.00% <0.00%> (ø)`
...rc/pages/workspace/tags/DynamicTagApproverPage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/DynamicTagGLCodePage.tsx	`0.00% <0.00%> (ø)`
src/pages/workspace/tags/WorkspaceTagsPage.tsx	`47.86% <0.00%> (+0.53%)`	⬆️
src/pages/workspace/tags/DynamicCreateTagPage.tsx	`0.00% <0.00%> (ø)`
... and 5 more
... and 8 files with indirect coverage changes

melvin-bot · 2026-05-21T06:11:15Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2026-05-21T06:11:31Z

I've raised this PR. Will check the Codex comments if any in a while.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54bb0213fa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

huult · 2026-05-22T03:11:20Z

@mananjadhav please resolve the conflict

huult · 2026-05-22T03:18:25Z

+    | PlatformStackScreenProps<SettingsNavigatorParamList, typeof SCREENS.WORKSPACE.DYNAMIC_WORKSPACE_TAG_CREATE>
    | PlatformStackScreenProps<SettingsNavigatorParamList, typeof SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE>;

 function WorkspaceCreateTagPage({route}: WorkspaceCreateTagPageProps) {


Suggested change

function WorkspaceCreateTagPage({route}: WorkspaceCreateTagPageProps) {

function DynamicWorkspaceCreateTagPage({route}: WorkspaceCreateTagPageProps) {

Could you rename this?

huult · 2026-05-22T03:22:20Z

    const {inputCallbackRef} = useAutoFocusInput();
-    const isDynamicFlow = route.name === SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE;
-    const backPath = useDynamicBackPath(DYNAMIC_ROUTES.SETTINGS_TAG_CREATE.path);
+    const isDynamicFlow = route.name === SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE || route.name === SCREENS.WORKSPACE.DYNAMIC_WORKSPACE_TAG_CREATE;


Do we still need to keep isDynamicFlow? Since we’ve already migrated everything, I don’t think it’s needed anymore because the flow is now fully dynamic. So I think we can remove them

huult · 2026-05-22T03:23:35Z

-    const backPath = useDynamicBackPath(DYNAMIC_ROUTES.SETTINGS_TAG_CREATE.path);
+    const isDynamicFlow = route.name === SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE || route.name === SCREENS.WORKSPACE.DYNAMIC_WORKSPACE_TAG_CREATE;
+    const backPath = useDynamicBackPath(
+        route.name === SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE ? DYNAMIC_ROUTES.SETTINGS_TAG_CREATE.path : DYNAMIC_ROUTES.WORKSPACE_TAG_CREATE.path,


I also don’t think we need to check SCREENS.SETTINGS_TAGS.DYNAMIC_SETTINGS_TAG_CREATE to distinguish between settings and workspace anymore, since the dynamic flow no longer requires that distinction. Can we merge SETTINGS_TAG_CREATE and WORKSPACE_TAG_CREATE into one, so we only use a single constant?

huult · 2026-05-22T03:27:04Z

Hi @mananjadhav, I’ve reviewed this PR. I think we may not need to distinguish isQuickSettingsFlow anymore, and we can fully use a single screen for both workspace and settings flows. Do you think we can remove the isQuickSettingsFlow check?

mananjadhav · 2026-05-22T04:02:22Z

That is what I discussed here.

…rkspace-tags

huult · 2026-05-22T04:23:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-22.at.11.33.26.mov

huult

LGTM.

github-actions · 2026-05-22T06:00:56Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-22T06:06:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91265.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cb7ac7b-d1139c3-f2062af7eed3f05362d1e13c74b25042887e33d9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cb7ac7b-d1139c3-6c49afbd1e8a9ed1fb01f1863829e2e328f4c726/index.html

Web 🕸️
https://91265.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-22T06:08:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-22T22:45:25Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-22T22:46:49Z

No help site changes are required for this PR.

This PR is a purely internal navigation/routing refactoring — it migrates workspace tags routes from static to dynamic route definitions in ROUTES.ts, SCREENS.ts, and related navigation files. No user-facing functionality, UI labels, feature names, or workflows were changed.

I reviewed the existing help site article Create-and-manage-expense-tags.md and other tag-related docs — all instructions reference UI elements (e.g., "select Tags", "Choose Add tag") that remain unchanged by this PR.

mitarachim · 2026-05-22T23:45:45Z

Deploy Blocker #91480 was identified to be related to this PR.

OSBotify · 2026-05-25T22:37:49Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mananjadhav added 2 commits May 21, 2026 11:09

feat: migrate tag paths to dynamic routes

8440430

fix: update the routes

ad71dc7

melvin-bot Bot assigned mananjadhav May 21, 2026

mananjadhav added 2 commits May 21, 2026 11:33

fix: update tag name

da9e68c

fix: rename files

54bb021

mananjadhav marked this pull request as ready for review May 21, 2026 06:11

mananjadhav requested review from a team as code owners May 21, 2026 06:11

melvin-bot Bot requested review from heyjennahay and huult and removed request for a team May 21, 2026 06:11

melvin-bot Bot removed the request for review from a team May 21, 2026 06:11

chatgpt-codex-connector Bot reviewed May 21, 2026

View reviewed changes

Comment thread src/libs/Navigation/linkingConfig/OldRoutes.ts

Comment thread src/libs/Navigation/linkingConfig/OldRoutes.ts

fix: add old route mapping

dc447fa