[CP Staging] fix: inline editing deploy blockers by mohammadjafarinejad · Pull Request #90817 · Expensify/App

mohammadjafarinejad · 2026-05-15T17:52:52Z

Explanation of Change

This PR resolves deployer blockers from:

feat: Add inline editing for tables on desktop (V2) #89166

Fixed Issues

$ #82534
$ #90815
$ #90814
PROPOSAL:

Tests

Test 1

Go to workspace chat.
Create two expenses with date from last year (25 May 2025).
Open expense report.
Verify Date field will show the date completely.

Test 2

Go to workspace chat.
Create two expenses with date from last year.
Open expense report.
Click Date field on any expense row.
Select the same date.
Repeat Step 5 and 6 a few times.
Open the expense.
Verify No system message will be triggered after selecting the same date.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Inline editing isn't available on other platforms, so I only added desktop recordings.

MacOS: Chrome / Safari

REC-20260515230915.mp4

codecov · 2026-05-15T18:11:57Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...components/Search/SearchList/ListItem/DateCell.tsx	`100.00% <100.00%> (ø)`
...ents/TransactionItemRow/DataCells/CategoryCell.tsx	`100.00% <100.00%> (ø)`
...omponents/TransactionItemRow/DataCells/TagCell.tsx	`100.00% <100.00%> (ø)`
...sactionItemRow/EditableCell/usePopoverEditState.ts	`88.00% <100.00%> (+2.28%)`	⬆️
src/styles/utils/index.ts	`49.55% <100.00%> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
... and 66 files with indirect coverage changes

melvin-bot · 2026-05-15T19:12:41Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2026-05-16T13:15:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-16.at.4.12.35.PM.mov

Screen.Recording.2026-05-16.at.4.12.02.PM.mov

ahmedGaber93

NAB: Just two clean-ups

ahmedGaber93

NAB: Just two cleanup comments #90817 (review)

@puneetlath

github-actions · 2026-05-18T14:08:27Z

🚧 @puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-18T14:14:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90817.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-df0af45-c55c030-65033e9d84787869f5d4c84e812659966e2241e9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-df0af45-c55c030-0db03afff41e5e88bdfa278b250a4d48c2c5b6ea/index.html

Web 🕸️
https://90817.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-18T14:18:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: inline editing deploy blockers (cherry picked from commit df0af45) (cherry-picked to staging by puneetlath)

OSBotify · 2026-05-18T14:48:25Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.75-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-18T14:50:51Z

After reviewing the changes in this PR, no help site documentation updates are required.

This PR contains purely internal bug fixes for inline editing:

Widened the date column to fully display dates from past years
Added value comparison logic to prevent unnecessary saves when the same value is re-selected (e.g., selecting the same date, category, or tag)
Reorganized test files

These are all internal code/UI fixes that don't introduce new features, rename existing features, or change user-facing workflows documented on the help site.

OSBotify · 2026-05-18T20:56:12Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.75-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-18T20:57:30Z

I reviewed all the changes in this PR. The modifications are:

Date column width increase — widened the date column so dates from past years display fully (style/variable change only)
No-op save prevention — refactored usePopoverEditState to compare new values against the original before calling onSave, preventing unnecessary system messages when re-selecting the same date/category/tag
Test reorganization — moved and renamed test files, added new tests for usePopoverEditState

Conclusion: No help site changes are required. These are internal bug fixes to inline editing behavior and UI layout that don't affect any documented user-facing workflows, features, or settings.

OSBotify · 2026-05-19T08:03:00Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.75-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-19T08:09:34Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.3.76-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-05-19T08:10:56Z

No help site changes are required for this PR.

The changes are internal bug fixes for inline editing (date column width, preventing no-op saves, hook refactoring, and test reorganization). None of these affect user-facing workflows or features documented in App/docs/articles.

OSBotify · 2026-05-19T22:02:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.77-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Handle equality check in usePopoverEditState

113fc6b

melvin-bot Bot assigned mohammadjafarinejad May 15, 2026

mohammadjafarinejad mentioned this pull request May 15, 2026

[Due for payment 2026-06-23] [Partial Payment?][CFI] Add inline editing for tables on desktop #82534

Open

mohammadjafarinejad added 3 commits May 15, 2026 22:29

fix: update date column width to use w102

7cf3439

refactor: move inline editing tests to /tests/unit/inlineEditing

358fab4

test: add inline and popover editing state tests

c5b611b

mohammadjafarinejad marked this pull request as ready for review May 15, 2026 19:12

mohammadjafarinejad requested review from a team as code owners May 15, 2026 19:12

melvin-bot Bot requested review from ahmedGaber93 and joekaufmanexpensify and removed request for a team May 15, 2026 19:12

github-actions Bot reviewed May 15, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/EditableCell/usePopoverEditState.ts

github-actions Bot reviewed May 15, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/EditableCell/usePopoverEditState.ts

refactor: remove useCallback from usePopoverEditState

4aa900c

ahmedGaber93 reviewed May 16, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/DataCells/TagCell.tsx Outdated

Comment thread src/components/TransactionItemRow/DataCells/CategoryCell.tsx Outdated

ahmedGaber93 approved these changes May 16, 2026

View reviewed changes

melvin-bot Bot requested a review from puneetlath May 16, 2026 15:36

fix: simplify onSave handling in CategoryCell and TagCell

6e19ffb

puneetlath approved these changes May 18, 2026

View reviewed changes

puneetlath merged commit df0af45 into Expensify:main May 18, 2026
34 checks passed

mountiny changed the title ~~fix: inline editing deploy blockers~~ [CP Staging] fix: inline editing deploy blockers May 18, 2026

OSBotify pushed a commit that referenced this pull request May 18, 2026

Merge pull request #90817 from mohammadjafarinejad/fix/82534-v2-followup

a75bc84

fix: inline editing deploy blockers (cherry picked from commit df0af45) (cherry-picked to staging by puneetlath)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 18, 2026

OSBotify mentioned this pull request May 18, 2026

Deploy Checklist: New Expensify 2026-05-15 #90795

Closed

Conversation

mohammadjafarinejad commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1

Test 2

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 15, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 15, 2026

Uh oh!

Uh oh!

Uh oh!

ahmedGaber93 commented May 16, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

OSBotify commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

MelvinBot commented May 19, 2026

Uh oh!

OSBotify commented May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mohammadjafarinejad commented May 15, 2026 •

edited

Loading

codecov Bot commented May 15, 2026 •

edited by github-actions Bot

Loading