[Payment due @hoangzinh] [CP Staging] Hide CSV company card import behind a beta#90483
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Gonals Does it need c+ review? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 641d9c0086
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Hi @abzokhattab It comes from our PR. Let me handle here |
Reviewer Checklist
Screen.Recording.2026-05-13.at.19.11.09.mov |
|
🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[Payment due @hoangzinh] [CP Staging] Hide CSV company card import behind a beta (cherry picked from commit e7399f5) (cherry-picked to staging by mountiny)
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.73-2 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR and the help site articles under No help site changes are required. This PR hides the "Import transactions from file" company card feed type behind the Since the company card file import feature was never documented on the help site, gating it behind a beta requires no doc updates. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.74-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR gates the "Import transactions from file" option in the company card setup flow behind the
Since no documentation exists for the feature being gated, no docs updates are needed. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀
|
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/636474
PROPOSAL:
Tests
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari