Skip to content

[No QA] perf(search): remove dead policies and queryJSONHash props from ListItem #90452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
May 13, 2026
Merged

[No QA] perf(search): remove dead policies and queryJSONHash props from ListItem #90452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/components/Search/SearchList/ListItem/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ type SearchListActionProps = {
};

type ChatListItemProps<TItem extends ListItem> = ListItemProps<TItem> & {
queryJSONHash?: number;

/** The report data */
report?: Report;

Expand Down Expand Up @@ -434,7 +432,6 @@ type TransactionGroupListItemProps<TItem extends ListItem> = ListItemProps<TItem
SearchListActionProps & {
groupBy?: SearchGroupBy;
searchType?: SearchDataTypes;
policies?: OnyxCollection<Policy>;
accountID?: number;
columns?: SearchColumnType[];
newTransactionID?: string;
Expand Down
8 changes: 1 addition & 7 deletions src/components/Search/SearchList/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ function SearchList({
const styles = useThemeStyles();
const expensifyIcons = useMemoizedLazyExpensifyIcons(['CheckSquare']);

const {hash, groupBy, type} = queryJSON;
const {groupBy, type} = queryJSON;
const flattenedItems = useMemo(() => {
if (groupBy || type === CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT) {
if (!isTransactionGroupListItemArray(data)) {
Expand Down Expand Up @@ -299,8 +299,6 @@ function SearchList({
const [isModalVisible, setIsModalVisible] = useState(false);
const [longPressedItem, setLongPressedItem] = useState<SearchListItem>();

const [policies] = useOnyx(ONYXKEYS.COLLECTION.POLICY);

const hasItemsBeingRemoved = prevDataLength && prevDataLength > data.length;
const personalDetails = usePersonalDetails();

Expand Down Expand Up @@ -445,9 +443,7 @@ function SearchList({
onSelectionButtonPress={onCheckboxPress}
canSelectMultiple={canSelectMultiple}
item={itemWithSelection}
queryJSONHash={hash}
columns={columns}
policies={policies}
policyForMovingExpenses={policyForMovingExpenses}
isDisabled={isDisabled}
groupBy={groupBy}
Expand Down Expand Up @@ -485,9 +481,7 @@ function SearchList({
handleLongPressRow,
onCheckboxPress,
canSelectMultiple,
hash,
columns,
policies,
personalDetails,
userBillingFundID,
isOffline,
Expand Down
Loading