[Payment due @dukenv0307] Update map markers and route styles#90169
Conversation
|
@Expensify/design could you take a look and test? |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@codex review |
|
Okay, I think I prefer not to see the overlap like that so I guess what we had before is better. |
|
@codex review pls |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 222382e614
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21b7bd5ace
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@shawnborton shadow should work now on mobile as well. I'll switch to review when you confirm everything looks good |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
|
@dukenv0307 do you want to review as this is part of the GPS project? |
|
@GCyganek Yes, I'll review this PR |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-22.at.15.24.31.movAndroid: mWeb ChromeScreen.Recording.2026-05-22.at.17.47.13.moviOS: HybridAppScreen.Recording.2026-05-22.at.14.48.25.moviOS: mWeb SafariScreen.Recording.2026-05-22.at.15.36.20.movMacOS: Chrome / SafariScreen.Recording.2026-05-22.at.15.34.25.mov |
|
@GCyganek, the map doesn't show in Android mweb. Can you please take a look? It works on main/staging |
On it, thanks for checking! |
|
@dukenv0307 can you give me more details? It loads fine for me on Pixel Pro 9XL 36.0 android simulator. Maybe it's a problem with your mapbox config, does it load on on dev on main? |
|
@GCyganek Ah it worked after merging main. All good now |
|
🎯 @dukenv0307, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.81-0 🚀
|
|
After reviewing the changes in this PR, no help site updates are required. This PR replaces map marker icons ( The relevant help article (Distance Expenses) describes user workflows for creating and managing distance expenses but does not reference specific marker visuals or route styling — so no documentation changes are needed. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.81-2 🚀
|







Explanation of Change
Replaces old map markers (DotIndicator, Location, Crosshair) with new map markers (
MapStartWaypoint,MapStopWaypoint,MapWaypoint,MapCurrentLocation) on all platforms for MapView component. Updates route styles.Also disables current user's location marker on the confirm screen map.
Fixed Issues
$ part of #85802
PROPOSAL: N/A
Tests
Start GPS trip
Verify that the new markers are displayed correctly on both web and mobile
Verify that the route between markers is displayed correctly
Tap
SaveVerify that the user's current location marker is not shown on the confirmation page
FAB > Track Distance > Map
Add at least 3 waypoints
Verify that the new markers are displayed correctly on both web and mobile
Verify that the route between markers is displayed correctly
Tap
NextVerify that the user's current location marker is not shown on the confirmation page
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-11.at.13.34.14.mov
Screen.Recording.2026-05-20.at.11.53.50.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-05-11.at.13.34.58.mov
iOS: mWeb Safari
MacOS: Chrome / Safari