[NoQA] chore: bump react-native-worklets to version 0.8.1#90088
Conversation
|
|
16afa56 to
2de9e20
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16afa5678e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| +++ b/node_modules/react-native-worklets/android/build/intermediates/prefab_package_header_only/prefab_publication.json/debug | ||
| @@ -0,0 +1,18 @@ | ||
| +{ | ||
| + "installationFolder": "/Users/chris/Projects/Margelo/ExpensifyApp3/node_modules/react-native-worklets/android/build/intermediates/prefab_package/debug/prefab", |
There was a problem hiding this comment.
Drop machine-specific prefab artifacts from the worklets patch
This patch now adds Android build/intermediates prefab metadata into patch-package, including absolute paths under /Users/chris/.... Because this patch is replayed on every install, it bakes local, generated build artifacts into all environments and can make Android prefab metadata stale/non-portable across machines; these generated intermediates should not be part of the dependency patch.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Thanks for the catch!
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@mountiny merged main to fix lint errors 👍🏼 |
|
Taken off hold, merged main and resolved conflicts. @roryabraham @mkhutornyi this is ready for review! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
@mkhutornyi i can build and run Android without any problems. Did you check that JS and native worklets version match up and the Android app was actually built with newest |
App crashed for on both dev build and adhoc build. For local build, is there any way to run fresh build locally, instead of downloading from s3? I run |
You can run local build using |
|
@mountiny @roryabraham could we get another ad-hoc build on this one? 🙌🏼 |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Hmm, This android build still crashing for me. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@mkhutornyi @mountiny latest ad-hoc build doesn't crash now on Android! 🙌🏼 |
|
yes works for me too. Not sure why adhoc build is flaky for the same code path |
@mkhutornyi the CI cache was stale/invalid. Clearing ad-hoc cache fixed the issue |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.73-0 🚀
Bundle Size Analysis (Sentry): |
|
Hi @chrispader we usually check all main flows during regression, do we need specific steps for this? |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.73-0 🚀
Bundle Size Analysis (Sentry): |
No specific steps |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀
|

@roryabraham
Explanation of Change
Bumps
react-native-workletsto version 0.8.1. This is needed to enablereact-native-nitro-fetchin #88110.Fixed Issues
$ #90149
$ #90023
PROPOSAL: #88110 (review)
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13935
Tests
Check general app flow and check for regressions. (None expected)
Offline tests
None needed.
QA Steps
Same as in Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari