Change Preferences label for QA testing#89281
Closed
MelvinBot wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 5869ba86..de3ea388 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Zahlungen',
approvals: 'Genehmigungen',
wallet: 'Brieftasche',
- preferences: 'Einstellungen',
+ preferences: 'Meine Einstellungen',
view: 'Anzeigen',
review: (amount?: string) => `Prüfen${amount ? ` ${amount}` : ''}`,
not: 'Nicht',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d25a5aa6..a440933d 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Paiements',
approvals: 'Approbations',
wallet: 'Portefeuille',
- preferences: 'Préférences',
+ preferences: 'Mes préférences',
view: 'Afficher',
review: (amount?: string) => `Examiner${amount ? ` ${amount}` : ''}`,
not: 'Non',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index abccbb17..9c66ba87 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Pagamenti',
approvals: 'Approvazioni',
wallet: 'Portafoglio',
- preferences: 'Preferenze',
+ preferences: 'Le mie preferenze',
view: 'Visualizza',
review: (amount?: string) => `Revisione${amount ? ` ${amount}` : ''}`,
not: 'Non',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 51ae0597..083fd8d6 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: '支払',
approvals: '承認',
wallet: 'ウォレット',
- preferences: '設定',
+ preferences: 'マイ設定',
view: '表示',
review: (amount?: string) => `レビュー${amount ? ` ${amount}` : ''}`,
not: 'いいえ',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index b43fcd96..299c85ff 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Betalingen',
approvals: 'Goedkeuringen',
wallet: 'Wallet',
- preferences: 'Voorkeuren',
+ preferences: 'Mijn voorkeuren',
view: 'Bekijken',
review: (amount?: string) => `Beoordelen${amount ? ` ${amount}` : ''}`,
not: 'Niet',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 07bbc38d..5cd86ac2 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Płatności',
approvals: 'Zatwierdzenia',
wallet: 'Portfel',
- preferences: 'Preferencje',
+ preferences: 'Moje preferencje',
view: 'Pokaż',
review: (amount?: string) => `Przejrzyj${amount ? ` ${amount}` : ''}`,
not: 'Nie',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index f5fef227..982aa0fb 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: 'Pagamentos',
approvals: 'Aprovações',
wallet: 'Carteira',
- preferences: 'Preferências',
+ preferences: 'Minhas preferências',
view: 'Visualizar',
review: (amount?: string) => `Revisar${amount ? ` ${amount}` : ''}`,
not: 'Não',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index de77d70b..89226857 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -136,7 +136,7 @@ const translations: TranslationDeepObject<typeof en> = {
payments: '付款',
approvals: '审批',
wallet: '钱包',
- preferences: '偏好设置',
+ preferences: '我的偏好设置',
view: '查看',
review: (amount?: string) => `审核${amount ? ` ${amount}` : ''}`,
not: '否',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@Eskalifer1 could you please approve this PR? We're implementing this change momentarily just for QA purposes. |
Contributor
|
Should i do review here? Or just approve? cc: @carlosmiceli |
Contributor
|
Just approve, it's a minor change. |
Eskalifer1
approved these changes
Apr 30, 2026
Eskalifer1
left a comment
Contributor
There was a problem hiding this comment.
LGTM
cc: @carlosmiceli
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #89280 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
Contributor
|
Closing now per https://github.com/Expensify/Web-Expensify/pull/52230#issuecomment-4355307347 Thank you @Eskalifer1 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Small copy change for QA testing purposes (web-e #52230). Changes the English "Preferences" label to "My Preferences" in the common translations. This is a discrete, easily verifiable change that will be reverted after testing.
Fixed Issues
$ #89280
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A - copy-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari