[Domain Control] [Release 4] Add create group button and RHP in DomainGroupsPage by jakubstec · Pull Request #88200 · Expensify/App

jakubstec · 2026-04-17T12:20:54Z

Explanation of Change

Add Create group button to DomainGroupsPage and Domain Security Group RHP to create a new group.

Fixed Issues

$#80132
PROPOSAL:

Tests

Preconditions:

User is a domain admin

Navigate to /domains/<domainAccountID>/groups
Open New group
Set any setting and type a name
Verify that it has been correctly created.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS: Native

Screen.Recording.2026-04-17.at.13.26.35.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-06.at.16.13.36.mov

Screen.Recording.2026-05-06.at.16.13.22.mov

Screen.Recording.2026-05-06.at.16.14.02.mov

…es in preferred workspace setting as well as workspace preselection

…I command for group creation, enable offline form handling

melvin-bot · 2026-04-17T12:21:00Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

jakubstec · 2026-04-17T12:38:11Z

diff is currently big because main PR isn't merged yet. Also there are reused features from other PRs so it affects it too. I got branch with ready skeleton, without API calls and error handling, so if It still would be too big, I'll split it into 2 PRs

…urity-group-create-group-rhp-form-submit-and-error-handling

jakubstec · 2026-04-27T09:56:34Z

@codex review

codecov · 2026-04-27T10:04:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
...avigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/types/form/DomainGroupCreateForm.ts	`0.00% <0.00%> (ø)`
src/ROUTES.ts	`17.66% <0.00%> (-0.04%)`	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.82% <0.00%> (-0.02%)`	⬇️
src/libs/actions/Domain.ts	`58.49% <77.77%> (+1.47%)`	⬆️
... and 3 more
... and 28 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

App/src/pages/domain/Groups/DomainGroupsPage.tsx

Line 63 in d34f2b7

    
           pendingAction: pendingActions?.[`${CONST.DOMAIN.DOMAIN_SECURITY_GROUP_PREFIX}${group.id}`]?.name ?? undefined,

Read add pending state from the correct key

createDomainSecurityGroup() records optimistic creation progress under domain_pendingActions[securityGroupKey].pendingAction, but this row still reads ...?.name for pendingAction. In slow/offline conditions, newly created groups won't show pending OfflineWithFeedback state and remain fully interactive before the create request has completed, which can trigger follow-up actions against an unsaved group.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…urity-group-create-group-rhp-form-submit-and-error-handling

rayane-d

As part of https://github.com/Expensify/Expensify/issues/631218

We are adding a shouldSetAsDefault boolean parameter to the CreateDomainSecurityGroup API command. This parameter allows the BE to set the group as the default for the domain immediately after creation in a single operation. This replaces the need to call CreateDomainSecurityGroup and SetDefaultDomainSecurityGroup sequentially and follows the 1:1:1 philosophy.

…ecurity-group-create-group-rhp-form-submit-and-error-handling

…aultGroup parameter, distinguish pending actions for group deletion and creation

melvin-bot · 2026-05-07T18:35:14Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-07T18:35:20Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-05-07T18:40:16Z

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
+            value: {


❌ CONSISTENCY-5 (docs)

The eslint-disable-next-line @typescript-eslint/naming-convention comment lacks a justification explaining why the rule is disabled.

Add a comment explaining the reason, for example:

// eslint-disable-next-line @typescript-eslint/naming-convention -- backend API uses snake_case for domain_defaultSecurityGroupID ...(shouldSetAsDefaultGroup && {domain_defaultSecurityGroupID: groupID}),

Reviewed at: 70c0ed1 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@jakubstec can you make sure to address all the bot comments with comment and resolve if sorted/ non actionable? Only leave unresolved those that need more discussion. Thank you!

trjExpensify

Core PR for a WN project. 👍

ZhenjaHorbach · 2026-05-08T08:06:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-05-08.11.02.02.mov

Android: mWeb Chrome

2026-05-08.11.12.31.mov

iOS: HybridApp

2026-05-08.11.02.02.mov

iOS: mWeb Safari

2026-05-08.11.12.31.mov

MacOS: Chrome / Safari

2026-05-08.10.52.56.mov

ZhenjaHorbach · 2026-05-08T09:28:45Z

But overall changes look good!

mountiny

Thanks! Couple comments, lets merge the other pr first too as seems like the changes are included in this PR too

mountiny · 2026-05-08T12:45:11Z

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
+            value: {


@jakubstec can you make sure to address all the bot comments with comment and resolve if sorted/ non actionable? Only leave unresolved those that need more discussion. Thank you!

…urity-group-create-group-rhp-form-submit-and-error-handling

mountiny

Thanks!

github-actions · 2026-05-12T17:01:14Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-05-12T17:13:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-12T17:21:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #88200.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c10769b-1ff9b8a-9ab05e78b049b3629139b7e08cb7a3d47467ae4e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c10769b-1ff9b8a-63dbe8928154324d88a153d12c1952913b1eaecd/index.html

Web 🕸️
https://88200.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-13T07:23:13Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

iOS

OSBotify · 2026-05-13T07:54:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-05-13T20:56:17Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.73-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jakubstec added 15 commits March 18, 2026 13:02

feat: add create new group button

8c83422

feat: RHP modal routing for new group creating

d4b2c6a

fix: add missing sentry label

fb8847c

feat: rhp form with security group name input

216c81d

feat: Add form toggles with state management, prettier fix

b4c0e49

feat: Handle Preferred Workspace setting

99e75aa

feat: add create group onSubmit functionality and error handling

320576d

feat: add tests for createDomainSecurityGroup and clearGroupCreateError

0bc08f8

resolve merge conflicts

27cf984

resolve merge conflict

928094d

fix: add missing translation files

ba53b3f

resolve merge conflicts

989facd

add missing translations, add blocking modal when admin has no polici…

3d4135c

…es in preferred workspace setting as well as workspace preselection

add setDefaultSecurityGroup function

e488481

use CreateDomainSecurityGroup instead of UpdateDomainSecurityGroup AP…

7103588

…I command for group creation, enable offline form handling

melvin-bot Bot assigned jakubstec Apr 17, 2026

jakubstec changed the title ~~[Domain Control] [Release 4] Add create group API call and error handling in DomainGroupCreatePage~~ [Domain Control] [Release 4] Add create group button and RHP in DomainGroupsPage Apr 27, 2026

jakubstec added 2 commits April 27, 2026 11:54

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

23f1678

…urity-group-create-group-rhp-form-submit-and-error-handling

minor fixes after resolving merge conflict

d34f2b7

chatgpt-codex-connector Bot reviewed Apr 27, 2026

View reviewed changes

Comment thread src/pages/domain/Groups/DomainGroupsPage.tsx Outdated

jakubstec added 2 commits April 29, 2026 11:14

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

c3581dd

…urity-group-create-group-rhp-form-submit-and-error-handling

fix: eslint and error handling

8d533b7

rayane-d suggested changes May 1, 2026

View reviewed changes

jakubstec added 3 commits May 6, 2026 12:51

Merge remote-tracking branch 'upstream/main' into jakubstec/domains/s…

e6350e8

…ecurity-group-create-group-rhp-form-submit-and-error-handling

fix: add missing API parameter

39ed071

fix: use CREATE_DOMAIN_SECURITY_GROUP API command, add shouldSetAsDef…

5843328

…aultGroup parameter, distinguish pending actions for group deletion and creation

melvin-bot Bot requested review from a team and mountiny and removed request for a team May 7, 2026 18:35

github-actions Bot reviewed May 7, 2026

View reviewed changes

Comment thread src/libs/actions/Domain.ts

fix: lint

6319af5

jakubstec force-pushed the jakubstec/domains/security-group-create-group-rhp-form-submit-and-error-handling branch from 1fd0e65 to 6319af5 Compare May 7, 2026 18:54

trjExpensify previously approved these changes May 7, 2026

View reviewed changes

ZhenjaHorbach reviewed May 8, 2026

View reviewed changes

Comment thread src/libs/actions/Domain.ts

fix: add eslint justification

4040e33

jakubstec dismissed trjExpensify’s stale review via 4040e33 May 8, 2026 10:25

ZhenjaHorbach approved these changes May 8, 2026

View reviewed changes

mountiny requested changes May 8, 2026

View reviewed changes

jakubstec added 3 commits May 11, 2026 17:54

fix: add docs

3e46b2b

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

08451ce

…urity-group-create-group-rhp-form-submit-and-error-handling

Merge remote-tracking branch 'origin/main' into jakubstec/domains/sec…

c6ca325

…urity-group-create-group-rhp-form-submit-and-error-handling

mountiny approved these changes May 12, 2026

View reviewed changes

mountiny merged commit c10769b into Expensify:main May 12, 2026
39 checks passed

OSBotify mentioned this pull request May 13, 2026

Deploy Checklist: New Expensify 2026-05-13 #90410

Closed

82 tasks

melvin-bot Bot mentioned this pull request May 13, 2026

[Due for payment 2026-05-22] [Due for payment 2026-05-20] [Due for payment 2026-05-18] [Domain Control] [Release 4] [FE] Create DomainGroupsPage #80132

Closed

Conversation

jakubstec commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 17, 2026

Uh oh!

jakubstec commented Apr 17, 2026

Uh oh!

jakubstec commented Apr 27, 2026

Uh oh!

codecov Bot commented Apr 27, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

melvin-bot Bot commented May 7, 2026

Uh oh!

github-actions Bot May 7, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-5 (docs)

Uh oh!

mountiny May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

ZhenjaHorbach commented May 8, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

OSBotify commented May 12, 2026

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

OSBotify commented May 13, 2026

Uh oh!

jakubstec commented Apr 17, 2026 •

edited

Loading

codecov Bot commented Apr 27, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented May 8, 2026 •

edited

Loading