fix: checkbox alignment and the padding of last item in onboarding interested features page #87176
Conversation
…sed state and optimizing styles
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Pull request overview
Updates the Onboarding “Interested Features” page layout to keep feature rows (text + checkbox) aligned consistently, including when macOS scrollbar visibility changes affect the available content width.
Changes:
- Removes
ScrollViewwidth measurement (onLayout+widthstate) that was used to compute per-item max width. - Switches feature item sizing to a percentage-based two-column layout on non-small screens to avoid misalignment when scrollbar width changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
|
@abzokhattab PR is ready, please take a look when you have a moment. |
|
Looks fixed to me 👍 |
|
sorry i missed this one ... i will review it today |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-14.at.00.20.21.movAndroid: mWeb ChromeScreen.Recording.2026-04-14.at.00.23.04.moviOS: HybridAppScreen.Recording.2026-04-14.at.00.20.21.moviOS: mWeb SafariScreen.Recording.2026-04-14.at.00.23.04.movMacOS: Chrome / SafariScreen.Recording.2026-04-14.at.00.18.33.mov |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.60-0 🚀
Bundle Size Analysis (Sentry): |
|
This PR is a purely visual/styling fix (checkbox alignment and padding in the onboarding interested features page). It doesn't change any user-facing feature names, flows, or behavior that would require help site documentation updates. No changes needed to |
|
@jponikarchuk issue #88091 is not related to this PR. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀
|
Explanation of Change
Fixed Issues
$ #82910
PROPOSAL: #82910 (comment)
Tests
Offline tests
Same as test
QA Steps
same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.Native.mp4
Android: mWeb Chrome
Android.mWeb.Chrome.mp4
iOS: Native
IOS.Native.mp4
iOS: mWeb Safari
IOS.mWeb.Safari.mp4
MacOS: Chrome / Safari
macOS.Chrome.mp4