Skip to content

fix: default share sheet option to Submit #86507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 5 commits into from
Apr 7, 2026
Merged

fix: default share sheet option to Submit #86507

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d030a02
fix: default share sheet option to Submit
daledah Mar 27, 2026
f183cdf
Merge branch 'main' into fix/81503
daledah Apr 1, 2026
6bbc6fe
reset selected tab
daledah Apr 1, 2026
0bd6820
fix prettier
daledah Apr 1, 2026
d526ae0
Merge branch 'main' into fix/81503
daledah Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/pages/Share/ShareRootPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {shouldValidateFile} from '@libs/ReceiptUtils';
import ShareActionHandler from '@libs/ShareActionHandlerModule';
import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan';
import {close as closeModal} from '@userActions/Modal';
import Tab from '@userActions/Tab';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
Expand Down Expand Up @@ -120,6 +121,9 @@ function ShareRootPage() {
if (tempFile.mimeType) {
if (receiptFileFormats.includes(tempFile.mimeType) && fileExtension) {
setIsFileScannable(true);
// Reset the persisted tab to SUBMIT so that defaultSelectedTab takes effect
// even when a previous Share session left the tab on SHARE.
Tab.setSelectedTab(CONST.TAB.SHARE.NAVIGATOR_ID, CONST.TAB.SHARE.SUBMIT);
} else {
setIsFileScannable(false);
}
Expand Down Expand Up @@ -199,6 +203,7 @@ function ShareRootPage() {
<OnyxTabNavigator
id={CONST.TAB.SHARE.NAVIGATOR_ID}
tabBar={TabSelector}
defaultSelectedTab={CONST.TAB.SHARE.SUBMIT}

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bypass persisted tab state when defaulting to Submit

defaultSelectedTab={CONST.TAB.SHARE.SUBMIT} does not actually make Submit the default once a tab choice is already saved, because OnyxTabNavigator prefers the persisted selectedTab over defaultSelectedTab (validInitialTab in src/libs/Navigation/OnyxTabNavigator.tsx). In practice, users who previously landed on/used SHARE (for example after sharing a non-scannable file where only Share exists) will keep reopening on Share, so this change does not reliably deliver the intended default behavior.

Useful? React with 👍 / 👎.

@eVoloshchak eVoloshchak Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daledah, this is correct, which means this will not be testable on an already existing account. Could you add this to test steps please?

@eVoloshchak eVoloshchak Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, coming back to this, this isn't supposed to work on a new account only. @daledah, could you look at this comment please?

@daledah daledah Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eVoloshchak i updated

lazyLoadEnabled
onTabSelect={onTabSelectFocusHandler}
>
Expand Down
Loading