[CP staging] fix: property override bug in useSearchSelector by mkzie2 · Pull Request #86099 · Expensify/App

mkzie2 · 2026-03-23T13:37:31Z

Explanation of Change

Fixed Issues

$ #86088
$ #86097
PROPOSAL:

Tests

Test 1

Open any chat.
Click + > Assign task.
Enter title > Next.
On confirm page, click Assignee.
Verify that: "Assign to me" section will show own account.

Test 2

Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, click To field.
Verify that: Self DM will be shown in contact list.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test 1

Open any chat.
Click + > Assign task.
Enter title > Next.
On confirm page, click Assignee.
Verify that: "Assign to me" section will show own account.

Test 2

Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, click To field.
Verify that: Self DM will be shown in contact list.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-23.at.21.15.15.mp4

melvin-bot · 2026-03-23T14:13:45Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-03-23T14:15:03Z

@mkzie2
Did you check this?
#86089

Or it's not ours?

mkzie2 · 2026-03-23T14:17:30Z

@ZhenjaHorbach From this proposal I think it's not ours. Also our PR doesn't modify any pagination logics.

ZhenjaHorbach · 2026-03-23T14:18:35Z

@ZhenjaHorbach From this proposal I think it's not ours. Also our PR doesn't modify any pagination logics.

As I remember, we had an issue where the pagination didn't work

#74239

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d845be1c5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-23T14:24:10Z

                    countryCode,
                    reportAttributesDerived: reportAttributesDerived?.reports,
                    allPolicyTags,
+                    ...getValidOptionsConfig,


Prevent self-DM override from surfacing a dead-end option

Placing ...getValidOptionsConfig after the built-in defaults makes MoneyRequestParticipantsSelector's includeSelfDM: true override take effect in the general context. That exposes the Personal/self-DM row in non-split money-request flows, but selecting it is a dead end: toggleSelection() does not persist selections in single-select mode (src/hooks/useSearchSelector.base.ts:403-407), and addSingleParticipant() intentionally skips onFinish() for option.isSelfDM (src/pages/iou/request/MoneyRequestParticipantsSelector.tsx:174-176), so the user stays on the picker with no Next button to continue. This regresses single-participant request/share/send flows whenever the self-DM option is shown.

Useful? React with 👍 / 👎.

We just need to move includeSelfDM to the bottom here below ...getValidOptionsConfig so let's do that 🙏

ZhenjaHorbach · 2026-03-23T15:09:13Z

@mkzie2
Looks like it was confirmed that it is not related to another PR
#86089 (comment)

ZhenjaHorbach · 2026-03-23T15:25:42Z

@mkzie2 Looks like it was confirmed that it is not related to another PR #86089 (comment)

But I think it's not a deploy blocker
So I think we can fix it separately

ZhenjaHorbach · 2026-03-23T15:25:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

2026-03-23.18.22.10.mov

ZhenjaHorbach · 2026-03-23T15:40:49Z

We have incorrectly UI for recent accounts on the accounts list

2026-03-23.16.39.17.mov

On staging

mkzie2 · 2026-03-23T16:29:08Z

@ZhenjaHorbach Do you have a steps to repro this?

ZhenjaHorbach · 2026-03-23T16:31:49Z

@ZhenjaHorbach Do you have a steps to repro this?

Like on the video

Open selfDM report screen
Then open Assign task screen and choose Assignee field
Write a random email and choose it
And reopen Assignee screen

mkzie2 · 2026-03-23T16:37:31Z

@ZhenjaHorbach I can't repro

Screen.Recording.2026-03-23.at.23.36.22.mov

ZhenjaHorbach · 2026-03-23T16:41:12Z

@ZhenjaHorbach I can't repro

Screen.Recording.2026-03-23.at.23.36.22.mov

Did you try with a new account?

mkzie2 · 2026-03-23T16:43:20Z

Did you try with a new account?

Same result.

ZhenjaHorbach · 2026-03-23T17:17:21Z

Did you try with a new account?

Same result.

Interesting
On your branch, I don't have this issue
But I have if I just implement these changes in my main

Could you update the branch to the latest version of main to be sure, please?

ZhenjaHorbach · 2026-03-23T17:29:25Z

Okay
Looks like it's another regression, which is not related to these changes
Since I can reproduce on the last main without our changes

2026-03-23.18.28.41.mov

NikkiWines · 2026-03-23T20:13:51Z

                    countryCode,
                    reportAttributesDerived: reportAttributesDerived?.reports,
                    allPolicyTags,
+                    ...getValidOptionsConfig,


We just need to move includeSelfDM to the bottom here below ...getValidOptionsConfig so let's do that 🙏

mkzie2 · 2026-03-24T04:48:16Z

@NikkiWines I'm not sure I understand your requested changes, the RCA of the issue is that the default includeSelfDM overrides getValidOptionsConfig values so we should place getValidOptionsConfig to the last place, isn't it?

github-actions · 2026-03-24T10:35:38Z

🚧 @NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-24T10:40:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86099.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f66174c-de8080e-4504a39ff5ef6fb7227a26f6bfac2b2c0da65bde/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f66174c-de8080e-efa721b6b5f85ea24ef921f7435ec0e4bcb108c0/index.html

Web 🕸️
https://86099.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-24T10:44:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

(cherry picked from commit f66174c) (cherry-picked to staging by grgia)

OSBotify · 2026-03-24T11:26:23Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.3.42-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-24T11:48:22Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.42-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-25T16:11:23Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.43-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: property override bug in useSearchSelector

d845be1

melvin-bot Bot assigned mkzie2 Mar 23, 2026

mkzie2 mentioned this pull request Mar 23, 2026

[Due for payment 2026-04-01] [Due for payment 2026-03-31] [RCA #75026] Expense - Missing self DM when submitting expense from FAB #86097

Closed

7 tasks

mkzie2 marked this pull request as ready for review March 23, 2026 14:13

mkzie2 requested review from a team as code owners March 23, 2026 14:13

melvin-bot Bot requested review from JmillsExpensify and suneox and removed request for a team and JmillsExpensify March 23, 2026 14:13

melvin-bot Bot removed the request for review from a team March 23, 2026 14:13

mkzie2 mentioned this pull request Mar 23, 2026

[Due for payment 2026-04-01] [Due for payment 2026-03-31] [RCA #75026] Task - "Assign to me" section is missing #86088

Closed

7 tasks

chatgpt-codex-connector Bot reviewed Mar 23, 2026

View reviewed changes

ZhenjaHorbach approved these changes Mar 23, 2026

View reviewed changes

melvin-bot Bot requested a review from NikkiWines March 23, 2026 17:29

NikkiWines requested changes Mar 23, 2026

View reviewed changes

NikkiWines approved these changes Mar 24, 2026

View reviewed changes

NikkiWines merged commit f66174c into Expensify:main Mar 24, 2026
44 checks passed

grgia changed the title ~~fix: property override bug in useSearchSelector~~ [CP staging] fix: property override bug in useSearchSelector Mar 24, 2026

OSBotify pushed a commit that referenced this pull request Mar 24, 2026

Merge pull request #86099 from mkzie2/mkzie2-issue/86088

056771e

(cherry picked from commit f66174c) (cherry-picked to staging by grgia)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 24, 2026

OSBotify mentioned this pull request Mar 24, 2026

Deploy Checklist: New Expensify 2026-03-23 #86080

Closed

70 tasks

OSBotify mentioned this pull request Mar 24, 2026

Deploy Checklist: New Expensify 2026-03-24 #86199

Closed

53 tasks

Beamanator mentioned this pull request Mar 26, 2026

[Due for payment 2026-03-31] [Due for payment 2025-11-13] [Due for payment 2025-11-12] Start chat - Self DM is missing from Recent list if there are more than 5 recent chats #74236

Closed

16 tasks

Conversation

mkzie2 commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1

Test 2

Offline tests

QA Steps

Test 1

Test 2

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiWines Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkzie2 commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026

Uh oh!

mkzie2 commented Mar 23, 2026

Uh oh!

ZhenjaHorbach commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 23, 2026

Uh oh!

NikkiWines Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mkzie2 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

mkzie2 commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

ZhenjaHorbach commented Mar 23, 2026 •

edited

Loading

mkzie2 commented Mar 24, 2026 •

edited

Loading