Implement system message for card freeze and unfreeze actions by ShridharGoel · Pull Request #85016 · Expensify/App

ShridharGoel · 2026-03-12T02:38:39Z

Explanation of Change

Implement system message for card freeze and unfreeze actions

Fixed Issues

$ #84861
PROPOSAL:

Tests

Login as user A (admin)
Go to a workspace with atleast one member (user B) having an Expensify card assigned.
Go to Expensify cards section in the workspace settings.
Go to that card assigned to user B.
Click on "Freeze card".
Login as user B.
Go to the workspace chat.
Ensure system message saying that card has been frozen is present.
Go back to user A's login.
Unfreeze the card.
Check via user B account.
Ensure system message saying that card has been unfrozen is present.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…ze-systemmessage # Conflicts: # src/pages/inbox/report/PureReportActionItem.tsx

melvin-bot · 2026-04-02T21:21:58Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 68bfc12949

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-02T21:30:32Z

+        } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_FROZEN || action.actionName === CONST.REPORT.ACTIONS.TYPE.CARD_UNFROZEN) {
+            children = (
+                <ReportActionItemBasicMessage message="">
+                    <RenderHTML html={`<comment><muted-text>${getReportActionHtml(action)}</muted-text></comment>`} />


Render fallback text for empty card freeze message arrays

This branch renders card freeze/unfreeze actions from getReportActionHtml(action), but that helper only reads the first entry of action.message; when the backend sends these actions with message: [] and only originalMessage.html (the scenario covered by the new tests), this produces an empty <muted-text> block so the visible system message is blank. In practice, users will see an empty action row instead of the freeze/unfreeze notice unless the message array is populated.

Useful? React with 👍 / 👎.

codecov · 2026-04-02T21:59:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.65% <ø> (ø)`
src/pages/inbox/report/PureReportActionItem.tsx	`57.64% <50.00%> (-0.02%)`	⬇️
... and 12 files with indirect coverage changes

Pujan92 · 2026-04-03T08:50:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Pujan92

LGTM!

github-actions · 2026-04-03T10:42:41Z

🚧 @MariaHCD has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-03T10:47:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85016.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0eda3f5-466923a-90cb2553f2833a5dded73cc72fc26cb4a9d017c8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0eda3f5-466923a-c1ddcdd3fc64574fcdaa84040f5bde46e69349a9/index.html

Web 🕸️
https://85016.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-03T10:52:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-07T01:24:04Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.53-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-07T01:30:17Z

Yes, help site changes are needed. The card freeze/unfreeze feature exists in the app but was not documented in any help articles.

I created a draft PR with the required updates: #87193

Changes made across three articles:

Set-Up-and-Manage-the-Expensify-Card.md — Added a "How to freeze or unfreeze an Expensify Card" section with admin instructions, and listed freeze/unfreeze in the card management options
Cardholder-Settings-and-Features.md — Added "Frozen card" as a decline reason in the FAQ
Troubleshoot-Expensify-Card-issues.md — Added an "Expensify Card is frozen" troubleshooting section for cardholders

All button labels (Freeze card, Unfreeze card, Ask to unfreeze, Frozen) match the exact UI text from src/languages/en.ts. The articles follow the naming conventions and authoring guidelines.

Please mark it as "Ready for review" when it is ready for review.

OSBotify · 2026-04-07T01:35:02Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.3.53-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

jponikarchuk · 2026-04-07T04:39:12Z

The issue #87214 is repro on all PRs. Could you please double check if it's not introduced by #85016

OSBotify · 2026-04-07T23:52:41Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ShridharGoel added 2 commits March 10, 2026 23:56

Implement system message for card freeze and unfreeze actions

bd2ca74

Implement system message for card freeze and unfreeze actions

c0fe4f5

melvin-bot Bot assigned ShridharGoel Mar 12, 2026

MariaHCD mentioned this pull request Apr 2, 2026

[Due for payment 2026-04-14] [Freeze Card] Support new CARDFROZEN report action #84861

Closed

Merge branch 'main' of https://github.com/Expensify/App into cardfree…

68bfc12

…ze-systemmessage # Conflicts: # src/pages/inbox/report/PureReportActionItem.tsx

ShridharGoel marked this pull request as ready for review April 2, 2026 21:21

ShridharGoel requested review from a team as code owners April 2, 2026 21:21

melvin-bot Bot requested review from Pujan92 and joekaufmanexpensify and removed request for a team April 2, 2026 21:21

melvin-bot Bot removed the request for review from a team April 2, 2026 21:21

Prettier and cspell update

2761058

chatgpt-codex-connector Bot reviewed Apr 2, 2026

View reviewed changes

Update tests

3446527

Pujan92 approved these changes Apr 3, 2026

View reviewed changes

melvin-bot Bot requested a review from MariaHCD April 3, 2026 09:39

MariaHCD approved these changes Apr 3, 2026

View reviewed changes

MariaHCD merged commit 0eda3f5 into Expensify:main Apr 3, 2026
32 checks passed

OSBotify mentioned this pull request Apr 7, 2026

Deploy Checklist: New Expensify 2026-04-07 #87187

Closed

96 tasks

MelvinBot mentioned this pull request Apr 7, 2026

[No QA] Add help site docs for Expensify Card freeze and unfreeze #87193

Draft

52 tasks

jponikarchuk mentioned this pull request Apr 7, 2026

Web - Workspace - BA - Endless spinner appears after start Plaid flow to connect BA #87214

Closed

7 tasks

Conversation

ShridharGoel commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Pujan92 commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

OSBotify commented Apr 3, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

MelvinBot commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

jponikarchuk commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ShridharGoel commented Mar 12, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited by github-actions Bot

Loading

Pujan92 commented Apr 3, 2026 •

edited

Loading