Fix iOS Live Activity showing old distance unit after workspace settings change by GCyganek · Pull Request #84550 · Expensify/App

GCyganek · 2026-03-09T09:31:08Z

Explanation of Change

The iOS Live Activity for GPS distance tracking stored distanceUnit and distanceUnitLong as ActivityKit attributes, which are immutable after the activity starts. When users changed the distance unit in workspace settings mid-trip, the in-app display correctly reflected the new unit, but the Live Activity in the notification panel / Dynamic Island continued showing the old unit.

This PR moves distanceUnit and distanceUnitLong from GpsTripAttributes (immutable) to GpsTripAttributes.ContentState (updatable), allowing the unit to be dynamically updated when it changes. The Live Activity widget now reads the unit from context.state instead of context.attributes.

Additionally, a new updateGpsTripNotificationUnit function is added that immediately pushes a Live Activity state update when the workspace distance unit setting changes while a GPS trip is active.

Fixed Issues

$ #84518
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13883

Tests

Open the app on iOS
Enable distance rates in a workspace (Workspace > More features > Distance rates)
Go to Workspace settings > Distance rates > Settings > Unit and set it to Miles
Start tracking a GPS distance trip
Verify the Live Activity (notification panel / Dynamic Island) shows "miles"
While the trip is still active, go back to Workspace settings > Distance rates > Settings > Unit
Change the unit to Kilometers
Return to the GPS tracking screen
Verify the in-app display shows "km"
Verify the Live Activity now also shows "kilometers" (not "miles")
Verify the distance value in the Live Activity is correctly converted to the new unit

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS: Native

Screen.Recording.2026-03-09.at.10.10.51.mov

…ngs change

github-actions · 2026-03-09T09:31:16Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

codecov · 2026-03-09T09:39:50Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/components/GPSTripStateChecker/index.native.tsx	`80.00% <ø> (ø)`
.../useUpdateGpsNotificationOnUnitChange/index.ios.ts	`100.00% <100.00%> (ø)`
...cker/useUpdateGpsNotificationOnUnitChange/index.ts	`0.00% <0.00%> (ø)`
src/libs/actions/GPSDraftDetails.ts	`0.00% <0.00%> (ø)`
...tStepDistanceGPS/GPSNotifications/index.android.ts	`0.00% <0.00%> (ø)`
...OURequestStepDistanceGPS/GPSNotifications/index.ts	`0.00% <0.00%> (ø)`
...questStepDistanceGPS/GPSNotifications/index.ios.ts	`17.54% <16.12%> (+0.40%)`	⬆️
... and 13 files with indirect coverage changes

melvin-bot · 2026-03-09T09:41:03Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6589bf6d06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mjasikowski · 2026-03-09T10:09:55Z

@GCyganek can you address the AI comments?

GCyganek · 2026-03-09T10:25:23Z

@GCyganek can you address the AI comments?

On it EDIT: ready

…vity

trjExpensify · 2026-03-09T14:13:05Z

@dukenv0307 should review this PR right as it's from the Live activity PR?

dukenv0307 · 2026-03-09T14:17:58Z

@trjExpensify I'll review it

dukenv0307 · 2026-03-09T15:54:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-09.at.22.51.27.mov

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

luacmartins · 2026-03-09T16:15:14Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8cfe5e5c31

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

OSBotify · 2026-03-09T16:43:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-09T17:04:14Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-09T17:10:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84550.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2879146-9fb5216-f428a5a5f59aa0b49417b7702ab39c96b74d84a2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2879146-9fb5216-33f6cfd34d6e59a182d1a2bd441e618059c2071c/index.html

Web 🕸️
https://84550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…date-distance-unit-live-activity Fix iOS Live Activity showing old distance unit after workspace settings change (cherry picked from commit 2879146) (cherry-picked to staging by luacmartins)

OSBotify · 2026-03-09T19:17:59Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

m-natarajan · 2026-03-09T19:46:13Z

Fixed in iPhone13/26.3.1, v9.3.33-5

ScreenRecording_03-09-2026.15-38-22_1.MP4

OSBotify · 2026-03-09T20:39:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-09T21:28:25Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-10T18:50:31Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.34-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix iOS Live Activity showing old distance unit after workspace setti…

6589bf6

…ngs change

melvin-bot Bot assigned GCyganek Mar 9, 2026

GCyganek marked this pull request as ready for review March 9, 2026 09:40

GCyganek requested review from a team as code owners March 9, 2026 09:40

melvin-bot Bot requested review from JmillsExpensify and parasharrajat and removed request for a team and JmillsExpensify March 9, 2026 09:41

melvin-bot Bot removed the request for review from a team March 9, 2026 09:41

github-actions Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.android.ts

github-actions Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.android.ts

github-actions Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.ts

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx Outdated

GCyganek added 3 commits March 9, 2026 12:32

Fix distance unit update

c565774

Merge branch 'main' into @GCyganek/gps/update-distance-unit-live-acti…

8f4a27c

…vity

make hook iOS only

8cfe5e5

AndrewGable requested review from dukenv0307 and removed request for parasharrajat March 9, 2026 15:36

dukenv0307 approved these changes Mar 9, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski March 9, 2026 15:54

AndrewGable approved these changes Mar 9, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread src/components/GPSTripStateChecker/useUpdateGpsNotificationOnUnitChange/index.ios.ts

AndrewGable merged commit 2879146 into Expensify:main Mar 9, 2026
39 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 9, 2026

OSBotify mentioned this pull request Mar 9, 2026

Deploy Checklist: New Expensify 2026-03-06 #84466

Closed

52 tasks

Conversation

GCyganek commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

codecov Bot commented Mar 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

mjasikowski commented Mar 9, 2026

Uh oh!

GCyganek commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Mar 9, 2026

Uh oh!

dukenv0307 commented Mar 9, 2026

Uh oh!

dukenv0307 commented Mar 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Mar 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

github-actions Bot commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

m-natarajan commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 9, 2026

Uh oh!

OSBotify commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GCyganek commented Mar 9, 2026 •

edited

Loading

codecov Bot commented Mar 9, 2026 •

edited by github-actions Bot

Loading

GCyganek commented Mar 9, 2026 •

edited

Loading