Skip to content

Fix: Copying / pasting code between < and /> #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 2 commits into from
Apr 8, 2022
Merged

Fix: Copying / pasting code between < and /> #8449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d068ec6
Update index.js
gladiator-1 Mar 30, 2022
37b191b
Merge branch 'Expensify:main' into main
gladiator-1 Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libs/SelectionScraper/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import ExpensiMark from 'expensify-common/lib/ExpensiMark';
import {parseDocument} from 'htmlparser2';
import {Element} from 'domhandler';
import _ from 'underscore';
import Str from 'expensify-common/lib/str';

const elementsWillBeSkipped = ['html', 'body'];
const tagAttribute = 'data-testid';
Expand Down Expand Up @@ -88,6 +89,11 @@ const replaceNodes = (dom) => {
let domChildren;
const domAttribs = {};

// Encoding HTML chars '< >' in the text, because any HTML will be removed in stripHTML method.

@parasharrajat parasharrajat Apr 2, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Encoding HTML chars '< >' in the text, because any HTML will be removed in stripHTML method.

Not needed.

@gladiator-1 gladiator-1 Apr 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

if (dom.type === 'text') {
dom.setAttribute('data', Str.htmlEncode(dom.data));
}

@marcaaron marcaaron Apr 8, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think this actually could use a code comment to explain why we are html encoding. It's not really clear.

@gladiator-1 gladiator-1 Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


// We are skipping elements which has html and body in data-testid, since ExpensiMark can't parse it. Also this data
// has no meaning for us.
if (dom.attribs && dom.attribs[tagAttribute]) {
Expand Down