Fix - Uploading Mp4 Videos Removes 'Attachment' Tag

[dennismunene]

Details

Fixed Issues

$ #8331

Tests

1. Open Expensify App and log in with any account
2. Click to add attachment
3. Select mp4 video and tap Send
4. Refresh the page

PR Review Checklist

Contributor (PR Author) Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose and it is
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• [] I verified tests pass on all platforms & I tested again on:
  • [] iOS / native
  • [] Android / native
  • [] iOS / Safari
  • [] Android / Chrome
  • [] MacOS / Chrome
  • [] MacOS / Desktop
• [] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• [] I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• [] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

##Expected Result

• [Attachment] Tag should be shown for all attachment types.
• Links should not be shown as attachments

LHN - Left Hand Navigation

To test these changes on all platforms please follow these steps

Testing File uploads (Images,PDF,Audio,Video)

1. Open Expensify App and log in with any account
2. Click to add attachment
3. Select any to upload File e.g (Mp4 video) and tap Send
4. This should show up on the LHN as [Attachment] instead of showing the filename
5. Refresh the page (on mobile go back to chats page)
6. Attachments should still show as [Attachment] on the LHN

Testing Links

1. Open Expensify App and log in with any account
2. Navigate to any chat
3. Copy paste/ Type in any link e.g https://google.com in the textbox and hit send
4. This should show up on the LHN as a link https://google.com and not as an Attachment
5. Refresh the page (on mobile go back to chats page)
6. Links should still show as links on the LHN

This should work on all platforms & for all attachments.

• Verify that attachment tag is shown for all file uploads even after page refresh
• Verify that links are not shown as attachments
• Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-03-31.at.14.58.14.mov

Mobile Web

expensify-safari.mov

Desktop

expensify-desktop.mov

iOS

expensify-ios.mov

Android

expensify-android-chrome.mov

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[parasharrajat]

Please correct the commit errors and all commits need to sign. Follow Contributor (PR Author) Checklist for code changes.

[dennismunene]

I have read the CLA Document and I hereby sign the CLA

[dennismunene]

@parasharrajat fixed commit errors

[marcaaron]

I think we missed what the original issue is asking for here.

[parasharrajat]

Missing QA steps.

[mountiny]

I think the expected results should be to always show [Attachment] for any type of upload to unify it for now and remove the inconsistency. I think we understood each other despite the misleading issue expected results section somehow 😄

[parasharrajat]

I think QA steps can be improved.
5. Refresh the page, => What will happen on refreshing the page. What should we check? What should be checked before refreshing the page?

Please try to be detailed as much as possible. QA steps should cover success and failure both.

• Add another step to test each type of attachment (image, Video, PDF, Audio).
• Mention testing on all platforms.
• Add a step to test links specifically.

[mountiny]

@dennismunene Can you please try to comment this again? Thank you
I have read the CLA Document and I hereby sign the CLA

[parasharrajat]

LGTM.

cc: @mountiny

PR Reviewer Checklist

• I verified the PR has a small number of commits behind main
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the testing environment is mentioned in the test steps
• I verified testing steps cover success & fail scenarios (if applicable)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors related to changes in this PR
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified comments were added when the code was not self explanatory
  • I verified any copy / text shown in the product was added in all src/languages/* files (if applicable)
  • I verified proper naming convention for platform-specific files was followed (if applicable)
  • I verified style guidelines were followed
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components are not impacted by changes in this PR (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified the UI performance was not affected (the performance is the same than main branch)
• If a new component is created I verified that a similar component doesn't exist in the codebase

🎀 👀 🎀 C+ reviewed

[parasharrajat]

Please improve QA steps #8438 (comment)

[marcaaron]

I think we understood each other despite the misleading issue expected results section somehow 😄

Let's update the original issue then?

[marcaaron]

Oh sorry I saw you did. Thanks!

[dennismunene]

I have read the CLA Document and I hereby sign the CLA

[mountiny]

LGTM! Congratulations to the first PR @dennismunene! Great job on this one!

Thank you @parasharrajat for the review!

[mountiny]

@dennismunene In terms of the refactor, there are not many occurrences of the data-expensify-source in the codebase, so would you be able to create a simple PR that will substitute them for the CONST and link it to the original issue here?

Thank you very much for your work here, I hope to see many more PRs from you since the work you have done here has been very professional 🙇 🙌

[mountiny]

@marcaaron Will you be able to approve and merge if you are happy with this one? Thank you very much! (dont want to dismiss your request for changes 😄 )

[dennismunene]

@mountiny Thank you. I've had a great experience working on this , I will definitely be raising more PR's in future 🙂

The requested changes has been addressed

[mountiny]

I will be mean and go ahead and dismiss the review as the requested change has been addressed! Thank you very much for chiming in @marcaaron, @dennismunene will follow up with a refactor to address the other mentions of data-expensify-source!

[mountiny]

@dennismunene Very glad to hear this 🙌

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[dennismunene]

I will be mean and go ahead and dismiss the review as the requested change has been addressed! Thank you very much for chiming in @marcaaron, @dennismunene will follow up with a refactor to address the other mentions of data-expensify-source!

@mountiny @marcaaron Added the Refactor PR #8539

[OSBotify]

🚀 Deployed to staging by @mountiny in version: 1.1.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.54-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅