Skip to content

Skip amount conversion for recent searches in SearchRouter #84295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 2 commits into from
Mar 6, 2026
Merged

Skip amount conversion for recent searches in SearchRouter #84295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66aaaf3
Fix double amount conversion when selecting recent searches
MelvinBot Mar 5, 2026
9c680d5
Extract findItem string to CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_…
MelvinBot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7554,6 +7554,7 @@ const CONST = {
CONTEXTUAL_SUGGESTION: 'contextualSuggestion',
AUTOCOMPLETE_SUGGESTION: 'autocompleteSuggestion',
SEARCH: 'searchItem',
FIND_ITEM: 'findItem',
},
SEARCH_USER_FRIENDLY_KEYS: {
TYPE: 'type',
Expand Down
4 changes: 2 additions & 2 deletions src/components/Search/SearchPageHeader/SearchPageHeaderInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
setAutocompleteSubstitutions(substitutions);
}
} else if (item.searchItemType === CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.SEARCH) {
submitSearch(item.searchQuery, item.keyForList !== 'findItem');
submitSearch(item.searchQuery, item.keyForList !== CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_ITEM);
}
} else if (item?.reportID) {
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(item?.reportID));
Expand All @@ -255,7 +255,7 @@ function SearchPageHeaderInput({queryJSON, searchRouterListVisible, hideSearchRo
singleIcon: expensifyIcons.MagnifyingGlass,
searchQuery: textInputValue,
itemStyle: styles.activeComponentBG,
keyForList: 'findItem',
keyForList: CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_ITEM,
searchItemType: CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.SEARCH,
}
: undefined,
Expand Down
8 changes: 4 additions & 4 deletions src/components/Search/SearchRouter/SearchRouter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla
singleIcon: expensifyIcons.MagnifyingGlass,
searchQuery: textInputValue,
itemStyle: styles.activeComponentBG,
keyForList: 'findItem',
keyForList: CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_ITEM,
searchItemType: CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.SEARCH,
}
: undefined;
Expand Down Expand Up @@ -217,9 +217,9 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla
);

const submitSearch = useCallback(
(queryString: SearchQueryString) => {
(queryString: SearchQueryString, shouldSkipAmountConversion = false) => {
const queryWithSubstitutions = getQueryWithSubstitutions(queryString, autocompleteSubstitutions);
const updatedQuery = getQueryWithUpdatedValues(queryWithSubstitutions);
const updatedQuery = getQueryWithUpdatedValues(queryWithSubstitutions, shouldSkipAmountConversion);
if (!updatedQuery) {
return;
}
Expand Down Expand Up @@ -282,7 +282,7 @@ function SearchRouter({onRouterClose, shouldHideInputCaret, isSearchRouterDispla
}
setFocusAndScrollToRight();
} else {
submitSearch(item.searchQuery);
submitSearch(item.searchQuery, item.keyForList !== CONST.SEARCH.SEARCH_ROUTER_ITEM_TYPE.FIND_ITEM);
}
} else {
backHistory(() => {
Expand Down
Loading