[PERF] - Use lighter avatar component in Report Item Row#84284
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
luacmartins
left a comment
There was a problem hiding this comment.
Code is looking good!
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR doesn’t have any new product considerations as a performance PR Unassigning and unsubscribing myself. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-03-06.at.18.52.18.movAndroid: mWeb ChromeScreen.Recording.2026-03-06.at.18.49.01.moviOS: HybridAppScreen.Recording.2026-03-06.at.18.45.21.moviOS: mWeb SafariScreen.Recording.2026-03-06.at.18.46.32.movMacOS: Chrome / SafariScreen.Recording.2026-03-06.at.18.39.49.mov |
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.33-0 🚀
|
|
Deploy Blocker #84472 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀
|
|
|
||
| const {totalDisplaySpend, nonReimbursableSpend, reimbursableSpend} = getMoneyRequestSpendBreakdown(reportItem); | ||
| const reportIsArchived = isArchivedReport(getReportNameValuePairsFromKey(data, reportItem)); | ||
| const avatarProps = getSearchReportAvatarProps(reportItem, formatPhoneNumber, data.personalDetailsList ?? {}, policy, reportIsArchived); |
There was a problem hiding this comment.
This line caused #84472: the new SearchReportAvatar component replaced ReportActionAvatars, which internally reads from Onyx's live PERSONAL_DETAILS_LIST. By only using data.personalDetailsList from the search API response, custom user avatars are lost when the API doesn't include the report owner's personal details (e.g., for newly created accounts), falling back to the default silhouette. Fixed in #84599 by merging the Onyx PERSONAL_DETAILS_LIST as a fallback: {...onyxPersonalDetailsList, ...data.personalDetailsList}.
Explanation of Change
Fixed Issues
$ #82428
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos