Skip to content

Fix (telemetry): guard __moduleInitTimes access to prevent ReferenceError #84265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Mar 5, 2026
+7 −2
Merged

Fix (telemetry): guard __moduleInitTimes access to prevent ReferenceError #84265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5610875
add typeguard safety
elirangoshen Mar 4, 2026
681c244
adding safeguard to native
elirangoshen Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/setup/telemetry/index.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ export default function (): void {
});

requestAnimationFrame(() => {
reportModuleInitTimes(__moduleInitTimes as Record<string, number> | undefined, __moduleNames as Record<string, string> | undefined, 100);
// Use typeof guard — bare identifier throws ReferenceError if moduleInitPolyfill didn't run
const initTimes = typeof __moduleInitTimes !== 'undefined' ? (__moduleInitTimes as Record<string, number>) : undefined;
const moduleNames = typeof __moduleNames !== 'undefined' ? (__moduleNames as Record<string, string>) : undefined;
reportModuleInitTimes(initTimes, moduleNames, 100);
});
}
4 changes: 3 additions & 1 deletion src/setup/telemetry/index.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ export default function (): void {
requestAnimationFrame(() => {
// webpack module timing path (ModuleInitTimingPlugin injected __moduleInitTimes).
// In dev mode, keys are relative file paths; in production they are numeric IDs.
reportModuleInitTimes(__moduleInitTimes as Record<string, number> | undefined, undefined, 1);
// Use typeof guard — bare identifier throws ReferenceError if ModuleInitTimingPlugin didn't run (e.g. Storybook, stale cache)
const initTimes = typeof __moduleInitTimes !== 'undefined' ? (__moduleInitTimes as Record<string, number>) : undefined;
reportModuleInitTimes(initTimes, undefined, 1);
});
}
Loading