Skip to content

[No QA] Log duration for Sentry end spans #83495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Feb 26, 2026
Merged

[No QA] Log duration for Sentry end spans #83495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fa075a
log duration for sentry spans
marcaaron Feb 25, 2026
7e2a76d
Use span.start_timestamp instead of tracking separate startTime
marcaaron Feb 26, 2026
0705831
Merge remote-tracking branch 'origin/main' into marcaaron-fixSentryDe…
marcaaron Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/libs/telemetry/activeSpans.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type {StartSpanOptions} from '@sentry/core';
import * as Sentry from '@sentry/react-native';
import {spanToJSON} from '@sentry/react-native';
import Log from '@libs/Log';
import CONST from '@src/CONST';

Expand Down Expand Up @@ -39,7 +40,10 @@ function endSpan(spanId: string) {
Log.info(`[Sentry][${spanId}] Trying to end span but it does not exist`, undefined, {spanId, timestamp: Date.now()});
return;
}
Log.info(`[Sentry][${spanId}] Ending span`, undefined, {spanId, timestamp: Date.now()});
const now = Date.now();
const startTimestamp = spanToJSON(span).start_timestamp;
const durationMs = Math.round(now - startTimestamp * 1000);
Log.info(`[Sentry][${spanId}] Ending span (${durationMs}ms)`, undefined, {spanId, durationMs, timestamp: now});
span.setStatus({code: 1});
span.setAttribute(CONST.TELEMETRY.ATTRIBUTE_FINISHED_MANUALLY, true);
span.end();
Expand All @@ -52,10 +56,10 @@ function cancelSpan(spanId: string) {
return;
}
Log.info(`[Sentry][${spanId}] Canceling span`, undefined, {spanId, timestamp: Date.now()});
span?.setAttribute(CONST.TELEMETRY.ATTRIBUTE_CANCELED, true);
span.setAttribute(CONST.TELEMETRY.ATTRIBUTE_CANCELED, true);
// In Sentry there are only OK or ERROR status codes.
// We treat canceled spans as OK, so we can properly track spans that are not finished at all (their status would be different)
span?.setStatus({code: 1});
span.setStatus({code: 1});
endSpan(spanId);
}

Expand Down
Loading