Add Copy button to AI summary on help docs search by rushatgabhane · Pull Request #82947 · Expensify/App

rushatgabhane · 2026-02-19T15:25:38Z

Explanation of Change

Added a Copy button to the Concierge AI summary panel that copies the response as markdown

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/599634
PROPOSAL:

Tests

Go to help.expensify.com,
search for something
verify you see copy button
click it and paste the contents in new dot.
verify that you get correct formatting of the markdown and links

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to help.expensify.com and follow the tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Details

Screen.Recording.2026-02-19.at.16.22.38.mov

melvin-bot · 2026-02-19T15:26:04Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2026-02-19T15:27:26Z

-                } catch {
-                    return null;
+
+if (window.location.pathname.includes('/search')) {


only change here is, loading the allowedExternalUrls only on search page

rushatgabhane · 2026-02-19T15:28:57Z

@MelvinBot fix svg compression please

melvin-bot · 2026-02-19T15:29:13Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2026-02-19T15:29:55Z

@ahmedGaber93 all yours

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

MelvinBot · 2026-02-19T15:31:39Z

Compressed the SVG assets (copy.svg and copy-dark.svg) — both reduced by ~34% (0.76 KB → 0.50 KB each).

shawnborton · 2026-02-19T15:37:08Z

Should the copy button have some feedback like it does in product?

CleanShot.2026-02-19.at.16.36.57.mp4

rushatgabhane · 2026-02-26T02:45:55Z

will get back to this later this week

rushatgabhane · 2026-03-06T00:29:08Z

didn't get time yet

rushatgabhane · 2026-03-06T00:29:39Z

Let me ask melvin

@MelvinBot can you fix the pending tasks for this PR please

…h 12x12 icons Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

MelvinBot · 2026-03-06T00:42:09Z

Addressed the pending tasks:

Replaced copy/checkmark SVGs with product icons — The docs SVGs now use the same path data as the App product icons (assets/images/copy.svg and assets/images/checkmark.svg), which fill the full 20×20 viewBox. Previously the docs icons had extra padding within the viewBox, making them appear smaller.
Adjusted button/icon sizing — Updated CSS to 28×28 button with 12×12 icons, per the design feedback from shawnborton.
Fixed Prettier check — Ran npm run prettier to format files that had drifted from the expected formatting.

ahmedGaber93 · 2026-03-07T23:19:48Z

Result looks good.

20260308011935312.mp4

ahmedGaber93 · 2026-03-07T23:21:16Z

@rushatgabhane @MelvinBot, aren't the files checkmark.svg and checkmark-dark.svg identical?

MelvinBot · 2026-03-07T23:22:38Z

Yes, checkmark.svg and checkmark-dark.svg are identical — both use fill="#03d47c" (green). The checkmark is a success indicator that stays the same color regardless of the color scheme, unlike the copy icon which uses different grays for light (#a2a9a3) and dark (#8b9c8f) modes.

Having separate files keeps the pattern consistent with the copy icon's light/dark variants, but if you'd prefer, one could be removed and the same file reused for both schemes. rushatgabhane — what's your preference?

ahmedGaber93 · 2026-03-07T23:25:11Z

The checkmark is a success indicator that stays the same color regardless of the color scheme

Having separate files keeps the pattern consistent with the copy icon's light/dark variants

That makes sense.

ahmedGaber93 · 2026-03-07T23:37:00Z

@rushatgabhane @MelvinBot this commit that fixed the Prettier check changes many files that are not related to this PR. I think we should avoid including those changes here to keep the PR simpler and focused.

MelvinBot · 2026-03-07T23:38:18Z

Good catch — you're right. The prettier commit touched many unrelated files because this branch is significantly behind main. Those files had formatting drift that prettier flagged, but they shouldn't be part of this PR's diff.

The better approach would be to:

Revert the prettier commit (783a975)
Merge main into the branch — this will bring all those files up to date with their already-formatted versions on main
The prettier check should then pass without needing to format unrelated files

rushatgabhane — would you like me to handle this? You'd need to add me as a PR assignee first so I can push to the branch.

ahmedGaber93

LGTM! Just a small comment that needs to be addressed #82947 (comment) CC @rushatgabhane

rushatgabhane · 2026-03-07T23:50:55Z

@MelvinBot merge main and fix conflicts

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com> # Conflicts: # src/components/FrozenCardHeader.tsx # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/MoneyRequestConfirmationListFooter.tsx # src/components/MultifactorAuthentication/Context/stateReducer.ts # src/components/ReportActionItem/MoneyRequestReceiptView.tsx # src/components/ReportActionItem/MoneyRequestView.tsx # src/components/VideoPlayer/BaseVideoPlayer.tsx # src/hooks/useReceiptScanDrop.tsx # src/libs/CardUtils.ts # src/libs/Navigation/helpers/getAdaptedStateFromPath.ts # src/pages/iou/request/step/IOURequestStepScan/index.native.tsx # src/pages/iou/request/step/IOURequestStepScan/index.tsx # src/pages/settings/Profile/CustomStatus/VacationDelegatePage.tsx

MelvinBot · 2026-03-07T23:57:03Z

Merged main into the branch and resolved all 13 conflicts. All conflicting files were in src/ (not part of this PR's docs changes) — they were caused by the earlier prettier formatting commit colliding with main updates. Resolved by accepting main's version for all of them.

ahmedGaber93 · 2026-03-08T00:10:10Z

@rushatgabhane I think we need to assign an internal engineer to merge this.

ahmedGaber93 · 2026-03-12T22:58:18Z

Asking on Slack for an internal engineer to review and merge this PR.
https://expensify.slack.com/archives/C02NK2DQWUX/p1773356205222769

melvin-bot · 2026-03-17T20:24:09Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

RachCHopkins · 2026-03-23T20:08:28Z

@aldo-expensify would you mind reviewing this please?

OSBotify · 2026-03-24T12:13:21Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.3.43-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-25T16:09:23Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.43-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

rushatgabhane added 8 commits February 19, 2026 16:21

add ai copy button with light and dark icons

55b1745

add ai copy button with dark mode icons

b7ea65f

add inline svg icon circular bg with glyph

a9ee2d2

add inline svg icon with circle bg

c7f6693

switch to local proxy apis and filter search links

ca60ce0

init turndownservice and add clipboard copy

74122c4

wire up ai copy button click handler

81a6bc5

add turndown script from unpkg

ed876de

melvin-bot Bot assigned rushatgabhane Feb 19, 2026

rushatgabhane marked this pull request as ready for review February 19, 2026 15:25

rushatgabhane requested review from a team as code owners February 19, 2026 15:25

update api urls to expensify prod endpoints

172eef8

melvin-bot Bot requested review from ahmedGaber93 and heyjennahay and removed request for a team February 19, 2026 15:26

rushatgabhane commented Feb 19, 2026

View reviewed changes

rushatgabhane requested a review from a team February 19, 2026 15:29

melvin-bot Bot requested review from mananjadhav and removed request for a team February 19, 2026 15:29

rushatgabhane removed the request for review from mananjadhav February 19, 2026 15:29

Compress SVG assets (copy.svg, copy-dark.svg)

ddd5b97

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

MelvinBot and others added 2 commits March 6, 2026 00:41

Use product copy/checkmark SVGs and adjust button sizing to 28x28 wit…

3cc1cbb

…h 12x12 icons Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

Run prettier to fix formatting check

783a975

Co-authored-by: Rushat Gabhane <rushatgabhane@users.noreply.github.com>

ahmedGaber93 approved these changes Mar 7, 2026

View reviewed changes

garrettmknight requested a review from a team March 17, 2026 20:24

melvin-bot Bot requested review from bernhardoj and removed request for a team March 17, 2026 20:24

garrettmknight removed the request for review from bernhardoj March 17, 2026 20:24

RachCHopkins requested a review from aldo-expensify March 23, 2026 20:08

aldo-expensify approved these changes Mar 23, 2026

View reviewed changes

aldo-expensify merged commit 9b9fbba into Expensify:main Mar 23, 2026
30 checks passed

OSBotify mentioned this pull request Mar 24, 2026

Deploy Checklist: New Expensify 2026-03-24 #86199

Closed

53 tasks

Conversation

rushatgabhane commented Feb 19, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 19, 2026

Uh oh!

rushatgabhane Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Feb 19, 2026

Uh oh!

melvin-bot Bot commented Feb 19, 2026

Uh oh!

rushatgabhane commented Feb 19, 2026

Uh oh!

MelvinBot commented Feb 19, 2026

Uh oh!

shawnborton commented Feb 19, 2026

Uh oh!

rushatgabhane commented Feb 26, 2026

Uh oh!

rushatgabhane commented Mar 6, 2026

Uh oh!

rushatgabhane commented Mar 6, 2026

Uh oh!

MelvinBot commented Mar 6, 2026

Uh oh!

ahmedGaber93 commented Mar 7, 2026

Uh oh!

ahmedGaber93 commented Mar 7, 2026

Uh oh!

MelvinBot commented Mar 7, 2026

Uh oh!

ahmedGaber93 commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 commented Mar 7, 2026

Uh oh!

MelvinBot commented Mar 7, 2026

Uh oh!

ahmedGaber93 left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Mar 7, 2026

Uh oh!

MelvinBot commented Mar 7, 2026

Uh oh!

ahmedGaber93 commented Mar 8, 2026

Uh oh!

ahmedGaber93 commented Mar 12, 2026

Uh oh!

melvin-bot Bot commented Mar 17, 2026

Uh oh!

RachCHopkins commented Mar 23, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ahmedGaber93 commented Mar 7, 2026 •

edited

Loading