Skip to content

[NoQA] Feature: Travel Invoicing - Release 2.5: Export Travel Invoice Statement (CSV/PDF)#82306

Merged
blimpich merged 51 commits into
Expensify:mainfrom
ikevin127:ikevin127-travel-invoicing-25
Mar 6, 2026
Merged

[NoQA] Feature: Travel Invoicing - Release 2.5: Export Travel Invoice Statement (CSV/PDF)#82306
blimpich merged 51 commits into
Expensify:mainfrom
ikevin127:ikevin127-travel-invoicing-25

Conversation

@ikevin127

@ikevin127 ikevin127 commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

UX Flow

  • On the Travel Invoicing section’s header or within the summary card, we show an “Export” control:
    • Either a button or a kebab/overflow icon (matching the card statement export pattern).
  • Tapping it opens a small action sheet / popover with:
    • “Download CSV”
    • “Download PDF”
  • After selection:
    • We call the Travel Invoicing statement action.
    • Once the file URL is returned, we trigger a download using the existing statement download helper used by Expensify Card.

Data & Onyx
We pass the following parameters to the getTravelInvoiceStatement() method:

  • policyID
  • Statement period (if applicable; could default to “current cycle”)
  • Format: 'csv' | 'pdf'

Actions
In src/libs/actions/TravelInvoicing.ts:

  • getTravelInvoiceStatement({policyID, period, format}):
    • Wraps GetTravelInvoicingPayments.
    • On success, passes the returned URL/Blob to the existing card statement download helper.
    • On error, shows a localized toast.

Components & reuse
Reuse the same export UX pattern as Expensify Card’s statement export:

  • Reusing existing “Download CSV/PDF” menu and file‑download helper, but wired to this new action.

Testing
Component tests:

  • Tapping “Download CSV” / “Download PDF” calls getTravelInvoiceStatement with the correct format.

Figma design:

Fixed Issues

$ #78677
PROPOSAL:

Tests

Preconditions:

  • Must be on an account that has Travel Invoicing beta enabled and Travel configured.
  1. Navigate to Workspace > Travel.
  2. Press on the Export button.
  3. Verify that a date modifier RHP page opens with This month selected by default.
  4. Once your dates are selected, press either Export as PDF / Export as CVS and verify that the export file is downloaded and contains either valid data if the account has any transaction statements or is empty otherwise.

Note: To actually get valid data, must be on Ben's ngrok, details here in Slack 🧵.

  • Verify that no errors appear in the JS console

Offline tests

N/A - D - Full Page Blocking - Requires fresh server data

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: HybridApp
android-empty.mp4
Android: mWeb Chrome
android-mweb.mp4
iOS: HybridApp
native.mp4
iOS: mWeb Safari
ios-mweb.MP4
MacOS: Chrome / Safari
web.mov

OFFLINE:

Screenshot 2026-02-12 at 11 19 00

@ikevin127 ikevin127 requested review from a team as code owners February 12, 2026 19:20
@melvin-bot melvin-bot Bot requested a review from parasharrajat February 12, 2026 19:20
@melvin-bot

melvin-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot melvin-bot Bot requested review from heyjennahay and removed request for a team February 12, 2026 19:20
@melvin-bot

melvin-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot requested review from a team and blimpich and removed request for a team February 12, 2026 19:20
@melvin-bot

melvin-bot Bot commented Feb 12, 2026

Copy link
Copy Markdown

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread src/libs/actions/TravelInvoicing.ts Outdated
Comment thread src/pages/workspace/travel/WorkspaceTravelInvoicingExportPage.tsx Outdated
Comment thread src/types/onyx/ExpensifyCardSettings.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01fb4ee3d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/TravelInvoicing.ts Outdated
@codecov

codecov Bot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.30% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 75.00% <ø> (ø)
src/libs/SearchUIUtils.ts 69.18% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx 7.34% <0.00%> (-0.02%) ⬇️
src/libs/localFileDownload/index.ios.ts 16.66% <33.33%> (+16.66%) ⬆️
src/ROUTES.ts 15.23% <0.00%> (-0.11%) ⬇️
... and 13 more
... and 110 files with indirect coverage changes

@blimpich blimpich removed the request for review from heyjennahay February 12, 2026 20:18
@blimpich

blimpich commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

@ikevin127

ikevin127 commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

✅ Applied the patch, still wasn't able to download as the ngrok was probably offline for the provided accounts:

  • ti@test26.com (account with existing travel invoicing statement transactions)
  • ti@test27.com (account without transactions - for the empty case)

Will try again tomorrow within the working hours.


❌ ESLint not related to this PRs changes.

@blimpich

blimpich commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Empty case seems to work on ti@test27.com.

Non-empty case is weird. User is ti@test26.com on my local. PDF export works but:

  • toggle isn't on, maybe merge main will fix it?
  • csv export shows nothing, maybe caching issue? Lets maybe not cache if we are right now?
apple.mov
orange.mov

@ikevin127 @parasharrajat Are you able to reproduce these issues using my ngrok?

@ikevin127

Copy link
Copy Markdown
Contributor Author

✅ Completed tests on all platforms / updated PR Author Checklist. Testing should work now on both Ben's ngrok (will get actual results) and without ngrok (as long as you have a private domain account with BA added and Travel Invoicing beta / feature enabled - the exports will be empty).

@parasharrajat 🟢 Ready for final review

blimpich
blimpich previously approved these changes Mar 5, 2026

@blimpich blimpich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well. Nice job! @parasharrajat @rlinoz I defer to you.

@parasharrajat

Copy link
Copy Markdown
Member

Checking again.

@parasharrajat

parasharrajat commented Mar 6, 2026

Copy link
Copy Markdown
Member

Screenshots

🔲 iOS / native

06.03.2026_18.22.28_REC.mp4

🔲 iOS / Safari

06.03.2026_18.23.49_REC.mp4

🔲 MacOS / Chrome

03.03.2026_14.02.12_REC.mp4

🔲 Android / native

06.03.2026_18.34.11_REC.mp4

@parasharrajat

parasharrajat commented Mar 6, 2026

Copy link
Copy Markdown
Member

BUG: Noticed that there is no header on the export page while we are offline. No way for the user to close this page.

image

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@parasharrajat

Copy link
Copy Markdown
Member

Waiting on this #82306 (comment) before I can approve but rest looks good to me.

@ikevin127

Copy link
Copy Markdown
Contributor Author

BUG: Noticed that there is no header on the export page while we are offline. No way for the user to close this page.

@parasharrajat ✅ Fixed in latest commit

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely.

image

@melvin-bot melvin-bot Bot requested a review from blimpich March 6, 2026 16:54
@parasharrajat

Copy link
Copy Markdown
Member

All set @blimpich @rlinoz

@blimpich blimpich merged commit a0377aa into Expensify:main Mar 6, 2026
34 checks passed
@OSBotify

OSBotify commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.33-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants