Fix PDF receipts not loading when receipt.source is missing by jnowakow · Pull Request #81960 · Expensify/App

jnowakow · 2026-02-10T10:28:47Z

Explanation of Change

This is copy of Melvin's PR with additional commit that extracts receipts URL to config. Below is Melivn's description.

When receipts are added via email forwarding or Expensify billing, the backend sometimes provides receipt.filename without populating receipt.source. The getThumbnailAndImageURIs function in ReceiptUtils.ts returns an empty string for the image path when source is missing, causing the PDF viewer to receive a blank URL and display nothing.

This fix adds a fallback in getThumbnailAndImageURIs: when receipt.source is missing but receipt.filename exists, construct the URL as https://www.expensify.com/receipts/{filename}. This is the same workaround already used in MergeTransactionUtils.ts:fillMissingReceiptSource, but applied at the general receipt utility level so all receipt display paths (not just merge) benefit from it.

Fixed Issues

$ #78846
PROPOSAL: N/A

Tests

Create Transaction with pdf receipt.
Open Expenses tab on Reports page.
Go offline. (cmd + D, Force offline)
Open console and execute this:

Onyx.merge('transactions_<TransactionID>, {"receipt": {
                        "source": null, 
                    },})

Open the expense to view the attached receipt
Verify the PDF receipt loads and previews correctly in the UI

Verify that no errors appear in the JS console

Offline tests

Create Transaction with pdf receipt.
Open Expenses tab on Reports page.
Go offline. (cmd + D, Force offline)
Open console and execute this:

Onyx.merge('transactions_<TransactionID>, {"receipt": {
                        "source": null, 
                    },})

Open the expense to view the attached receipt
Verify the PDF receipt loads and previews correctly in the UI

QA Steps

Create expense via email.
Open the expense to view the receipt
Verify the PDF receipt loads and displays correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

receipts-web.mov

…ssing When receipts are added via email or billing, the backend sometimes provides receipt.filename without receipt.source. This causes the receipt viewer to receive a blank URL, leaving PDF previews empty. Apply the same fallback used in MergeTransactionUtils directly in getThumbnailAndImageURIs so all receipt display paths benefit: construct the URL as https://www.expensify.com/receipts/{filename} when source is missing but filename exists. Co-authored-by: Jan Nowakowski <jnowakow@users.noreply.github.com>

melvin-bot · 2026-02-10T10:28:55Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c460bc9da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-02-10T10:55:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONFIG.ts	`84.37% <ø> (ø)`
src/libs/MergeTransactionUtils.ts	`72.22% <ø> (-0.14%)`	⬇️
src/libs/ReceiptUtils.ts	`75.00% <66.66%> (-4.17%)`	⬇️
... and 22 files with indirect coverage changes

trjExpensify

Nice clean up! 👍

mananjadhav · 2026-02-15T18:28:29Z

I tried testing this in different ways - preloaded attachment, not opened attachment, etc. But it always ends up not loading the PDF preview.

web-pdf-receipts-no-preview.mov

jnowakow · 2026-02-17T12:11:02Z

@mananjadhav I think it's because you are using network tab to go offline instead of our debug tools (cmd + d). If you disable internet through network tab PDF cannot be downloaded so it displays default view. Our debug tools probably disable just API calls instead of completely blocking Internet allowing the pdf to be downloaded. Can you retest it?

…missing

mananjadhav · 2026-02-19T15:53:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web-pdf-source.mov

mananjadhav

Because this needs manual update of Onyx store, I am uploading a screenshot of Web only.

melvin-bot · 2026-02-19T15:54:44Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #78846 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mananjadhav · 2026-02-24T05:59:14Z

Quick bump @AndrewGable

jnowakow · 2026-02-24T11:28:52Z

@mananjadhav I think @AndrewGable is OOO this week

OSBotify · 2026-03-04T18:41:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-04T18:45:21Z

🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-04T18:50:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81960.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8586d1c-9a9d226-1f8b3c2169c4e39fc31f78704a03127a9c370fa8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8586d1c-9a9d226-2961bf44343999f317e9360d271549983dc859af/index.html

Web 🕸️
https://81960.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-06T04:14:03Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.32-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-06T22:43:16Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.3.32-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot and others added 2 commits February 10, 2026 09:29

Use config instead of hardcoded urls

2c460bc

jnowakow requested review from a team as code owners February 10, 2026 10:28

melvin-bot Bot assigned jnowakow Feb 10, 2026

melvin-bot Bot requested review from mananjadhav and trjExpensify and removed request for a team February 10, 2026 10:28

melvin-bot Bot removed the request for review from a team February 10, 2026 10:28

github-actions Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/libs/ReceiptUtils.ts

chatgpt-codex-connector Bot reviewed Feb 10, 2026

View reviewed changes

Comment thread src/libs/ReceiptUtils.ts

Fix prettier and apply suggestions

17645ba

jnowakow mentioned this pull request Feb 10, 2026

Fix PDF receipts not loading when receipt.source is missing #81950

Closed

52 tasks

trjExpensify previously approved these changes Feb 10, 2026

View reviewed changes

Merge branch 'main' into jnowakow/fix-pdf-recipt-loading-when-source-…

f8cd5ab

…missing

jnowakow dismissed trjExpensify’s stale review via f8cd5ab February 17, 2026 12:23

Merge branch 'main' into jnowakow/fix-pdf-recipt-loading-when-source-…

39062cb

…missing

mananjadhav approved these changes Feb 19, 2026

View reviewed changes

melvin-bot Bot requested a review from AndrewGable February 19, 2026 15:54

MelvinBot mentioned this pull request Feb 27, 2026

Report - Cannot view report comment attachment(s) in New Expensify #82253

Closed

7 tasks

AndrewGable approved these changes Mar 4, 2026

View reviewed changes

AndrewGable merged commit 8586d1c into Expensify:main Mar 4, 2026
30 checks passed

OSBotify mentioned this pull request Mar 6, 2026

Deploy Checklist: New Expensify 2026-03-06 #84352

Closed

92 tasks

melvin-bot Bot mentioned this pull request Mar 6, 2026

[Due for payment 2026-03-13] PDF receipts attached to expenses do not load or preview in the UI #78846

Closed

7 tasks

Uh oh!

Conversation

jnowakow commented Feb 10, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 10, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Feb 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Feb 15, 2026

Uh oh!

jnowakow commented Feb 17, 2026

Uh oh!

mananjadhav commented Feb 19, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Feb 19, 2026

Uh oh!

mananjadhav commented Feb 24, 2026

Uh oh!

jnowakow commented Feb 24, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

OSBotify commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Feb 10, 2026 •

edited by github-actions Bot

Loading