Added correct announcements for Language picker on native platforms by Uzaifm127 · Pull Request #81013 · Expensify/App

Uzaifm127 · 2026-01-30T14:27:48Z

Explanation of Change

Added the correct announcement for Language picker.
Added the announcement and role to Done button in iOS for Language picker.

Fixed Issues

$ #77534
$ #77541
$ #77546
$ #79866
PROPOSAL: #79866 (comment)

Tests

Precondition for Test 1 and Test 2: You must be logged out.

Test 1: Incorrect announcement for language picker - #77541

Using Android TalkBack, open the Expensify app.
Swipe right to focus to the 'Language' picker at the bottom of the page.
Verify that the Talkback announces Collapsed, Language, combobox correctly when focused on Language picker.

Test 2: Done button in iOS - #77534 and #77546

Using iOS VoiceOver, open the Expensify app
Swipe to the 'Language' dropdown button and double-tap to activate
Swipe to the 'Done' button in the picker view
Verify that the Button is announced with button role.
Swipe once left
Verify that the focused control is announced with a button role and descriptive name as 'Dismiss'.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

language-picker-android-native.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-01-30T14:27:56Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2026-01-30T14:39:54Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Picker/BasePicker.tsx	`53.94% <ø> (ø)`
... and 22 files with indirect coverage changes

melvin-bot · 2026-01-30T17:21:57Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-30T17:24:15Z

+                    touchableWrapperProps={{
+                        accessible: true,
+                        accessibilityRole: CONST.ROLE.COMBOBOX,
+                        accessibilityLabel: translate('languagePage.language'),


❌ CONSISTENCY-2 (docs)

The accessibility label translate('languagePage.language') is hardcoded specifically for the language picker, but BasePicker is a generic component used throughout the app for many different purposes (taxes, reports, distance rates, custom fields, etc.).

Suggested fix:

Add an optional accessibilityLabel prop to BasePickerProps and pass it from the parent component:

// In BasePicker.tsx type BasePickerProps<TPickerValue> = { // ... existing props accessibilityLabel?: string; }; // Use it in touchableWrapperProps touchableWrapperProps={{ accessible: true, accessibilityRole: CONST.ROLE.COMBOBOX, accessibilityLabel: accessibilityLabel ?? label, // Use prop or fall back to label accessibilityState: {disabled: isDisabled, expanded: isHighlighted}, }}

Then in LocalePicker.tsx, pass the specific label:

<Picker accessibilityLabel={translate('languagePage.language')} // ... other props />

This keeps BasePicker generic and reusable while allowing each usage to specify its own appropriate accessibility label.

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

github-actions · 2026-01-30T17:24:26Z

+                        importantForAccessibility: 'no-hide-descendants',
+                    }}
+                    touchableDoneProps={{
+                        accessibilityRole: CONST.ROLE.BUTTON,


❌ CONSISTENCY-2 (docs)

The accessibility label for the Done button uses translate('common.dismiss'), but this might not be appropriate for all contexts where BasePicker is used. For example, when selecting a tax rate or currency, "Dismiss" might not accurately describe the action (which is more like "Done" or "Confirm Selection").

Suggested fix:

Add an optional doneButtonAccessibilityLabel prop to allow customization:

type BasePickerProps<TPickerValue> = { // ... existing props doneButtonAccessibilityLabel?: string; }; // In touchableDoneProps touchableDoneProps={{ accessibilityRole: CONST.ROLE.BUTTON, accessibilityLabel: doneButtonAccessibilityLabel ?? translate('common.dismiss'), }}

This allows parent components to provide context-specific labels when needed while maintaining a sensible default.

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@Uzaifm127 Can you take a look at this comment?

This comment is not relevant now because I removed the accessibilityLabel from touchableDoneProps in this commit.

I mentioned here why dismiss isn't required in touchableDoneProps.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8157ce068d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-30T17:26:51Z

+                    touchableWrapperProps={{
+                        accessible: true,
+                        accessibilityRole: CONST.ROLE.COMBOBOX,
+                        accessibilityLabel: translate('languagePage.language'),
+                        accessibilityState: {disabled: isDisabled, expanded: isHighlighted},


Avoid hardcoding language label for all pickers

BasePicker is the shared implementation for all pickers (via src/components/Picker/index*.tsx), so hardcoding touchableWrapperProps.accessibilityLabel to translate('languagePage.language') will make every native picker announce itself as “Language” (e.g., currency, time zone, category). This is an accessibility regression outside the language screen and will mislead screen readers. Consider passing a label prop down from the caller or conditionally setting the label only for the language picker.

Useful? React with 👍 / 👎.

trjExpensify

Part of the accessibility project.

shubham1206agra · 2026-02-03T14:01:11Z

I will take over here

mananjadhav · 2026-02-03T16:26:25Z

I'll pick this one as discussed here.

…6-language-picker-announcements-on-native-platforms

Uzaifm127 · 2026-02-03T18:31:12Z

@mananjadhav Added the codex suggestions. I'll go deeper into third subissue tomorrow.

You can review the first two sub issues now.

Uzaifm127 · 2026-02-11T18:20:06Z

@cristipaval Please re run the adhoc build, I merged the latest main into this branch after a minute you ran the build, there is a script on the latest main which wasn't there in this branch.

@mananjadhav The failing checks seems unrelated to this PR, can you confirm?

github-actions · 2026-02-11T18:42:12Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-11T18:45:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81013.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-996dafc74332f0a6d29ec55fb4d54202a3998330-e7fd5d7065cf1c6be8fe767bbc6cf1d26bbe6aa0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-996dafc74332f0a6d29ec55fb4d54202a3998330-86ed1c2dedabf3b5bdf984bc4464f19c84e7496d/index.html

Web 🕸️
https://81013.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mananjadhav · 2026-02-12T17:42:01Z

@Uzaifm127 Can you sync latest main to see if it fixes it?

…6-language-picker-announcements-on-native-platforms

Uzaifm127 · 2026-02-12T18:00:57Z

@mananjadhav If you meant the adhoc build failure then it is resolved.

Merged the latest main.

Uzaifm127 · 2026-02-17T11:28:45Z

@mananjadhav Bump for updates on this

rushatgabhane · 2026-02-18T07:37:50Z

@mananjadhav can you please prioritize this? this PR is quite old 😅

mananjadhav · 2026-02-19T11:38:00Z

I was out yesterday but I'll finish it today.

Uzaifm127 · 2026-02-24T06:40:30Z

@mananjadhav Bump for updates on this.

mananjadhav · 2026-02-24T06:56:13Z

I just downloaded the adhoc build and testing it on my physical device.

mananjadhav · 2026-02-24T08:31:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-languag-picker.mp4

Android: mWeb Chrome

iOS: HybridApp

ios-language-picker-announcement.mp4

iOS: mWeb Safari

mweb-safari-languag-picker-announcement.mp4

MacOS: Chrome / Safari

web-languag-picker-voice-over.mov

…6-language-picker-announcements-on-native-platforms

mananjadhav · 2026-02-24T09:21:09Z

I should have access to the Android tablet in an hour. Will finish the checklist then.

mananjadhav · 2026-02-24T11:10:37Z

I am trying to test this on Android tablet. With the talkback enabled, I am unable to click on the language picket at all. I’ll try to test it once more.

Screenrecorder-2026-02-24-16-33-36-2.mp4

Uzaifm127 · 2026-02-24T12:23:10Z

@mananjadhav

The adhoc build on android is working fine from my side, I've tested the adhoc build on Android and language picker is selecting.

Screenrecording_20260224_171222.1.mp4

mananjadhav · 2026-02-24T15:40:09Z

Please ignore it was an issue with my tablet. It didn't select even when the TalkBack was off and prod version.

mananjadhav

I have issues with my Android chrome.

github-actions · 2026-02-24T17:03:23Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-24T17:11:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #81013.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0431149-e70bb46-d515a707c48b71678909c7d8b78c7e9fe0f2f370/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0431149-e70bb46-ca4c47a36b4bb4d7f95b9dd90f6900b20dfe4c57/index.html

Web 🕸️
https://81013.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-25T18:23:21Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:54:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Added correct announcements for Language picker

8157ce0

melvin-bot Bot assigned Uzaifm127 Jan 30, 2026

Uzaifm127 marked this pull request as ready for review January 30, 2026 17:21

Uzaifm127 requested review from a team as code owners January 30, 2026 17:21

melvin-bot Bot requested review from dominictb and trjExpensify and removed request for a team January 30, 2026 17:21

github-actions Bot reviewed Jan 30, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jan 30, 2026

View reviewed changes

trjExpensify previously approved these changes Jan 31, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

dominictb mentioned this pull request Feb 3, 2026

[$250] [Accessibility][Tracking] Language picker accessibility issues on Sign in screen #79866

Closed

3 tasks

cristipaval requested review from shubham1206agra and removed request for dominictb February 3, 2026 16:18

cristipaval requested review from mananjadhav and removed request for shubham1206agra February 3, 2026 17:40

Uzaifm127 added 2 commits February 3, 2026 23:46

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/7986…

5339161

…6-language-picker-announcements-on-native-platforms

Added codex and github actions suggestions

9d619bb

Uzaifm127 dismissed trjExpensify’s stale review via 9d619bb February 3, 2026 18:27

situchan mentioned this pull request Feb 3, 2026

Make it more apparent in the expense chat carousel view when expenses are added to a report #71390

Open

Removed Dismiss label from Done button

cf2d92f

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/7986…

a418258

…6-language-picker-announcements-on-native-platforms

Merge branch 'main' of https://github.com/Uzaifm127/App into fix/7986…

41e86f4

…6-language-picker-announcements-on-native-platforms

mananjadhav approved these changes Feb 24, 2026

View reviewed changes

melvin-bot Bot requested a review from cristipaval February 24, 2026 16:15

cristipaval approved these changes Feb 24, 2026

View reviewed changes

cristipaval merged commit 0431149 into Expensify:main Feb 24, 2026
30 checks passed

OSBotify mentioned this pull request Feb 25, 2026

Deploy Checklist: New Expensify 2026-02-25 #83466

Closed

rushatgabhane mentioned this pull request Feb 26, 2026

Screen Reader: Sign in: The button in the picker view is announced without a button role #77546

Closed

This was referenced Mar 3, 2026

[$250] [A11y] Screen Reader: Sign in: The button to dismiss the picker view is not announced #77534

Closed

Screen Reader: Sign in: Incorrect announcement of the 'Language' dropdown #77541

Closed

TaduJR mentioned this pull request Mar 13, 2026

fix(a11y): update picker-select fork, remove Android TalkBack workaround #85244

Merged

54 tasks

Conversation

Uzaifm127 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1: Incorrect announcement for language picker - #77541

Test 2: Done button in iOS - #77534 and #77546

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

codecov Bot commented Jan 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jan 30, 2026

Uh oh!

github-actions Bot Jan 30, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

github-actions Bot Jan 30, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-2 (docs)

Uh oh!

mananjadhav Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uzaifm127 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Feb 3, 2026

Uh oh!

This comment was marked as resolved.

mananjadhav commented Feb 3, 2026

Uh oh!

Uzaifm127 commented Feb 3, 2026

Uh oh!

Uzaifm127 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 11, 2026

Uh oh!

github-actions Bot commented Feb 11, 2026

Uh oh!

mananjadhav commented Feb 12, 2026

Uh oh!

Uzaifm127 commented Feb 12, 2026

Uh oh!

Uzaifm127 commented Feb 17, 2026

Uh oh!

rushatgabhane commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Feb 19, 2026

Uh oh!

Uzaifm127 commented Feb 24, 2026

Uh oh!

mananjadhav commented Feb 24, 2026

Uh oh!

mananjadhav commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Feb 24, 2026

Uzaifm127 commented Jan 30, 2026 •

edited

Loading

codecov Bot commented Jan 30, 2026 •

edited by github-actions Bot

Loading

Uzaifm127 commented Feb 11, 2026 •

edited

Loading

rushatgabhane commented Feb 18, 2026 •

edited

Loading

mananjadhav commented Feb 24, 2026 •

edited

Loading