[No QA] Create import-via-csv.md#80548
Conversation
This comment has been minimized.
This comment has been minimized.
|
@dylanexpensify same for this one, should this still be in draft mode? |
|
pending |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d71572e037
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@dylanexpensify line 92 is:
Can you add this in, or can we remove it? |
|
Yea let's remove that @jliexpensify! I see one other change I want to make too - I will go in and commit those changes, then approve. You should then be able to merge! |
|
Cool thanks @stephanieelliott - let me know once you've made those changes and I'll approve 👍 |
…ns-From-a-Spreadsheet.md
|
All set @jliexpensify! |
|
A preview of your ExpensifyHelp changes have been deployed to https://4a2096f8.helpdot.pages.dev ⚡️ Updated articles: |
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
| # Import Company Card Transactions From a Spreadsheet | ||
|
|
||
| If your bank isn't supported by a direct connection, you can still import company card transactions into Expensify using a CSV, TXT, XLX or XLSX file. This lets you bring your own card (BYOC) and manually upload company card transactions when a direct bank connection is unavailable. | ||
|
|
There was a problem hiding this comment.
Typo: "XLX" should be "XLS". The FAQ section on line 78 correctly uses "XLS". This same typo also appears on lines 29 and 51.
|
|
||
| ## How to import company card transactions from a spreadsheet | ||
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), go to the **Workspaces** and select your workspace. |
There was a problem hiding this comment.
Style: "go to the Workspaces" reads awkwardly — drop the article "the" so it reads "go to Workspaces and select your workspace."
|
|
||
| 1. In the navigation tabs (on the left on web, on the bottom on mobile), go to the **Workspaces** and select your workspace. | ||
| 2. Click **Company Cards**. | ||
| 3. Click on **Add card**. |
There was a problem hiding this comment.
Naming consistency: "Click on Add card" has two issues: (1) Use "Click" not "Click on" to match the style used in all other steps. (2) The label is "Add card" here but "Add Card" on the next line — pick whichever matches the actual UI label and use it consistently.
| 5. Choose **Import transactions from file**. | ||
| 6. Choose the CSV, TXT, XLX or XLSX file you want to upload. | ||
| 7. Enter a name for the card feed. | ||
| 8. Set your field mappings (e.g., Card Number, Date, Amount, Merchant). |
There was a problem hiding this comment.
Terminology violation: Per naming conventions, use "members" instead of "users." The correct phrasing would be: "Assign cards to members based on the transactions in the file."
|
|
||
| --- | ||
|
|
||
| ## How to upload additional transactions to an existing card feed |
There was a problem hiding this comment.
Navigation inconsistency: Step 1 in this section uses abbreviated navigation ("Go to Workspaces > Company Cards") but step 1 in the first procedure (line 24) uses the full pattern with navigation tabs. For consistency and per the Navigation Instruction Standards, use the same format: "In the navigation tabs (on the left on web, on the bottom on mobile), go to Workspaces and select your workspace." then add a step to click Company Cards.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new article for importing company card transactions from a spreadsheet. The article is well-structured, follows the single-H1 rule, includes complete YAML metadata with internalScope, uses task-based headings throughout, and provides clear procedural steps. A few mechanical issues need attention before merge. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md governance standards. |
| 7. Click **Import**. | ||
|
|
||
| **Note:** Previously mapped fields will auto-fill to save time. | ||
|
|
There was a problem hiding this comment.
Navigation inconsistency: Same issue as line 47 — this section also uses the abbreviated "Go to Workspaces > Company Cards" format instead of the full navigation pattern established in the first procedure. Apply the same fix for consistency.
| - If you already have a company card feed set up, click the feed name to see **Add Card**. | ||
| 5. Choose **Import transactions from file**. | ||
| 6. Choose the CSV, TXT, XLX or XLSX file you want to upload. | ||
| 7. Enter a name for the card feed. |
There was a problem hiding this comment.
Step formatting: The field mapping examples are in parentheses — "e.g., Card Number, Date, Amount, Merchant" — but the governance rules require steps to be clear and action-oriented. Consider rephrasing to: "Map the required fields: Card Number, Date, Amount, and Merchant." This also aligns the step with the FAQ answer on lines 82-87 which lists these as required columns.
| 5. Confirm deletion. | ||
|
|
||
| **Note:** This removes the card feed and any **Deleted**, **Unreported**, and **Draft** expenses. **Outstanding**, **Approved** and **Paid** expenses are not deleted. [Learn more about expense and report statuses](/articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions#report-statuses). | ||
|
|
There was a problem hiding this comment.
Cross-linking placement: Per the cross-linking standards, links should not be placed inside procedural steps or tightly coupled with step-like instructions. The link here at the end of the Note is acceptable, but verify that the linked path /articles/new-expensify/reports-and-expenses/Understanding-Report-Statuses-and-Actions#report-statuses exists and the anchor is valid.
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.79-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.79-4 🚀
|
Tracking - https://github.com/Expensify/Expensify/issues/571728
Project Resource GH - https://github.com/Expensify/Expensify/issues/593163
Explanation of Change
Updating help site to account for new changes
Fixed Issues
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari