Revert "[CP Staging] Revert "Merge pull request #79299 from parasharrajat/fix/whisper""#80121
Conversation
…parasharrajat/fix/whisper""
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77a5278999
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (isPolicyExpenseChat(report)) { | ||
| inviteToRoomAction(report, ancestors, invitedEmailsToAccountIDs, currentUserPersonalDetails.timezone ?? CONST.DEFAULT_TIME_ZONE); | ||
| } else { | ||
| inviteToRoom(reportID, invitedEmailsToAccountIDs, formatPhoneNumber); |
There was a problem hiding this comment.
Preserve invite whisper for non-expense rooms
This change routes all non‑isPolicyExpenseChat invites through inviteToRoom, which only updates participants/metadata and does not create a report action. inviteToRoomAction is the only path that posts the concierge whisper (addComment in src/libs/actions/Report.ts), so workspace rooms like policyAdmins/policyAnnounce will no longer show the invite whisper when adding a non‑member. If the UI/tests expect that whisper to appear in workspace chats, this is a regression; consider keeping inviteToRoomAction for those room types or explicitly creating the whisper action alongside the API invite.
Useful? React with 👍 / 👎.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-13.at.11.33.58.movAndroid: mWeb ChromeScreen.Recording.2026-01-13.at.11.32.26.moviOS: HybridAppScreen.Recording.2026-01-13.at.11.32.58.moviOS: mWeb SafariScreen.Recording.2026-01-13.at.11.31.48.movMacOS: Chrome / SafariScreen.Recording.2026-01-13.at.11.25.53.mov |
|
Tested the blocker here: #80101 (comment) |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.8-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀
|
Reverts #80117
Explanation of Change
Fixed Issues
$ #77336
PROPOSAL: #77336
Tests
Offline tests
Follow upto step 6.
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
11.01.2026_21.51.03_REC.mp4