fix: derive currentReceipt from page to fix wrong receipt deletion by MobileMage · Pull Request #79965 · Expensify/App

MobileMage · 2026-01-20T13:13:38Z

Explanation of Change

In the Money Requests multi-scan flow, the ReceiptView component maintained two pieces of state that should stay in sync but didn't:

page - the current carousel index, updated when user navigates via arrows
currentReceipt - the receipt object used for deletion

The currentReceipt was only updated via a useEffect that depended on route.params.transactionID, which doesn't change during carousel navigation. This caused the delete action to remove the originally opened receipt instead of the currently viewed one.

This fix derives currentReceipt directly from the page index instead of storing it as separate state, ensuring it always reflects the currently displayed receipt.

Fixed Issues

$ #79304
PROPOSAL:

Tests

FAB → Scan → Enable multiple scan
Capture 4 receipts
Tap on the last receipt preview (4th) to open fullscreen view
Click the left navigation arrow to view the 3rd receipt
Click delete
Verify the 3rd receipt (currently viewed) is deleted, not the 4th

Verify that no errors appear in the JS console

Offline tests

N/A - This flow requires camera/receipt capture which doesn't function offline.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

79304-android-native.mp4

Android: mWeb Chrome

79304-android-mweb.mp4

iOS: Native

79304-ios-native.mov

iOS: mWeb Safari

79304-ios-mweb.mov

MacOS: Chrome / Safari

79304-desktop-web.mp4

melvin-bot · 2026-01-20T13:13:45Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-01-20T13:13:51Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-01-20T13:23:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...uest/step/IOURequestStepScan/ReceiptView/index.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

trjExpensify

I was on the parent issue for this one! 👍

rlinoz · 2026-01-22T12:07:20Z

@MobileMage can you check the eslint failure please?

friendly bump @suneox for review

suneox · 2026-01-22T18:09:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-01-23.at.01.03.09.mp4

Android: mWeb Chrome

CleanShot.2026-01-23.at.00.56.49.mp4

iOS: HybridApp

CleanShot.2026-01-23.at.00.59.17.mp4

iOS: mWeb Safari

CleanShot.2026-01-23.at.00.54.49.mp4

MacOS: Chrome / Safari

CleanShot.2026-01-23.at.00.52.13.mp4

suneox · 2026-01-22T18:12:51Z

Overall, the change set looks good. We’re just waiting for @MobileMage to merge the latest main to resolve the ESLint issue.

In the multi-scan flow, navigating between receipts with carousel arrows would update the page index but not the currentReceipt state, causing the delete action to remove the originally opened receipt instead of the currently viewed one. This change derives currentReceipt directly from the page index instead of storing it as separate state, ensuring it always reflects the currently displayed receipt.

github-actions · 2026-01-23T12:20:26Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-01-23T12:25:30Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #79965.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9ce6569-6c0ce948aa055a473357cdfc7ae37e16b6833d11/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9ce6569-6c356075cb7e03c1a759a489e310dd573684192a/index.html

Web 🕸️
https://79965.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-01-23T13:07:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-23T22:34:58Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.8-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-26T21:57:06Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.8-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MobileMage requested review from a team as code owners January 20, 2026 13:13

melvin-bot Bot assigned MobileMage Jan 20, 2026

melvin-bot Bot requested review from suneox and trjExpensify and removed request for a team January 20, 2026 13:13

melvin-bot Bot requested review from a team and rlinoz and removed request for a team January 20, 2026 13:13

trjExpensify approved these changes Jan 21, 2026

View reviewed changes

MobileMage force-pushed the fix/79304-delete-wrong-receipt branch from 6c742ed to 46d3a81 Compare January 22, 2026 19:16

rlinoz added the Ready To Build label Jan 23, 2026

rlinoz approved these changes Jan 23, 2026

View reviewed changes

rlinoz merged commit a5e4a32 into Expensify:main Jan 23, 2026
30 checks passed

OSBotify mentioned this pull request Jan 23, 2026

Deploy Checklist: New Expensify 2026-01-23 #80389

Closed

43 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: derive currentReceipt from page to fix wrong receipt deletion#79965

fix: derive currentReceipt from page to fix wrong receipt deletion#79965
rlinoz merged 1 commit into
Expensify:mainfrom
MobileMage:fix/79304-delete-wrong-receipt

MobileMage commented Jan 20, 2026

Uh oh!

melvin-bot Bot commented Jan 20, 2026

Uh oh!

melvin-bot Bot commented Jan 20, 2026

Uh oh!

codecov Bot commented Jan 20, 2026 •

edited by github-actions Bot

Loading

Uh oh!

trjExpensify left a comment

Uh oh!

rlinoz commented Jan 22, 2026

Uh oh!

suneox commented Jan 22, 2026

Uh oh!

suneox commented Jan 22, 2026

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

MobileMage commented Jan 20, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 20, 2026

Uh oh!

melvin-bot Bot commented Jan 20, 2026

Uh oh!

codecov Bot commented Jan 20, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Jan 22, 2026

Uh oh!

suneox commented Jan 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox commented Jan 22, 2026

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

github-actions Bot commented Jan 23, 2026

Uh oh!

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 23, 2026

Uh oh!

OSBotify commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jan 20, 2026 •

edited by github-actions Bot

Loading